From: Gregory CLEMENT <gregory.clement@bootlin.com>
To: Baruch Siach <baruch@tkos.co.il>
Cc: Russell King <linux@armlinux.org.uk>,
Andrew Lunn <andrew@lunn.ch>, Jason Cooper <jason@lakedaemon.net>,
linux-arm-kernel@lists.infradead.org,
Sebastian Hesselbarth <sebastian.hesselbarth@gmail.com>
Subject: Re: [PATCH] arm64: dts: marvell: mcbin: fix PCIe reset signal
Date: Tue, 11 Dec 2018 16:31:15 +0100 [thread overview]
Message-ID: <87efaot70c.fsf@bootlin.com> (raw)
In-Reply-To: <8a9652066a649b5349b76c823bef946024161275.1544441887.git.baruch@tkos.co.il> (Baruch Siach's message of "Mon, 10 Dec 2018 13:38:07 +0200")
Hi Baruch,
On lun., déc. 10 2018, Baruch Siach <baruch@tkos.co.il> wrote:
> The MPP52 signal is on the seconds GPIO instance of CP0, which
> corresponds to the &cp0_gpio2 handle.
>
> Rename the property name to the standard '-gpios' suffix while at it.
>
> Fixes: b83e1669adce6 ("arm64: dts: marvell: mcbin: add support for PCIe")
> Signed-off-by: Baruch Siach <baruch@tkos.co.il>
With the last change in armada-8040-mcbin.dts this patch no more apply
on mvebu/dt64.
Gregory
> ---
> arch/arm64/boot/dts/marvell/armada-8040-mcbin.dts | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm64/boot/dts/marvell/armada-8040-mcbin.dts b/arch/arm64/boot/dts/marvell/armada-8040-mcbin.dts
> index 56fa44860909..46dacfc08cec 100644
> --- a/arch/arm64/boot/dts/marvell/armada-8040-mcbin.dts
> +++ b/arch/arm64/boot/dts/marvell/armada-8040-mcbin.dts
> @@ -183,7 +183,7 @@
> pinctrl-0 = <&cp0_pcie_pins>;
> num-lanes = <4>;
> num-viewport = <8>;
> - reset-gpio = <&cp0_gpio1 20 GPIO_ACTIVE_LOW>;
> + reset-gpios = <&cp0_gpio2 20 GPIO_ACTIVE_LOW>;
> status = "okay";
> };
>
> --
> 2.19.2
>
--
Gregory Clement, Bootlin
Embedded Linux and Kernel engineering
http://bootlin.com
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2018-12-11 15:31 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-10 11:38 [PATCH] arm64: dts: marvell: mcbin: fix PCIe reset signal Baruch Siach
2018-12-11 15:31 ` Gregory CLEMENT [this message]
2018-12-11 17:09 ` Baruch Siach
2018-12-12 8:09 ` Gregory CLEMENT
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87efaot70c.fsf@bootlin.com \
--to=gregory.clement@bootlin.com \
--cc=andrew@lunn.ch \
--cc=baruch@tkos.co.il \
--cc=jason@lakedaemon.net \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux@armlinux.org.uk \
--cc=sebastian.hesselbarth@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).