From: Gregory CLEMENT <gregory.clement@bootlin.com>
To: "Sjoerd Simons" <sjoerd@collabora.com>, "Marek Behún" <kabel@kernel.org>
Cc: "Pali Rohár" <pali@kernel.org>,
kernel@collabora.com, "Andrew Lunn" <andrew@lunn.ch>,
"Conor Dooley" <conor+dt@kernel.org>,
"Krzysztof Kozlowski" <krzysztof.kozlowski+dt@linaro.org>,
"Rob Herring" <robh+dt@kernel.org>,
"Sebastian Hesselbarth" <sebastian.hesselbarth@gmail.com>,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 0/3] Moxtet bus fixes
Date: Fri, 08 Dec 2023 15:51:20 +0100 [thread overview]
Message-ID: <87fs0ceoif.fsf@BL-laptop> (raw)
In-Reply-To: <20231128213536.3764212-1-sjoerd@collabora.com>
Hello Marek and Sjoerd,
> It seems the moxtet bus support was broken since 21aad8ba615e ("arm64:
> dts: armada-3720-turris-mox: Add missing interrupt for RTC") for two
> reasons:
> * The moxtet irq isn't marked as shared so the driver fails to load if
> the rtc driver gets set up first.
> * The dts change didn't set the IRQ type, so in case the rtc driver got
> probed first irq setup ended up wrong (rising instead of falling edge).
>
> On top of that the moxtet module isn't auto-loading due to a missing spi
> table
>
> Changes in v2:
> - Add cover letter
> - Add patch to set the irq type
>
> Sjoerd Simons (3):
> bus: moxtet: Mark the irq as shared
> bus: moxtet: Add spi device table
> arm64: dts: armada-3720-turris-mox: set irq type for RTC
I only received the previous patch in my inbox, I plan to apply it. But
what about the 2 other patches ? Marek will you do a pull request with
these 2 patches or do you expect that I take them also ?
Regards,
Gregory
>
> arch/arm64/boot/dts/marvell/armada-3720-turris-mox.dts | 2 +-
> drivers/bus/moxtet.c | 9 ++++++++-
> 2 files changed, 9 insertions(+), 2 deletions(-)
>
> --
> 2.43.0
>
--
Gregory Clement, Bootlin
Embedded Linux and Kernel engineering
http://bootlin.com
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2023-12-08 14:51 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-28 21:35 [PATCH v2 0/3] Moxtet bus fixes Sjoerd Simons
2023-11-28 21:35 ` [PATCH v2 3/3] arm64: dts: armada-3720-turris-mox: set irq type for RTC Sjoerd Simons
2023-12-07 14:43 ` Marek Behún
2023-12-08 14:51 ` Gregory CLEMENT [this message]
2023-12-08 15:17 ` [PATCH v2 0/3] Moxtet bus fixes Marek Behún
2023-12-15 14:47 ` Gregory CLEMENT
2023-12-15 15:16 ` Sjoerd Simons
2023-12-18 10:19 ` Sjoerd Simons
2023-12-20 13:55 ` Gregory CLEMENT
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87fs0ceoif.fsf@BL-laptop \
--to=gregory.clement@bootlin.com \
--cc=andrew@lunn.ch \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=kabel@kernel.org \
--cc=kernel@collabora.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pali@kernel.org \
--cc=robh+dt@kernel.org \
--cc=sebastian.hesselbarth@gmail.com \
--cc=sjoerd@collabora.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).