From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 96510C4167B for ; Fri, 8 Dec 2023 14:51:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-ID:Date:References :In-Reply-To:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=HTXZGiqIQDLkEqdgXxZi+Qb1YkBzSQgGdwjD6eCbJHY=; b=lw6XcTCjlOBOSV 3UliQPVxmyi9+ww4v4ZbuXPIClihy2AFeD94CBUK4XHWoeavDbdiHhY7I5awWfDsDkH1a0ITR7Wmx vcVjIp0Uqt7jVx8veKr8uk8TXIfGJbu82x4juFQih4le+uyXmqFfr0uZQrSRd3Lwa77/Pr4gFCiYO JAblCCeat0QrG8PGh2s4Y2U/1sWUPOErgI+UCAi9DBhqult3ScVxSiM0GTd3z+OId98v3f3gGpzf3 fQTZJctgpWZllSvy3MqapZbcOIc/flFm+GHGHbq0TWuh7bG7fUcsuAyVBFE5fA9usu7hZPDkhWm8h R92vmeC2zL+tpTmkBLSg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1rBcCP-00Fno9-2B; Fri, 08 Dec 2023 14:51:29 +0000 Received: from relay1-d.mail.gandi.net ([2001:4b98:dc4:8::221]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1rBcCL-00FnlZ-36 for linux-arm-kernel@lists.infradead.org; Fri, 08 Dec 2023 14:51:27 +0000 Received: by mail.gandi.net (Postfix) with ESMTPSA id CBE8524000C; Fri, 8 Dec 2023 14:51:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=gm1; t=1702047081; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=kOA4z6r+6Tw9VE2/Ykzr/TDzoWZUyODcnTrVc7hxXhE=; b=Nz7RuFjJzuOae6pn3HjyKDKpoZWHo8YWlgtv7SMma0uV3151+Q1FgTsjczMHQG9memeizl 4KoefwHeD1WWlsWwpaukBGgjg1wgiQ6B3ZkbfkX60WWD90enBmYY2/weOWtafL1CUoS85Y SSXcdanHGGIAvFLKwgoRhHLDaYokxvLxikGvZQ+H9IeIQOggm32d2tjVU6XGpaSab5nsqr XIhbdz+of9BvnNfp0obfhicqMzDNasuh1x3Wev3KucI6Zuq+YRQyUs5If2hIHzDF41OjkV aBsMXb54oMhz0pJn4VBXeChyGWx0OmZqp4SyfquEU5SbyeH0GiIxdJAFn1FMww== From: Gregory CLEMENT To: Sjoerd Simons , Marek =?utf-8?Q?Beh=C3=BAn?= Cc: Pali =?utf-8?Q?Roh=C3=A1r?= , kernel@collabora.com, Andrew Lunn , Conor Dooley , Krzysztof Kozlowski , Rob Herring , Sebastian Hesselbarth , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 0/3] Moxtet bus fixes In-Reply-To: <20231128213536.3764212-1-sjoerd@collabora.com> References: <20231128213536.3764212-1-sjoerd@collabora.com> Date: Fri, 08 Dec 2023 15:51:20 +0100 Message-ID: <87fs0ceoif.fsf@BL-laptop> MIME-Version: 1.0 X-GND-Sasl: gregory.clement@bootlin.com X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20231208_065126_314343_40C3F3C3 X-CRM114-Status: GOOD ( 16.60 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hello Marek and Sjoerd, > It seems the moxtet bus support was broken since 21aad8ba615e ("arm64: > dts: armada-3720-turris-mox: Add missing interrupt for RTC") for two > reasons: > * The moxtet irq isn't marked as shared so the driver fails to load if > the rtc driver gets set up first. > * The dts change didn't set the IRQ type, so in case the rtc driver got > probed first irq setup ended up wrong (rising instead of falling edge). > > On top of that the moxtet module isn't auto-loading due to a missing spi > table > > Changes in v2: > - Add cover letter > - Add patch to set the irq type > > Sjoerd Simons (3): > bus: moxtet: Mark the irq as shared > bus: moxtet: Add spi device table > arm64: dts: armada-3720-turris-mox: set irq type for RTC I only received the previous patch in my inbox, I plan to apply it. But what about the 2 other patches ? Marek will you do a pull request with these 2 patches or do you expect that I take them also ? Regards, Gregory > > arch/arm64/boot/dts/marvell/armada-3720-turris-mox.dts | 2 +- > drivers/bus/moxtet.c | 9 ++++++++- > 2 files changed, 9 insertions(+), 2 deletions(-) > > -- > 2.43.0 > -- Gregory Clement, Bootlin Embedded Linux and Kernel engineering http://bootlin.com _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel