From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 3DC30CDB465 for ; Mon, 16 Oct 2023 15:32:44 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-ID:Date:References :In-Reply-To:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=2zmDfApvt5q2gVnQmchISiBPKe5y2qwkTEHzuW7dxFE=; b=aSUpsI07Oc13vB SDDSw0FJzqVSemX5/BHH/fnipwg9K/EtPEiZUk0B+9QbNqmS8nToncID3IuqEjI2ODtnEdAeUgk7r eN4564SCIn2w/aoltpvpEnLWx3CRNXkQo8Wq/RpX8qHg2ubQVycPAqhC4HILKjhjwQNBL6+MkBGVP MIiCrXURd2qqF4KDBRRH6RiJ6CKco2pu+eZGOxPlmi2QHV+CiTr6TMRQADPHsVJmQepCM1NgtmriZ jikWmDVTgeUddMC31UYseJ+Wk0+zTWqlfiVCkCDLAJLjf9vWaT6dh8nUNhw9j6l4668E0WDMXF3dc uHfmUAXr1nfQ4WdQwUww==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qsPZm-009zBl-0Z; Mon, 16 Oct 2023 15:32:14 +0000 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qsPZj-009zAm-2k for linux-arm-kernel@lists.infradead.org; Mon, 16 Oct 2023 15:32:13 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1697470330; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=CRf3fYGKsTrlOhUDvR5Nm0aYucqIml+Eu+5HAJHgZQY=; b=JxPw819PgRIkDG2PqFxIl4iEk3gkp0brTSSBx6ikV7oiHucohOh7pI2nvu5XCaNtcidHel Q9vpTcdckzBGVUZV63aKthTMln5xyd4jiSWMJfF76Gu2NbAwEDmtm8VOb77RoqgZHW6K2h X2SHaLefFrxx3XcOTL5FkFrS8hnOm00= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-459-5rnxzrkYOMSSC8X6SHVcYg-1; Mon, 16 Oct 2023 11:30:16 -0400 X-MC-Unique: 5rnxzrkYOMSSC8X6SHVcYg-1 Received: from smtp.corp.redhat.com (int-mx10.intmail.prod.int.rdu2.redhat.com [10.11.54.10]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 7A50881B15E; Mon, 16 Oct 2023 15:30:15 +0000 (UTC) Received: from localhost (unknown [10.39.195.34]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 7448B492BFA; Mon, 16 Oct 2023 15:30:12 +0000 (UTC) From: Cornelia Huck To: Oliver Upton , kvm@vger.kernel.org Cc: kvmarm@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-perf-users@vger.kernel.org, Mark Brown , Jing Zhang , Zenghui Yu , Suzuki K Poulose , James Morse , Marc Zyngier , Paolo Bonzini , Adrian Hunter , Ian Rogers , Namhyung Kim , Jiri Olsa , Alexander Shishkin , Mark Rutland , Arnaldo Carvalho de Melo , Ingo Molnar , Peter Zijlstra , Oliver Upton Subject: Re: [PATCH v3 5/5] KVM: arm64: selftests: Test for setting ID register from usersapce In-Reply-To: <20231011195740.3349631-6-oliver.upton@linux.dev> Organization: "Red Hat GmbH, Sitz: Werner-von-Siemens-Ring 12, D-85630 Grasbrunn, Handelsregister: Amtsgericht =?utf-8?Q?M=C3=BCnchen=2C?= HRB 153243, =?utf-8?Q?Gesch=C3=A4ftsf=C3=BChrer=3A?= Ryan Barnhart, Charles Cachera, Michael O'Neill, Amy Ross" References: <20231011195740.3349631-1-oliver.upton@linux.dev> <20231011195740.3349631-6-oliver.upton@linux.dev> User-Agent: Notmuch/0.37 (https://notmuchmail.org) Date: Mon, 16 Oct 2023 17:30:06 +0200 Message-ID: <87fs2aegap.fsf@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.4.1 on 10.11.54.10 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20231016_083212_091431_98F7CACA X-CRM114-Status: GOOD ( 19.33 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, Oct 11 2023, Oliver Upton wrote: > From: Jing Zhang > > Add tests to verify setting ID registers from userspace is handled > correctly by KVM. Also add a test case to use ioctl > KVM_ARM_GET_REG_WRITABLE_MASKS to get writable masks. > > Signed-off-by: Jing Zhang > Signed-off-by: Oliver Upton > --- > tools/testing/selftests/kvm/Makefile | 1 + > .../selftests/kvm/aarch64/set_id_regs.c | 479 ++++++++++++++++++ > 2 files changed, 480 insertions(+) > create mode 100644 tools/testing/selftests/kvm/aarch64/set_id_regs.c (...) > +static void test_user_set_reg(struct kvm_vcpu *vcpu, bool aarch64_only) > +{ > + uint64_t masks[KVM_ARM_FEATURE_ID_RANGE_SIZE]; > + struct reg_mask_range range = { > + .addr = (__u64)masks, > + }; > + int ret; > + > + /* KVM should return error when reserved field is not zero */ > + range.reserved[0] = 1; > + ret = __vm_ioctl(vcpu->vm, KVM_ARM_GET_REG_WRITABLE_MASKS, &range); > + TEST_ASSERT(ret, "KVM doesn't check invalid parameters."); I think the code should first check for KVM_CAP_ARM_SUPPORTED_REG_MASK_RANGES -- newer kselftests are supposed to be able to run on older kernels, and we should just skip all of this if the API isn't there. > + > + /* Get writable masks for feature ID registers */ > + memset(range.reserved, 0, sizeof(range.reserved)); > + vm_ioctl(vcpu->vm, KVM_ARM_GET_REG_WRITABLE_MASKS, &range); _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel