From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id B0CC0C77B7F for ; Tue, 16 May 2023 08:21:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-ID:Date:References :In-Reply-To:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=tblTTm1++iMyvgXuqiCuCX9iuZLcHlNUQr+u+ttoMzo=; b=LF7tzOoThB1kch 0khaZLsL6WuhUxKtS2tbgs5XmaR1TcSkXEcpkRIBE9Y/6lrzbCjb98S25EYsSGM+MSE5X8L/cMyx/ +DVhSlXAfJ8p223DkZHkHwbkrF/4rvxyRcIPbVeqmd17godBHuM/59LhEFlJ0xhf1CUXqGkVWvNqx Oz/40HgzZEFsGmVEIjn9nCF9M3kJginrYqNNZDhd4sDISYzztyKERY+twdVqzJ0dKPVb+rzXpGim2 XxpBt73thGsLMRJrw6zSWIBRwbQm/cGBaq1c7gfm1eRHnHukDaBmCHcllEuWp2pDAVE+Wb2uoQG6C +77LBxMAxlsnpaNp44yA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1pypvF-004pKB-16; Tue, 16 May 2023 08:20:41 +0000 Received: from galois.linutronix.de ([2a0a:51c0:0:12e:550::1]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1pypvD-004pIW-0V for linux-arm-kernel@lists.infradead.org; Tue, 16 May 2023 08:20:40 +0000 From: Thomas Gleixner DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020; t=1684225237; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=M1sd/lpDf/MCX2vWDYwloKV/3NMa6WZqr15rTyJlP5A=; b=mFOaKqBLYl4XAgzjtWo/hPSwSsfmaxNfiHqaFr1drTXF1UQi/A3UhlMBm7TtENZSl4xX5P t/TTIAi9EwnP159o1Jdc6g5LW0Io8CxZ2ZyfhrhHtNRQ+KdnM7NwIyAWH55QgTYME0jpYf LEUl18wmWcLX3rlsHVZtoO1BVx/TPQpftpZaJMDBdhWXrZrGWI0Rlmjrdz6rUdEVF6C3s4 um1+F3rREcGQVAPOpvSeseRXkiavi+8SzXsJXdzMpdomaf7jW0rIuNCEqju9CbDtLdZsN3 FrISOOpntKDvD1OFg9CeAeE1Mqunuwb/jt+GLYet92hxSelhq7cqw/fOWZlh3Q== DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020e; t=1684225237; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=M1sd/lpDf/MCX2vWDYwloKV/3NMa6WZqr15rTyJlP5A=; b=9I6sZ984bu6NajzitsNs+FqPNKEaQ8a89V8kMrHCz/DIFKznAZqcWGDZjYlypHLUAwW8LW hYYEAqsaAUXHxaDg== To: "Russell King (Oracle)" Cc: Andrew Morton , linux-mm@kvack.org, Christoph Hellwig , Uladzislau Rezki , Lorenzo Stoakes , Peter Zijlstra , Baoquan He , John Ogness , linux-arm-kernel@lists.infradead.org, Mark Rutland , Marc Zyngier , x86@kernel.org Subject: Re: Excessive TLB flush ranges In-Reply-To: <87ilcs8zab.ffs@tglx> References: <87a5y5a6kj.ffs@tglx> <87353x9y3l.ffs@tglx> <87zg658fla.ffs@tglx> <87r0rg93z5.ffs@tglx> <87ilcs8zab.ffs@tglx> Date: Tue, 16 May 2023 10:20:37 +0200 Message-ID: <87fs7w8z6y.ffs@tglx> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230516_012039_337885_5645F11A X-CRM114-Status: GOOD ( 10.19 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, May 16 2023 at 10:18, Thomas Gleixner wrote: > On Tue, May 16 2023 at 08:37, Thomas Gleixner wrote: >> On Mon, May 15 2023 at 22:31, Russell King wrote: >>>> + list_for_each_entry(va, list, list) { >>>> + /* flush range by one by one 'invlpg' */ >>>> + for (addr = va->va_start; addr < va->va_end; addr += PAGE_SIZE) >>>> + flush_tlb_one_kernel(addr); >>> >>> Isn't this just the same as: >>> flush_tlb_kernel_range(va->va_start, va->va_end); >> >> Indeed. > > Actually not. At least not on x86 where it'd end up with 3 IPIs for that > case again, instead of having one which walks the list on each CPU. ARM32 has the same problem when tlb_ops_need_broadcast() is true. Thanks, tglx _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel