From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 63444C6379F for ; Tue, 21 Feb 2023 13:45:03 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-ID:Date:Subject:To :From:Reply-To:Cc:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References: List-Owner; bh=UJYz6azryMMOPQff1nVi/4j9+sQgdk4c9ip32B12gPo=; b=0F02Z1QySX9ciS ueLAth+lSovXGpFdztPdO/MyZg6o85BXZUoU8D8JJkDEYYjSis9hrbWh6rOcsqryfXecHtG6fcWJw nxjeNY+BxzeR7KO7XdFV501m95uA81BP821seQs2Shpi6VauxzVMG2TfHzEB7pn6M/K8E9tDdigTx B7+NBLCDzSi0FGaBF1JpIj85cRh+7iwWUd9rb94h87iyfBNjUhPesCYhhLyZyT9I0uyynxkcg33ff lT6SkqtTn8DwTZYoMEHlCdA6uvOwj5m2wirgoRzBToy3jFEcWj1CtzDhINUp7EoEl0HuDgvzWg0qY zR5nUmbICkspHSYWPV/g==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1pUSwD-008M8P-AB; Tue, 21 Feb 2023 13:44:09 +0000 Received: from mout.kundenserver.de ([212.227.126.133]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1pUSw6-008M7L-ON for linux-arm-kernel@lists.infradead.org; Tue, 21 Feb 2023 13:44:06 +0000 Received: from maxwell ([109.42.115.188]) by mrelayeu.kundenserver.de (mreue010 [213.165.67.97]) with ESMTPSA (Nemesis) id 1MLAAs-1pDLWN3diM-00IDz4; Tue, 21 Feb 2023 14:43:46 +0100 User-agent: mu4e 1.8.14; emacs 28.2 From: Jochen Henneberg To: Giuseppe Cavallaro ,Alexandre Torgue ,Jose Abreu ,"David S. Miller" ,Eric Dumazet ,Jakub Kicinski ,Paolo Abeni ,Maxime Coquelin ,netdev@vger.kernel.org,linux-stm32@st-md-mailman.stormreply.com,linux-arm-kernel@lists.infradead.org,linux-kernel@vger.kernel.org Subject: [PATCH net] net: stmmac: Premature loop termination check was ignored Date: Tue, 21 Feb 2023 14:38:27 +0100 Message-ID: <87fsaz6smr.fsf@henneberg-systemdesign.com> MIME-Version: 1.0 X-Provags-ID: V03:K1:UEjmjts8a3oTdsLqA0rvc+/8E/eBATSNya9dC/1ORtjI2CTbQIV 026feQLR23g4KIE8KNi+xOP9CLdOH2OCXKfaoWA6GH2HDSTi19nBIPyzmtVl2wMYrIjCvH3 isHWzjznLhletxDQAJCJ3eXjglO8hIlRuBFGx4NH3AuMwGPmeL/2W7tTxG5se50qeIZyDWM nhIs4cPTID5tfbZgbCH5A== UI-OutboundReport: notjunk:1;M01:P0:hfcDjeh03tY=;ECX8dzDbXfN9rfXK6kwd13XaVdA plcxuHQEJSbZRS2MoHMrIfI4W3X4fA9yud3XR3SLlfyy6fW+rU5MpWv29L728UboBd9Xtr/Me vj0x+ADiyYtjQHLjlbN4SpV1FX7f/hK3OI8FoQZUWbIjNvRTfG5hL/voyJOcUi+PKMbJline6 F2VvIIQkwHWoQV/2ujAy04NFcuwInsyUxJ8seNMfsAqRtZJyyzxRQyP13IT3i8v5xXMMY+nBP Gwae4vGb1hSSevQuzp0bFovEfqF264SNPHwEXJpXkq5cXUXU5wA1Fq3WDdvzq12r0SFjm69HD hjWHk1melr4CpoAeJiN71vPoWvUuP+5BwcPNrnKoWUk5o+AHYCcUiI51LVVeH1uxRZs1F6SJm TUKjnFHEM2jN7z7iyl1OfySdxix6seajn3XarwI/JBTpCiyAl/aHm7v07rRAJKyY7xVa3ksto pq13Bu5HeOntVL77H1wP6A0tipBtFiFiiWx6r0HByoM06sm5iQr/TXG7p5xTRsRQx1jXM9tMH Nn2qP6Jcujq7ySFDnRg8vyeLQOydkSxODJepkYlin4rFyqKvMBsKPEcncKv9M3CngvPXpZp2p WHaIH5CBHpsKOHd+2pMt+pCZepX+tDqg9jWStMfiFVchnC0oC9KVBlHVvIiLEOc8gaoK11HQ5 gTpdHRegceCg7RJGBHJgCHiwVD2gsUVjhagP9MoJKw== X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230221_054403_121414_89EB6705 X-CRM114-Status: GOOD ( 10.80 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org The premature loop termination check makes sense only in case of the jump to read_again where the count may have been updated. But read_again did not include the check. Signed-off-by: Jochen Henneberg --- drivers/net/ethernet/stmicro/stmmac/stmmac_main.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c b/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c index 1a5b8dab5e9b..de98c009866a 100644 --- a/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c +++ b/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c @@ -5031,10 +5031,10 @@ static int stmmac_rx_zc(struct stmmac_priv *priv, int limit, u32 queue) len = 0; } +read_again: if (count >= limit) break; -read_again: buf1_len = 0; entry = next_entry; buf = &rx_q->buf_pool[entry]; @@ -5221,10 +5221,10 @@ static int stmmac_rx(struct stmmac_priv *priv, int limit, u32 queue) len = 0; } +read_again: if (count >= limit) break; -read_again: buf1_len = 0; buf2_len = 0; entry = next_entry; -- 2.39.2 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel