From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.4 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 302B2C4338F for ; Wed, 11 Aug 2021 12:11:03 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id EB06260041 for ; Wed, 11 Aug 2021 12:11:02 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org EB06260041 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linutronix.de Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-ID:Date:References :In-Reply-To:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=y9Vi4tElN0mCuUyoU3+w1+Djr9Vwoa6/PADuQ1KW0JU=; b=K9b5GpmKIqQIRc 8tue8eGmHq9JwUxy7fpmiQLnx5bb3Os+bRbQI9tanxUf2li7Lo5ppSKreQJL7KpR3iqy1OzhXV1xv N+OUzOnRnKiYrSd/0cmED5vOzGECFuTj50CU0r66b+GuB1avY4t4egoL3xk38TGoAlBIrQihWHYTZ TOT7/Rv7vI1XZJ3sEkh4vXrmblRLMB4SScneRuXYN9wM5PUvLKXFwED4Cm2gtyy2EzOp8KGZCRvF8 QMsfovejoRgQ24xKPu54XBMklb1pUZpkdGs9c5N2XtE9f9vZRpqq8B3fzVjbCr1DxkAPIDAfgtTXz UTKag+i8CM+AM7Z9MJ5Q==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mDn2U-006ucd-PY; Wed, 11 Aug 2021 12:08:55 +0000 Received: from galois.linutronix.de ([2a0a:51c0:0:12e:550::1]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mDn2I-006uXJ-Io for linux-arm-kernel@lists.infradead.org; Wed, 11 Aug 2021 12:08:46 +0000 From: Thomas Gleixner DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020; t=1628683718; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=cCPYmftPfGiygaluib21F8+dmifVxGxWYVTKWjQffJE=; b=0MLwhpEjGT+kB+aY1hx2dkGme4FZ8aWIh4nQPVyMhWmCpTxlGDJ9oma/iDNXvZtZkofrib UIDbFXmIg73MeJjr1YObjHi5d5ZLYppBEkH9aO2hqz/vVQy3KIeAthzlZYWLykQ6Y/F/e3 lRIofXSBIYnKKeeZdjZXKMpQaR/ZXh35fX5c0h3DGh8E3HgSlUJg8YY/fdDQbT+0ngq9d1 ayxJTW2RDM4ptP2SMSlsCu00XBa6X33MUnINFhePNEavDY246s8rr1m10L+RT8tfIYxtm0 uEKpIQ1I3w+KJxgbpPsSxUF8pOOF1emFNhhjtJ+9pr+YWUtMxL5rEzTr1jO9yQ== DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020e; t=1628683718; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=cCPYmftPfGiygaluib21F8+dmifVxGxWYVTKWjQffJE=; b=ivSogjaZ4TJIiOeQj5iu4L3Rp8xGmuzTiApoq3dCjFocOi4UqCBZHaThKPBbQxbr1bOk3c nJ8ZqNTWiYP0hPBQ== To: Lee Jones Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Ming Lei , Hannes Reinecke Subject: Re: [PATCH 1/1] genirq/cpuhotplug: Bump debugging information print down to KERN_DEBUG In-Reply-To: References: <20210617073136.315723-1-lee.jones@linaro.org> <8735rhs7n6.ffs@tglx> Date: Wed, 11 Aug 2021 14:08:38 +0200 Message-ID: <87fsvgp4jd.ffs@tglx> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210811_050842_826226_59DE6378 X-CRM114-Status: GOOD ( 16.68 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, Aug 11 2021 at 08:57, Lee Jones wrote: > On Tue, 10 Aug 2021, Thomas Gleixner wrote: >> > @@ -42,7 +42,7 @@ static inline bool irq_needs_fixup(struct irq_data *d) >> > * If this happens then there was a missed IRQ fixup at some >> > * point. Warn about it and enforce fixup. >> > */ >> > - pr_warn("Eff. affinity %*pbl of IRQ %u contains only offline CPUs after offlining CPU %u\n", >> >> This one is clearly a warning as this should not happen. See the >> comments around that. >> >> > + pr_debug("Eff. affinity %*pbl of IRQ %u contains only offline CPUs after offlining CPU %u\n", >> > cpumask_pr_args(m), d->irq, cpu); >> > return true; >> > } >> > @@ -166,7 +166,7 @@ void irq_migrate_all_off_this_cpu(void) >> > raw_spin_unlock(&desc->lock); >> > >> > if (affinity_broken) { >> > - pr_warn_ratelimited("IRQ %u: no longer affine to CPU%u\n", >> > + pr_debug_ratelimited("IRQ %u: no longer affine to CPU%u\n", >> > irq, smp_processor_id()); >> >> Maybe, but distro people might have opinions on that. > > The trouble is, even if these are real warnings, they have an affect > on performance on real products. To the point where so much logging > builds up during pre-release testing, that it sets off the watchdog(s) > on some high profile consumer devices. I'm fine with making the second one debug, but the first one really should not trigger at all. Thanks, tglx _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel