From: Gregory CLEMENT <gregory.clement@bootlin.com>
To: Baruch Siach <baruch@tkos.co.il>
Cc: Russell King <linux@armlinux.org.uk>,
Andrew Lunn <andrew@lunn.ch>, Jason Cooper <jason@lakedaemon.net>,
linux-arm-kernel@lists.infradead.org,
Sebastian Hesselbarth <sebastian.hesselbarth@gmail.com>
Subject: Re: [PATCH] arm64: dts: clearfog-gt-8k: describe mini-PCIe CON2 USB
Date: Fri, 07 Dec 2018 17:28:22 +0100 [thread overview]
Message-ID: <87ftv9uwrd.fsf@bootlin.com> (raw)
In-Reply-To: <87ftvak2pq.fsf@tkos.co.il> (Baruch Siach's message of "Thu, 06 Dec 2018 19:02:57 +0200")
Hi Baruch,
On jeu., déc. 06 2018, Baruch Siach <baruch@tkos.co.il> wrote:
> Hi Gregory,
>
> Gregory CLEMENT writes:
>> On jeu., déc. 06 2018, Baruch Siach <baruch@tkos.co.il> wrote:
>>
>>> Enable the USB3 peripheral that is wired to CON2 on the Clearfog GT-8K
>>> board.
>>>
>>> Signed-off-by: Baruch Siach <baruch@tkos.co.il>
>>> ---
>>> arch/arm64/boot/dts/marvell/armada-8040-clearfog-gt-8k.dts | 4 ++++
>>> 1 file changed, 4 insertions(+)
>>>
>>> diff --git a/arch/arm64/boot/dts/marvell/armada-8040-clearfog-gt-8k.dts b/arch/arm64/boot/dts/marvell/armada-8040-clearfog-gt-8k.dts
>>> index dfb26661a88e..5b4a9609e31f 100644
>>> --- a/arch/arm64/boot/dts/marvell/armada-8040-clearfog-gt-8k.dts
>>> +++ b/arch/arm64/boot/dts/marvell/armada-8040-clearfog-gt-8k.dts
>>> @@ -282,6 +282,10 @@
>>> vqmmc-supply = <&v_3_3>;
>>> };
>>>
>>> +&cp0_usb3_1 {
>>
>> Don't you have any phy for this USB3 port?
>
> Not as far as I can see. Why would I need one? The serdes signals are
> connected directly to the mini-PCIe, just like the USB Type-A connector
> on the same board. I haven't tested the USB3 signals on the mini-PCIe,
> though, as I have no USB3 mini-PCIe device.
Right! I focused on the commit itself and missed the fact that it was
part of a PCI connector as stated in the title. I asked this because
usually we have a phy connected to a vcc signal.
Applied on mvebu/dt64
Thanks,
Gregory
>
> baruch
>
>>> + status = "okay";
>>> +};
>>> +
>>> &cp1_pinctrl {
>>> /*
>>> * MPP Bus:
>>> --
>>> 2.19.2
>>>
>
>
> --
> http://baruch.siach.name/blog/ ~. .~ Tk Open Systems
> =}------------------------------------------------ooO--U--Ooo------------{=
> - baruch@tkos.co.il - tel: +972.52.368.4656, http://www.tkos.co.il -
--
Gregory Clement, Bootlin
Embedded Linux and Kernel engineering
http://bootlin.com
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
prev parent reply other threads:[~2018-12-07 16:28 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-06 11:19 [PATCH] arm64: dts: clearfog-gt-8k: describe mini-PCIe CON2 USB Baruch Siach
2018-12-06 15:55 ` Gregory CLEMENT
2018-12-06 17:02 ` Baruch Siach
2018-12-07 16:28 ` Gregory CLEMENT [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87ftv9uwrd.fsf@bootlin.com \
--to=gregory.clement@bootlin.com \
--cc=andrew@lunn.ch \
--cc=baruch@tkos.co.il \
--cc=jason@lakedaemon.net \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux@armlinux.org.uk \
--cc=sebastian.hesselbarth@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).