linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
* [PATCH 0/2] Armada 388 GP minor fixes
@ 2015-12-21 14:41 Thomas Petazzoni
  2015-12-21 14:41 ` [PATCH 1/2] ARM: mvebu: adjust board name and compatible for Armada 388 GP Thomas Petazzoni
  2015-12-21 14:41 ` [PATCH 2/2] ARM: mvebu: use regulator-boot-on on " Thomas Petazzoni
  0 siblings, 2 replies; 7+ messages in thread
From: Thomas Petazzoni @ 2015-12-21 14:41 UTC (permalink / raw)
  To: linux-arm-kernel

Hello,

Here are two minor fixes/improvements to the support of the Armada 388
GP platform.

The first patch was already sent in June and July this year, but was
left on the side because it was part of a larger patch series about
suspend/resume on Armada 38x, which has not been fully merged
yet. However, this patch is completely independent from
suspend/resume, so it can be merged.

Thanks,

Thomas

Thomas Petazzoni (2):
  ARM: mvebu: adjust board name and compatible for Armada 388 GP
  ARM: mvebu: use regulator-boot-on on Armada 388 GP

 arch/arm/boot/dts/armada-388-gp.dts | 28 ++++++++++------------------
 1 file changed, 10 insertions(+), 18 deletions(-)

-- 
2.6.4

^ permalink raw reply	[flat|nested] 7+ messages in thread
* [PATCH 1/2] ARM: mvebu: adjust board name and compatible for Armada 388 GP
  2015-12-21 14:41 [PATCH 0/2] Armada 388 GP minor fixes Thomas Petazzoni
@ 2015-12-21 14:41 ` Thomas Petazzoni
  2015-12-21 16:52   ` Gregory CLEMENT
  2015-12-21 14:41 ` [PATCH 2/2] ARM: mvebu: use regulator-boot-on on " Thomas Petazzoni
  1 sibling, 1 reply; 7+ messages in thread
From: Thomas Petazzoni @ 2015-12-21 14:41 UTC (permalink / raw)
  To: linux-arm-kernel

As the name of the Device Tree file name suggests, the Armada 388 GP
really contains an Armada 388 SoC, so this commit updates the board
name and compatible string in the Device Tree file.

Signed-off-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
---
 arch/arm/boot/dts/armada-388-gp.dts | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/arch/arm/boot/dts/armada-388-gp.dts b/arch/arm/boot/dts/armada-388-gp.dts
index a633be3..d8dab0f 100644
--- a/arch/arm/boot/dts/armada-388-gp.dts
+++ b/arch/arm/boot/dts/armada-388-gp.dts
@@ -44,8 +44,8 @@
 #include <dt-bindings/gpio/gpio.h>
 
 / {
-	model = "Marvell Armada 385 GP";
-	compatible = "marvell,a385-gp", "marvell,armada388", "marvell,armada380";
+	model = "Marvell Armada 388 DB-88F6820-GP";
+	compatible = "marvell,a388-gp", "marvell,armada388", "marvell,armada380";
 
 	chosen {
 		stdout-path = "serial0:115200n8";
-- 
2.6.4

^ permalink raw reply related	[flat|nested] 7+ messages in thread
* [PATCH 2/2] ARM: mvebu: use regulator-boot-on on Armada 388 GP
  2015-12-21 14:41 [PATCH 0/2] Armada 388 GP minor fixes Thomas Petazzoni
  2015-12-21 14:41 ` [PATCH 1/2] ARM: mvebu: adjust board name and compatible for Armada 388 GP Thomas Petazzoni
@ 2015-12-21 14:41 ` Thomas Petazzoni
  2015-12-22 12:23   ` Gregory CLEMENT
  1 sibling, 1 reply; 7+ messages in thread
From: Thomas Petazzoni @ 2015-12-21 14:41 UTC (permalink / raw)
  To: linux-arm-kernel

Really, what we meant by regulator-always-on is that the regulators
are already turned on by the bootloader, for which regulator-boot-on
is a better description.

A net advantage of using regulator-boot-on is that the regulator is
not touched at boot time by the kernel, which avoids having the hard
drives spinning down and then up again, taking several (~5) seconds of
additional boot time.

In addition, there is no need to have such properties on the child
regulators used for SATA. Having it on the parent regulator that
really controls the GPIO is sufficient.

Signed-off-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
---
 arch/arm/boot/dts/armada-388-gp.dts | 24 ++++++++----------------
 1 file changed, 8 insertions(+), 16 deletions(-)

diff --git a/arch/arm/boot/dts/armada-388-gp.dts b/arch/arm/boot/dts/armada-388-gp.dts
index d8dab0f..1ef6cc6 100644
--- a/arch/arm/boot/dts/armada-388-gp.dts
+++ b/arch/arm/boot/dts/armada-388-gp.dts
@@ -279,7 +279,7 @@
 		regulator-min-microvolt = <5000000>;
 		regulator-max-microvolt = <5000000>;
 		enable-active-high;
-		regulator-always-on;
+		regulator-boot-on;
 		gpio = <&expander1 15 GPIO_ACTIVE_HIGH>;
 	};
 
@@ -289,7 +289,7 @@
 		regulator-min-microvolt = <5000000>;
 		regulator-max-microvolt = <5000000>;
 		enable-active-high;
-		regulator-always-on;
+		regulator-boot-on;
 		gpio = <&expander1 14 GPIO_ACTIVE_HIGH>;
 	};
 
@@ -299,7 +299,7 @@
 		regulator-min-microvolt = <5000000>;
 		regulator-max-microvolt = <5000000>;
 		enable-active-high;
-		regulator-always-on;
+		regulator-boot-on;
 		gpio = <&expander0 4 GPIO_ACTIVE_HIGH>;
 	};
 
@@ -309,7 +309,7 @@
 		regulator-min-microvolt = <5000000>;
 		regulator-max-microvolt = <5000000>;
 		enable-active-high;
-		regulator-always-on;
+		regulator-boot-on;
 		gpio = <&expander0 4 GPIO_ACTIVE_HIGH>;
 	};
 
@@ -319,7 +319,7 @@
 		regulator-min-microvolt = <12000000>;
 		regulator-max-microvolt = <12000000>;
 		enable-active-high;
-		regulator-always-on;
+		regulator-boot-on;
 		gpio = <&expander0 2 GPIO_ACTIVE_HIGH>;
 	};
 
@@ -328,7 +328,6 @@
 		regulator-name = "v5.0-sata0";
 		regulator-min-microvolt = <5000000>;
 		regulator-max-microvolt = <5000000>;
-		regulator-always-on;
 		vin-supply = <&reg_sata0>;
 	};
 
@@ -337,7 +336,6 @@
 		regulator-name = "v12.0-sata0";
 		regulator-min-microvolt = <12000000>;
 		regulator-max-microvolt = <12000000>;
-		regulator-always-on;
 		vin-supply = <&reg_sata0>;
 	};
 
@@ -347,7 +345,7 @@
 		regulator-min-microvolt = <12000000>;
 		regulator-max-microvolt = <12000000>;
 		enable-active-high;
-		regulator-always-on;
+		regulator-boot-on;
 		gpio = <&expander0 3 GPIO_ACTIVE_HIGH>;
 	};
 
@@ -356,7 +354,6 @@
 		regulator-name = "v5.0-sata1";
 		regulator-min-microvolt = <5000000>;
 		regulator-max-microvolt = <5000000>;
-		regulator-always-on;
 		vin-supply = <&reg_sata1>;
 	};
 
@@ -365,7 +362,6 @@
 		regulator-name = "v12.0-sata1";
 		regulator-min-microvolt = <12000000>;
 		regulator-max-microvolt = <12000000>;
-		regulator-always-on;
 		vin-supply = <&reg_sata1>;
 	};
 
@@ -373,7 +369,7 @@
 		compatible = "regulator-fixed";
 		regulator-name = "pwr_en_sata2";
 		enable-active-high;
-		regulator-always-on;
+		regulator-boot-on;
 		gpio = <&expander0 11 GPIO_ACTIVE_HIGH>;
 	};
 
@@ -382,7 +378,6 @@
 		regulator-name = "v5.0-sata2";
 		regulator-min-microvolt = <5000000>;
 		regulator-max-microvolt = <5000000>;
-		regulator-always-on;
 		vin-supply = <&reg_sata2>;
 	};
 
@@ -391,7 +386,6 @@
 		regulator-name = "v12.0-sata2";
 		regulator-min-microvolt = <12000000>;
 		regulator-max-microvolt = <12000000>;
-		regulator-always-on;
 		vin-supply = <&reg_sata2>;
 	};
 
@@ -399,7 +393,7 @@
 		compatible = "regulator-fixed";
 		regulator-name = "pwr_en_sata3";
 		enable-active-high;
-		regulator-always-on;
+		regulator-boot-on;
 		gpio = <&expander0 12 GPIO_ACTIVE_HIGH>;
 	};
 
@@ -408,7 +402,6 @@
 		regulator-name = "v5.0-sata3";
 		regulator-min-microvolt = <5000000>;
 		regulator-max-microvolt = <5000000>;
-		regulator-always-on;
 		vin-supply = <&reg_sata3>;
 	};
 
@@ -417,7 +410,6 @@
 		regulator-name = "v12.0-sata3";
 		regulator-min-microvolt = <12000000>;
 		regulator-max-microvolt = <12000000>;
-		regulator-always-on;
 		vin-supply = <&reg_sata3>;
 	};
 };
-- 
2.6.4

^ permalink raw reply related	[flat|nested] 7+ messages in thread
* [PATCH 1/2] ARM: mvebu: adjust board name and compatible for Armada 388 GP
  2015-12-21 14:41 ` [PATCH 1/2] ARM: mvebu: adjust board name and compatible for Armada 388 GP Thomas Petazzoni
@ 2015-12-21 16:52   ` Gregory CLEMENT
  2016-01-11 16:24     ` Gregory CLEMENT
  0 siblings, 1 reply; 7+ messages in thread
From: Gregory CLEMENT @ 2015-12-21 16:52 UTC (permalink / raw)
  To: linux-arm-kernel

Hi Thomas,
 
 On lun., d?c. 21 2015, Thomas Petazzoni <thomas.petazzoni@free-electrons.com> wrote:

> As the name of the Device Tree file name suggests, the Armada 388 GP
> really contains an Armada 388 SoC, so this commit updates the board
> name and compatible string in the Device Tree file.
>
> Signed-off-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>

Applied on mvebu/dt

Thanks,

Gregory
> ---
>  arch/arm/boot/dts/armada-388-gp.dts | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/arch/arm/boot/dts/armada-388-gp.dts b/arch/arm/boot/dts/armada-388-gp.dts
> index a633be3..d8dab0f 100644
> --- a/arch/arm/boot/dts/armada-388-gp.dts
> +++ b/arch/arm/boot/dts/armada-388-gp.dts
> @@ -44,8 +44,8 @@
>  #include <dt-bindings/gpio/gpio.h>
>  
>  / {
> -	model = "Marvell Armada 385 GP";
> -	compatible = "marvell,a385-gp", "marvell,armada388", "marvell,armada380";
> +	model = "Marvell Armada 388 DB-88F6820-GP";
> +	compatible = "marvell,a388-gp", "marvell,armada388", "marvell,armada380";
>  
>  	chosen {
>  		stdout-path = "serial0:115200n8";
> -- 
> 2.6.4
>

-- 
Gregory Clement, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com

^ permalink raw reply	[flat|nested] 7+ messages in thread
* [PATCH 2/2] ARM: mvebu: use regulator-boot-on on Armada 388 GP
  2015-12-21 14:41 ` [PATCH 2/2] ARM: mvebu: use regulator-boot-on on " Thomas Petazzoni
@ 2015-12-22 12:23   ` Gregory CLEMENT
  2015-12-22 14:04     ` Gregory CLEMENT
  0 siblings, 1 reply; 7+ messages in thread
From: Gregory CLEMENT @ 2015-12-22 12:23 UTC (permalink / raw)
  To: linux-arm-kernel

Hi Thomas,
 
 On lun., d?c. 21 2015, Thomas Petazzoni <thomas.petazzoni@free-electrons.com> wrote:

> Really, what we meant by regulator-always-on is that the regulators
> are already turned on by the bootloader, for which regulator-boot-on
> is a better description.
>

What happened if the bootloader do not turn the regulator on?
I fear that in this case the regulator won't be turned on at all.

> A net advantage of using regulator-boot-on is that the regulator is
> not touched at boot time by the kernel, which avoids having the hard
> drives spinning down and then up again, taking several (~5) seconds of
> additional boot time.
>
> In addition, there is no need to have such properties on the child
> regulators used for SATA. Having it on the parent regulator that
> really controls the GPIO is sufficient.
>
> Signed-off-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
> ---
>  arch/arm/boot/dts/armada-388-gp.dts | 24 ++++++++----------------
>  1 file changed, 8 insertions(+), 16 deletions(-)
>
> diff --git a/arch/arm/boot/dts/armada-388-gp.dts b/arch/arm/boot/dts/armada-388-gp.dts
> index d8dab0f..1ef6cc6 100644

>  
> @@ -309,7 +309,7 @@
>  		regulator-min-microvolt = <5000000>;
>  		regulator-max-microvolt = <5000000>;
>  		enable-active-high;
> -		regulator-always-on;
> +		regulator-boot-on;
>  		gpio = <&expander0 4 GPIO_ACTIVE_HIGH>;
>  	};
This node had been removed by a patch you sent few days ago:
"ARM: mvebu: remove duplicated regulator definition in Armada 388 GP"

Thanks,

Gregory

-- 
Gregory Clement, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com

^ permalink raw reply	[flat|nested] 7+ messages in thread
* [PATCH 2/2] ARM: mvebu: use regulator-boot-on on Armada 388 GP
  2015-12-22 12:23   ` Gregory CLEMENT
@ 2015-12-22 14:04     ` Gregory CLEMENT
  0 siblings, 0 replies; 7+ messages in thread
From: Gregory CLEMENT @ 2015-12-22 14:04 UTC (permalink / raw)
  To: linux-arm-kernel

Hi Thomas,
 
 On mar., d?c. 22 2015, Gregory CLEMENT <gregory.clement@free-electrons.com> wrote:

> Hi Thomas,
>  
>  On lun., d?c. 21 2015, Thomas Petazzoni <thomas.petazzoni@free-electrons.com> wrote:
>
>> Really, what we meant by regulator-always-on is that the regulators
>> are already turned on by the bootloader, for which regulator-boot-on
>> is a better description.
>>
>
> What happened if the bootloader do not turn the regulator on?
> I fear that in this case the regulator won't be turned on at all.
>
>> A net advantage of using regulator-boot-on is that the regulator is
>> not touched at boot time by the kernel, which avoids having the hard
>> drives spinning down and then up again, taking several (~5) seconds of
>> additional boot time.

I tested your patch, I didn't see so much time lost in boot time: with
one hdd the difference was only about 0.3s. But with a second hdd it was
around 1.9 (so 1.6s more for the second hhd). It looks like it really
depends on the hdd. However, the most annoying point with the
regulator-always-on for the SATA it turns the power down and up for the
hdd during boot which is not very nice for the hdd. So, at least for
this, it is useful.

For the USB part the regulators are completely disabled:
usb3-vbus: disabling
v5.0-vbus0: disabling
v5.0-vbus1: disabling

And indeed the USB does not work with your patch applied.

Could you send a new version with the changes only done for the SATA
regulator nodes?

Thanks,

Gregory

>>
>> In addition, there is no need to have such properties on the child
>> regulators used for SATA. Having it on the parent regulator that
>> really controls the GPIO is sufficient.
>>
>> Signed-off-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
>> ---
>>  arch/arm/boot/dts/armada-388-gp.dts | 24 ++++++++----------------
>>  1 file changed, 8 insertions(+), 16 deletions(-)
>>
>> diff --git a/arch/arm/boot/dts/armada-388-gp.dts b/arch/arm/boot/dts/armada-388-gp.dts
>> index d8dab0f..1ef6cc6 100644
>
>>  
>> @@ -309,7 +309,7 @@
>>  		regulator-min-microvolt = <5000000>;
>>  		regulator-max-microvolt = <5000000>;
>>  		enable-active-high;
>> -		regulator-always-on;
>> +		regulator-boot-on;
>>  		gpio = <&expander0 4 GPIO_ACTIVE_HIGH>;
>>  	};
> This node had been removed by a patch you sent few days ago:
> "ARM: mvebu: remove duplicated regulator definition in Armada 388 GP"
>
> Thanks,
>
> Gregory
>
> -- 
> Gregory Clement, Free Electrons
> Kernel, drivers, real-time and embedded Linux
> development, consulting, training and support.
> http://free-electrons.com
>
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel at lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

-- 
Gregory Clement, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com

^ permalink raw reply	[flat|nested] 7+ messages in thread
* [PATCH 1/2] ARM: mvebu: adjust board name and compatible for Armada 388 GP
  2015-12-21 16:52   ` Gregory CLEMENT
@ 2016-01-11 16:24     ` Gregory CLEMENT
  0 siblings, 0 replies; 7+ messages in thread
From: Gregory CLEMENT @ 2016-01-11 16:24 UTC (permalink / raw)
  To: linux-arm-kernel

Hi,
 
 On lun., d?c. 21 2015, Gregory CLEMENT <gregory.clement@free-electrons.com> wrote:

> Hi Thomas,
>  
>  On lun., d?c. 21 2015, Thomas Petazzoni <thomas.petazzoni@free-electrons.com> wrote:
>
>> As the name of the Device Tree file name suggests, the Armada 388 GP
>> really contains an Armada 388 SoC, so this commit updates the board
>> name and compatible string in the Device Tree file.
>>
>> Signed-off-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
>
> Applied on mvebu/dt

I didn't managed to do a pull request before the holidays period so I
moved this commit to mvebu/dt-for-4.6

Gregory

>
> Thanks,
>
> Gregory
>> ---
>>  arch/arm/boot/dts/armada-388-gp.dts | 4 ++--
>>  1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/arch/arm/boot/dts/armada-388-gp.dts b/arch/arm/boot/dts/armada-388-gp.dts
>> index a633be3..d8dab0f 100644
>> --- a/arch/arm/boot/dts/armada-388-gp.dts
>> +++ b/arch/arm/boot/dts/armada-388-gp.dts
>> @@ -44,8 +44,8 @@
>>  #include <dt-bindings/gpio/gpio.h>
>>  
>>  / {
>> -	model = "Marvell Armada 385 GP";
>> -	compatible = "marvell,a385-gp", "marvell,armada388", "marvell,armada380";
>> +	model = "Marvell Armada 388 DB-88F6820-GP";
>> +	compatible = "marvell,a388-gp", "marvell,armada388", "marvell,armada380";
>>  
>>  	chosen {
>>  		stdout-path = "serial0:115200n8";
>> -- 
>> 2.6.4
>>
>
> -- 
> Gregory Clement, Free Electrons
> Kernel, drivers, real-time and embedded Linux
> development, consulting, training and support.
> http://free-electrons.com
>
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel at lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

-- 
Gregory Clement, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com

^ permalink raw reply	[flat|nested] 7+ messages in thread
end of thread, other threads:[~2016-01-11 16:24 UTC | newest]

Thread overview: 7+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-12-21 14:41 [PATCH 0/2] Armada 388 GP minor fixes Thomas Petazzoni
2015-12-21 14:41 ` [PATCH 1/2] ARM: mvebu: adjust board name and compatible for Armada 388 GP Thomas Petazzoni
2015-12-21 16:52   ` Gregory CLEMENT
2016-01-11 16:24     ` Gregory CLEMENT
2015-12-21 14:41 ` [PATCH 2/2] ARM: mvebu: use regulator-boot-on on " Thomas Petazzoni
2015-12-22 12:23   ` Gregory CLEMENT
2015-12-22 14:04     ` Gregory CLEMENT

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).