From: robert.jarzmik@free.fr (Robert Jarzmik)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2] RTC: PXA: Fix regression of interrupt before ioremap
Date: Thu, 29 Jan 2015 20:42:12 +0100 [thread overview]
Message-ID: <87fvatnzl7.fsf@free.fr> (raw)
In-Reply-To: <54CA1ECA.8050000@tul.cz> (Petr Cvek's message of "Thu, 29 Jan 2015 12:51:38 +0100")
Petr Cvek <petr.cvek@tul.cz> writes:
> Interrupts appear before register set of the PXA2xx RTC controller is ioremaped.
>
> This fixes regression from:
> 'commit a44802f8fb7e593adabc6ef53c8df45a1717fa9b ("drivers/rtc/rtc-pxa.c: fix alarm can't wake up system issue")'
> 'commit 2f6e5f9458646263d3d9ffadd5e11e3d8d15a7d0 ("drivers/rtc: remove IRQF_DISABLED")'
>
> Signed-off-by: Petr Cvek <petr.cvek@tul.cz>
No sorry, I don't like this.
It's not your patch I don't like, it fixes a real problem, but what happens then
if :
- kernel boots
- a process opens /dev/rtc0
The real issue is with patch a44802f "drivers/rtc/rtc-pxa.c: fix alarm can't
wake up system issue". I'd rather have you revert a44802f, which makes no sense
to me ...
Leo if you want to comment on it, feel free, and tell me if you tried your patch
with the code in Documentation/rtc.txt ?
Cheers.
--
Robert
next prev parent reply other threads:[~2015-01-29 19:42 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-29 11:51 [PATCH v2] RTC: PXA: Fix regression of interrupt before ioremap Petr Cvek
2015-01-29 19:42 ` Robert Jarzmik [this message]
2015-02-02 15:00 ` [PATCH v2, RFC] " Petr Cvek
2015-02-02 18:33 ` Robert Jarzmik
2015-02-03 13:42 ` Petr Cvek
2015-02-03 18:31 ` Robert Jarzmik
2015-02-05 20:36 ` Petr Cvek
2015-02-07 13:13 ` Robert Jarzmik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87fvatnzl7.fsf@free.fr \
--to=robert.jarzmik@free.fr \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).