linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: arnaud.patard@rtp-net.org (Arnaud Patard (Rtp))
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 15/16] ARM: Kirkwood: Describe iConnect LEDs in DT.
Date: Tue, 31 Jul 2012 10:59:14 +0200	[thread overview]
Message-ID: <87fw885msd.fsf@lebrac.rtp-net.org> (raw)
In-Reply-To: <20120731072012.GR18016@lunn.ch> (Andrew Lunn's message of "Tue, 31 Jul 2012 09:20:12 +0200")

Andrew Lunn <andrew@lunn.ch> writes:

> On Tue, Jul 31, 2012 at 09:08:53AM +0200, Arnaud Patard wrote:
>> Andrew Lunn <andrew@lunn.ch> writes:
>> 
>> > On Mon, Jul 30, 2012 at 10:35:34PM +0100, Adam Baker wrote:
>> >> On 20/07/12 18:35, Andrew Lunn wrote:
>> >> 
>> >> Sorry it's taken a while to spot this but I've got one comment below
>> >> 
>> >> >Signed-off-by: Andrew Lunn <andrew@lunn.ch>
>> >> >---
>> >> >  arch/arm/boot/dts/kirkwood-iconnect.dts |   34 +++++++++++++++++++++++
>> >> >  arch/arm/mach-kirkwood/board-iconnect.c |   46 -------------------------------
>> >> >  2 files changed, 34 insertions(+), 46 deletions(-)
>> >> >
>> >> >diff --git a/arch/arm/boot/dts/kirkwood-iconnect.dts b/arch/arm/boot/dts/kirkwood-iconnect.dts
>> >> >index a7dd07b..b77b38f 100644
>> >> >--- a/arch/arm/boot/dts/kirkwood-iconnect.dts
>> >> >+++ b/arch/arm/boot/dts/kirkwood-iconnect.dts
>> >> >@@ -31,4 +31,38 @@
>> >> >  			status = "ok";
>> >> >  		};
>> >> >  	};
>> >> >+	gpio-leds {
>> >> >+		compatible = "gpio-leds";
>> >> >+
>> >> >+		led-level {
>> >> >+			label = "led_level";
>> >> >+			gpios = <&gpio1 9 0>;
>> >> >+			linux,default-trigger = "default-on";
>> >> >+		};
>> >> >+		power-blue {
>> >> >+			label = "power:blue";
>> >> >+			gpios = <&gpio1 11 0>;
>> >> >+			linux,default-trigger = "timer";
>> >> >+		};
>> >> 
>> >> Is there any reason that power:red is missing here?
>> >
>> > The monkey driving the keyboard is not reliable at monkey work...
>> >
>> > Please create a patch and i will try to get it into rc1.
>> 
>> There's already a patch for that in your mailbox ("ARM: Kirkwood: Fix
>> iconnect leds"). I guess you're not yet fully awake :)
>
> Hi Arnaud
>
> Still need my second coffee of the day.
>
> Those patches never went to the list, as far as i remember. Please can
> you post the two fixes and the two development patches, as seperate
> patchsets.

Will do.

Thanks,
Arnaud

  reply	other threads:[~2012-07-31  8:59 UTC|newest]

Thread overview: 42+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-07-20 17:35 [PATCH 00/16] Orion DT conversions and fixes Andrew Lunn
2012-07-20 17:35 ` [PATCH 1/16] ARM: Orion: DT support for IRQ and GPIO Controllers Andrew Lunn
2012-07-20 17:35 ` [PATCH 2/16] SPI: Refactor spi-orion to use SPI framework queue Andrew Lunn
2012-07-22  7:22   ` Linus Walleij
2012-07-22  9:53     ` Andrew Lunn
2012-07-22 19:07       ` Mark Brown
2012-07-22 19:32         ` Andrew Lunn
2012-07-22 22:42           ` Mark Brown
2012-07-23  7:27             ` Andrew Lunn
2012-07-23  9:37               ` Mark Brown
2012-07-23 10:08                 ` [PATCH] spi-orion: add device tree binding Andrew Lunn
2012-07-23 10:43                   ` Mark Brown
2012-07-23 10:59                     ` Andrew Lunn
2012-07-23 11:12                       ` Mark Brown
2012-07-23 17:43                         ` Arnd Bergmann
2012-07-23 10:44                   ` Mark Brown
2012-07-23 10:50                     ` Andrew Lunn
2012-07-23 10:16                 ` [PATCH 2/16] SPI: Refactor spi-orion to use SPI framework queue Andrew Lunn
2012-07-23 10:23                   ` Mark Brown
2012-07-23 10:49                     ` Andrew Lunn
2012-07-23 11:11                       ` Mark Brown
2012-07-23 10:53           ` Sergei Shtylyov
2012-07-23 11:02             ` Andrew Lunn
2012-07-20 17:35 ` [PATCH 3/16] ARM: Kirkwood: Ensure runit clock always ticks Andrew Lunn
2012-07-20 17:35 ` [PATCH 4/16] ARM: Orion: Add arch support needed for I2C via DT Andrew Lunn
2012-07-20 17:35 ` [PATCH 5/16] Kirkwood: Add basic device tree support for QNAP TS219 Andrew Lunn
2012-07-20 17:35 ` [PATCH 6/16] ARM: Orion: DTify the watchdog timer Andrew Lunn
2012-07-20 17:35 ` [PATCH 7/16] ATA: sata_mv: Add device tree support Andrew Lunn
2012-07-20 17:35 ` [PATCH 8/16] ARM: Kirkwood: Use DT to configure SATA device Andrew Lunn
2012-07-20 17:35 ` [PATCH 9/16] ARM: Kirkwood: Describe DNS325 temperature sensor in DT Andrew Lunn
2012-07-20 17:35 ` [PATCH 10/16] ARM: Kirkwood: Describe IB62x0 gpio-keys " Andrew Lunn
2012-07-20 17:35 ` [PATCH 11/16] ARM: Kirkwood: Describe iConnects temperature sensor " Andrew Lunn
2012-07-20 17:35 ` [PATCH 12/16] ARM: Kirkwood: Describe Dreamplug LEDs " Andrew Lunn
2012-07-20 17:35 ` [PATCH 13/16] ARM: Kirkwood: Describe GoFlex Net LEDs and SATA " Andrew Lunn
2012-07-20 17:35 ` [PATCH 14/16] ARM: Kirkwood: Describe ib62x0 LEDs " Andrew Lunn
2012-07-20 17:35 ` [PATCH 15/16] ARM: Kirkwood: Describe iConnect " Andrew Lunn
2012-07-30 21:35   ` Adam Baker
2012-07-31  6:36     ` Andrew Lunn
2012-07-31  7:08       ` Arnaud Patard (Rtp)
2012-07-31  7:20         ` Andrew Lunn
2012-07-31  8:59           ` Arnaud Patard (Rtp) [this message]
2012-07-20 17:35 ` [PATCH 16/16] ARM: Kirkwood: Replace mrvl with marvell Andrew Lunn

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87fw885msd.fsf@lebrac.rtp-net.org \
    --to=arnaud.patard@rtp-net.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).