* [PATCH] OMAP4: PM: Avoid omap4_pm_init() on OMAP4430 ES1.0
@ 2011-03-11 11:56 Santosh Shilimkar
2011-03-24 15:27 ` Kevin Hilman
0 siblings, 1 reply; 2+ messages in thread
From: Santosh Shilimkar @ 2011-03-11 11:56 UTC (permalink / raw)
To: linux-arm-kernel
On OMAP4430 ES1.0, Power Management features are not supported.
Avoid omap4_pm_init() on ES1.0 silicon so that we can continue
to use same kernel binary to boot on all OMAP4 silicons.
The ES1.0 boot failure with OMAP4 PM series was because of
the clockdomain initialisation code. Hardware supervised
clockdomain mode isn't functional for all clockdomains
on OMAP4430 ES1.0 silicon so avoid the same.
Signed-off-by: Santosh Shilimkar <santosh.shilimkar@ti.com>
Reported-by: Kevin Hilman <khilman@ti.com>
Cc: Kevin Hilman <khilman@ti.com>
---
Patch applies on top of OMAP4 PM series
arch/arm/mach-omap2/pm44xx.c | 5 +++++
1 files changed, 5 insertions(+), 0 deletions(-)
diff --git a/arch/arm/mach-omap2/pm44xx.c b/arch/arm/mach-omap2/pm44xx.c
index e887a5d..2e18c1d 100644
--- a/arch/arm/mach-omap2/pm44xx.c
+++ b/arch/arm/mach-omap2/pm44xx.c
@@ -203,6 +203,11 @@ static int __init omap4_pm_init(void)
if (!cpu_is_omap44xx())
return -ENODEV;
+ if (omap_rev() == OMAP4430_REV_ES1_0) {
+ WARN(1, "Power Management not supported on OMAP4430 ES1.0\n");
+ return -ENODEV;
+ }
+
pr_err("Power Management for TI OMAP4.\n");
#ifdef CONFIG_PM
--
1.6.0.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
* [PATCH] OMAP4: PM: Avoid omap4_pm_init() on OMAP4430 ES1.0
2011-03-11 11:56 [PATCH] OMAP4: PM: Avoid omap4_pm_init() on OMAP4430 ES1.0 Santosh Shilimkar
@ 2011-03-24 15:27 ` Kevin Hilman
0 siblings, 0 replies; 2+ messages in thread
From: Kevin Hilman @ 2011-03-24 15:27 UTC (permalink / raw)
To: linux-arm-kernel
Hi Santosh,
Santosh Shilimkar <santosh.shilimkar@ti.com> writes:
> On OMAP4430 ES1.0, Power Management features are not supported.
> Avoid omap4_pm_init() on ES1.0 silicon so that we can continue
> to use same kernel binary to boot on all OMAP4 silicons.
>
> The ES1.0 boot failure with OMAP4 PM series was because of
> the clockdomain initialisation code. Hardware supervised
> clockdomain mode isn't functional for all clockdomains
> on OMAP4430 ES1.0 silicon so avoid the same.
>
> Signed-off-by: Santosh Shilimkar <santosh.shilimkar@ti.com>
> Reported-by: Kevin Hilman <khilman@ti.com>
> Cc: Kevin Hilman <khilman@ti.com>
> ---
> Patch applies on top of OMAP4 PM series
This looks OK.
Please include in the repost of your OMAP4 PM series.
Kevin
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2011-03-24 15:27 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-03-11 11:56 [PATCH] OMAP4: PM: Avoid omap4_pm_init() on OMAP4430 ES1.0 Santosh Shilimkar
2011-03-24 15:27 ` Kevin Hilman
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).