From: khilman@deeprootsystems.com (Kevin Hilman)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v7 4/6] OMAP4: hwmod data: Add watchdog timer
Date: Fri, 24 Sep 2010 12:07:19 -0700 [thread overview]
Message-ID: <87fwwzarko.fsf@deeprootsystems.com> (raw)
In-Reply-To: <4C992FEF.60106@ti.com> (Benoit Cousson's message of "Wed, 22 Sep 2010 00:21:35 +0200")
"Cousson, Benoit" <b-cousson@ti.com> writes:
> On 9/21/2010 3:37 PM, Varadarajan, Charulatha wrote:
[...]
>> static __initdata struct omap_hwmod *omap44xx_hwmods[] = {
>> /* dmm class */
>> &omap44xx_dmm_hwmod,
>> @@ -472,6 +602,11 @@ static __initdata struct omap_hwmod *omap44xx_hwmods[] = {
>>
>> /* mpu class */
>> &omap44xx_mpu_hwmod,
>> + /* wd_timer class */
>> + &omap44xx_wd_timer2_hwmod,
>> +
>> + /* wd_timer3 not yet supported */
>> +/* &omap44xx_wd_timer3_hwmod, */
>
> Sorry, I forgot to comment that part in your previous revision.
> What we agreed with Kevin is to enable that hwmod watchdog as well in
> order to allow the hwmod core to initialize properly this module, even
> if it not used by any driver yet.
>
> Beside that you can add my Acked-by: for the whole series.
Charu,
If this is OK with you, can you test with timer3 hwmod enabled, and
repost an updated version of this patch?
Then, I will add Benoit's ack and queue this up for 2.6.37.
Kevin
next prev parent reply other threads:[~2010-09-24 19:07 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-09-21 13:37 [PATCH v7 0/6] OMAP: WDT: Implement WDT in hwmod way Varadarajan, Charulatha
2010-09-21 13:37 ` [PATCH v7 1/6] OMAP3: hwmod data: Add watchdog timer Varadarajan, Charulatha
2010-09-21 13:37 ` [PATCH v7 2/6] OMAP2420: " Varadarajan, Charulatha
2010-09-21 13:37 ` [PATCH v7 3/6] OMAP2430: " Varadarajan, Charulatha
2010-09-21 13:37 ` [PATCH v7 4/6] OMAP4: " Varadarajan, Charulatha
2010-09-21 22:21 ` Cousson, Benoit
2010-09-24 19:07 ` Kevin Hilman [this message]
2010-09-25 12:04 ` Varadarajan, Charulatha
2010-09-21 13:37 ` [PATCH v7 5/6] OMAP: WDT: Split OMAP1 and OMAP2PLUS device registration Varadarajan, Charulatha
2010-09-21 13:37 ` [PATCH v7 6/6] OMAP: WDT: Use PM runtime APIs instead of clk FW APIs Varadarajan, Charulatha
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87fwwzarko.fsf@deeprootsystems.com \
--to=khilman@deeprootsystems.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).