From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id F1A75C44500 for ; Thu, 2 Jul 2026 22:08:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Type:MIME-Version: References:In-Reply-To:Subject:Cc:To:From:Message-ID:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=Yzi8WBu4KujBYoF2CzJN07cCvMBEcE/HJeNevlQaE4I=; b=KuM4QCNJaSS5KAPoq6DcT2r9qm 0efED0C3oRiUTNAYTeyzRJaYCTR5SGRgrM63xWAzuWQzMG3nLbeWWSplaxOAjX7FIwlp5DskF21qm +7VKn55yWyXVglp7qri61PFvWqSYsChd3aBF7eeENAgIvkkcEDqHa/AqUvcTxxZJQg2mFi8kMDnyc DboigzXcPxU29jDADDRB6+WTVa2dtz3x4L6twexpziw7rQnLaDukJQKk/j+2JVnGp+L9Lz8xzSH8P tjLrCxpESAeLgiuX29/zu7omPcLz/YYrSpd5EUaPyhQVWy616lGRcwHnmIHjS7yZ8RgwpxKaQkMib D7bPALAg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.99.1 #2 (Red Hat Linux)) id 1wfPa5-00000005cIz-2CqZ; Thu, 02 Jul 2026 22:08:25 +0000 Received: from tor.source.kernel.org ([172.105.4.254]) by bombadil.infradead.org with esmtps (Exim 4.99.1 #2 (Red Hat Linux)) id 1wfPa3-00000005cH3-2KmV for linux-arm-kernel@lists.infradead.org; Thu, 02 Jul 2026 22:08:23 +0000 Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) by tor.source.kernel.org (Postfix) with ESMTP id A86C0601CA; Thu, 2 Jul 2026 22:08:22 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 5E5C91F000E9; Thu, 2 Jul 2026 22:08:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1783030102; bh=Yzi8WBu4KujBYoF2CzJN07cCvMBEcE/HJeNevlQaE4I=; h=Date:From:To:Cc:Subject:In-Reply-To:References; b=kfGWxluKtGo8vdz42fwQgulPVuMznMV1PWOTLBGUXYfKic36EXdVZLLP1g6uOSoRG PV3vQpEZfWfQFLEB88U8rGIXhBjW9jmHh5/Vrf4SqHnXt5840RpqjhY4xuLG/tZ+g9 /6RP8aB+ZimPbkXslfAVXhsNC/c58w0EsNWchQrODwqvpv1h6jkWVGUb6JJ6P1eU2j zFi5n6GRhUpiyi84oSiNOPP32fK//Ly+myohXHQxULXp2LEkKHm83eIHYW9yKOMjnx TCdf8vDkX97DpYZIZAxMctYPiFNoRPif00juP6RHLLt3eD1+zs8IGSNKYLOT1lxK0i clWZCZ1WxSKOQ== Received: from sofa.misterjones.org ([185.219.108.64] helo=lobster-girl.misterjones.org) by disco-boy.misterjones.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.98.2) (envelope-from ) id 1wfPa0-00000000vYv-2cTc; Thu, 02 Jul 2026 22:08:20 +0000 Date: Thu, 02 Jul 2026 23:10:09 +0100 Message-ID: <87h5mh6o1q.wl-maz@kernel.org> From: Marc Zyngier To: Kemeng Shi Cc: tglx@kernel.org, lpieralisi@kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v4 4/6] irqchip/gic-v3-its: Add ITS address info in more error logs In-Reply-To: <20260702033050.1583-5-shikemeng@huaweicloud.com> References: <20260702033050.1583-1-shikemeng@huaweicloud.com> <20260702033050.1583-5-shikemeng@huaweicloud.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/30.1 (aarch64-unknown-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII X-SA-Exim-Connect-IP: 185.219.108.64 X-SA-Exim-Rcpt-To: shikemeng@huaweicloud.com, tglx@kernel.org, lpieralisi@kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, 02 Jul 2026 04:30:48 +0100, Kemeng Shi wrote: > > Multiple ITS units may exist in a system. When an error occurs, it is > difficult to identify which ITS triggered it because most error logs > lack the ITS address. Some logs already include this information and > is useful for debugging. Add the ITS address to the remaining error > logs so that all ITS-related errors can be consistently attributed to > a specific ITS instance. I already said *no* to this. If you want to log errors, implement a PMU or RAS driver that reports errors on a per ITS basis, in a way that is collectable by existing tooling. The kernel log is not the place for your sorry debug hacks, which is in general not readable by normal users. And I'd rather remove the other instances as a matter of consistency. M. -- Jazz isn't dead. It just smells funny.