public inbox for linux-arm-kernel@lists.infradead.org
 help / color / mirror / Atom feed
From: Takashi Iwai <tiwai@suse.de>
To: wangdich9700@163.com
Cc: lgirdwood@gmail.com, broonie@kernel.org, perex@perex.cz,
	tiwai@suse.com, linux-kernel@vger.kernel.org,
	alsa-devel@alsa-project.org,
	linux-arm-kernel@lists.infradead.org,
	wangdicheng <wangdicheng@kylinos.cn>
Subject: Re: [PATCH 1/2] ALSA: hda/realtek: Accelerate the front MIC charging and discharging of the 897 codec
Date: Mon, 04 Aug 2025 09:08:27 +0200	[thread overview]
Message-ID: <87h5yn1s44.wl-tiwai@suse.de> (raw)
In-Reply-To: <87jz3j1ug9.wl-tiwai@suse.de>

On Mon, 04 Aug 2025 08:17:58 +0200,
Takashi Iwai wrote:
> 
> On Mon, 04 Aug 2025 05:05:17 +0200,
> wangdich9700@163.com wrote:
> > 
> > From: wangdicheng <wangdicheng@kylinos.cn>
> > 
> > The front MIC capacitance of the Inspur board is too large, resulting in a longer charging and discharging time required,
> > which in turn prevents recording for 5 seconds before startup.
> > Therefore, software is used to increase the delay by 2 seconds to avoid this issue.
> 
> First off, the HD-audio code was replaced in the latest Linus tree to
> sound/hda/* directories, so please adapt the patches accordingly.
> 
> About the code change:
> 
> - The 2.5 seconds wait is way too long and inappropriate to be put in
>   the resume callback.  It has to be fixed differently.
> 
> - Does it apply really to all devices with 0x10ec1304?  It's Realtek's
>   vendor id, so this can match to many devices.
> 
> - Last but not least, it's not nice to have a code that depends on the
>   certain vendor id there.  Again, please implement in a different way
>   so that it can be handled in more device-specific code rather than
>   the common function.

One more thing: the mailing list for Linux kernel sound stuff is
linux-sound@vger.kernel.org.  Please use this one instead of
alsa-devel ML.


thanks,

Takashi


      reply	other threads:[~2025-08-04  7:11 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-08-04  3:05 [PATCH 1/2] ALSA: hda/realtek: Accelerate the front MIC charging and discharging of the 897 codec wangdich9700
2025-08-04  3:05 ` [PATCH 2/2] ALSA: hda/realtek: Fix ALC662 codec pop noise on recording wangdich9700
2025-08-04  6:17 ` [PATCH 1/2] ALSA: hda/realtek: Accelerate the front MIC charging and discharging of the 897 codec Takashi Iwai
2025-08-04  7:08   ` Takashi Iwai [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87h5yn1s44.wl-tiwai@suse.de \
    --to=tiwai@suse.de \
    --cc=alsa-devel@alsa-project.org \
    --cc=broonie@kernel.org \
    --cc=lgirdwood@gmail.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=perex@perex.cz \
    --cc=tiwai@suse.com \
    --cc=wangdich9700@163.com \
    --cc=wangdicheng@kylinos.cn \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox