From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id A2AABC2BA15 for ; Mon, 17 Jun 2024 14:02:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Type:MIME-Version: Message-ID:Date:References:In-Reply-To:Subject:Cc:To:From:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=JEgP6nrjaN40xXEwrTWVtd3w2ZCVG6Zro3ipay84baA=; b=kMOAwd8feltc8VhmnAKcQ7joaH JwW2mgSgZfCYGyZzWuHB4mwHjvpSNErwwye94ng0gc6fVlpNP3VjEMsw2nFgY+o6n0w8vjq4taaqK pgEryYqRMj5CXnsK5TE96pXEXqmME01M1pW+US+3BxzVPohWHncP/62bQrXuunrLFAzwui4lK+EEw y3RJ5e9SmnYqYdNQqcIyLwjjDifoMmRGnX1qavqejkYN8Ym5iERS7dRon3zqszSAp2CGiBpWwhKDl gR6nuPsHqpv8dO/5jqopbCvFmUVEax8cBd1um2l9YB4qCJNLqXVkoud4OolYgbGVU6lgkjGnaF0xG vrapPMwg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sJCwP-0000000B2sI-2ViG; Mon, 17 Jun 2024 14:02:37 +0000 Received: from galois.linutronix.de ([2a0a:51c0:0:12e:550::1]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1sJCwF-0000000B2p5-3BLb for linux-arm-kernel@lists.infradead.org; Mon, 17 Jun 2024 14:02:35 +0000 From: Thomas Gleixner DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020; t=1718632944; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=JEgP6nrjaN40xXEwrTWVtd3w2ZCVG6Zro3ipay84baA=; b=31aNCmxyI/jOsyTTXBeM6zLOjjQJmBDkyUdhsoWDBTLxXzOlVyN0tY4+kT8ZuV6vJBoFuW afESyFWstnehE+WAucaWFJ3+jTNdVWtn9IjTJdIMoLveJNeq7npCDjw9fKDSX0yTUwgk6T 5jcix4c5z2Dw7S5s6wQ1bvQUniKK77gU+L8bkoebow9BKZ0UJmj3tWh43KZdxxzjqew12/ 4Y4By4mGrPqzg9nkCTWq/wdSwrEiktuefqkEcuRcjITjqP/bMC0b7DrDfnE6nspWq7l7rs OVN8Lk89Z87Y0CdS7WKghBvIxHCw9IcKCGmk8FRvPvqTNbMJZf+a9xYMCcw0zA== DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020e; t=1718632944; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=JEgP6nrjaN40xXEwrTWVtd3w2ZCVG6Zro3ipay84baA=; b=O1Uv28M2yo4rAmZ4lCRhT1xRU04yv0o/VdQz1V1zAT3CwbTAbIaDWD/Jizs55LvqBgsVTp HfpoRuEmjxZhj7Aw== To: Marc Zyngier Cc: Shivamurthy Shastri , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-pci@vger.kernel.org, anna-maria@linutronix.de, shawnguo@kernel.org, s.hauer@pengutronix.de, festevam@gmail.com, bhelgaas@google.com, rdunlap@infradead.org, vidyas@nvidia.com, ilpo.jarvinen@linux.intel.com, apatel@ventanamicro.com, kevin.tian@intel.com, nipun.gupta@amd.com, den@valinux.co.jp, andrew@lunn.ch, gregory.clement@bootlin.com, sebastian.hesselbarth@gmail.com, gregkh@linuxfoundation.org, rafael@kernel.org, alex.williamson@redhat.com, will@kernel.org, lorenzo.pieralisi@arm.com, jgg@mellanox.com, ammarfaizi2@gnuweeb.org, robin.murphy@arm.com, lpieralisi@kernel.org, nm@ti.com, kristo@kernel.org, vkoul@kernel.org, okaya@kernel.org, agross@kernel.org, andersson@kernel.org, mark.rutland@arm.com, shameerali.kolothum.thodi@huawei.com, yuzenghui@huawei.com Subject: Re: [PATCH v3 14/24] genirq/gic-v3-mbi: Remove unused wired MSI mechanics In-Reply-To: <86h6drk9h1.wl-maz@kernel.org> References: <20240614102403.13610-1-shivamurthy.shastri@linutronix.de> <20240614102403.13610-15-shivamurthy.shastri@linutronix.de> <86le36jf0q.wl-maz@kernel.org> <87plsfu3sz.ffs@tglx> <86h6drk9h1.wl-maz@kernel.org> Date: Mon, 17 Jun 2024 16:02:24 +0200 Message-ID: <87h6dru0pb.ffs@tglx> MIME-Version: 1.0 Content-Type: text/plain X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240617_070227_972848_5351D131 X-CRM114-Status: GOOD ( 17.40 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, Jun 17 2024 at 14:03, Marc Zyngier wrote: > On Mon, 17 Jun 2024 13:55:24 +0100, > Thomas Gleixner wrote: >> >> On Sat, Jun 15 2024 at 18:24, Marc Zyngier wrote: >> > On Fri, 14 Jun 2024 11:23:53 +0100, >> > Shivamurthy Shastri wrote: >> >> static struct msi_domain_info mbi_pmsi_domain_info = { >> >> - .flags = (MSI_FLAG_USE_DEF_DOM_OPS | MSI_FLAG_USE_DEF_CHIP_OPS | >> >> - MSI_FLAG_LEVEL_CAPABLE), >> >> + .flags = (MSI_FLAG_USE_DEF_DOM_OPS | MSI_FLAG_USE_DEF_CHIP_OPS), >> >> .ops = &mbi_pmsi_ops, >> >> .chip = &mbi_pmsi_irq_chip, >> >> }; >> > >> > This patch doesn't do what it says. It simply kills any form of level >> > MSI support for *endpoints*, and has nothing to do with any sort of >> > "wire to MSI". >> > >> > What replaces it? >> >> Patch 9/24 switches the wire to MSI with level support over. This just >> removes the leftovers. > > That's not what I read. > > Patch 9/24 rewrites the mbigen driver. Which has nothing to do with > what the gic-v3-mbi code does. They are different blocks, and the sole > machine that has the mbigen IP doesn't have any gic-v3-mbi support. > All they have in common are 3 random letters. > > What you are doing here is to kill any support for *devices* that need > to signal level-triggered MSIs in that driver, and nothing to do with > wire-MSI translation. > > So what replaces it? Hrm. I must have misread this mess. Let me stare some more.