* Re: [REGRESSION] MT7915E doesn't work any more with v6.9
2024-05-15 6:23 ` Johannes Berg
@ 2024-05-15 7:15 ` Oleksandr Natalenko
2024-05-15 7:40 ` Linux regression tracking (Thorsten Leemhuis)
2024-05-15 7:48 ` Kalle Valo
2024-05-15 7:44 ` Kalle Valo
2024-05-25 6:26 ` Kalle Valo
2 siblings, 2 replies; 14+ messages in thread
From: Oleksandr Natalenko @ 2024-05-15 7:15 UTC (permalink / raw)
To: linux-kernel, linux-wireless,
Linux regression tracking (Thorsten Leemhuis), Johannes Berg
Cc: linux-mediatek, linux-arm-kernel, Felix Fietkau, Lorenzo Bianconi,
Ryder Lee, Shayne Chen, Sean Wang, Kalle Valo, Matthias Brugger,
AngeloGioacchino Del Regno, Peter Chiu, StanleyYP Wang,
Linux regressions mailing list
[-- Attachment #1.1: Type: text/plain, Size: 1010 bytes --]
Hello Johannes.
On středa 15. května 2024 8:23:35, SELČ Johannes Berg wrote:
> On Wed, 2024-05-15 at 00:51 +0200, Oleksandr Natalenko wrote:
> > Also /cc Johannes because of this commit:
> >
> > 6092077ad09ce wifi: mac80211: introduce 'channel request'
> >
> > On středa 15. května 2024 0:43:40, SELČ Oleksandr Natalenko wrote:
> > > Hello Felix, Lorenzo et al.
> > >
> > > With v6.9 kernel the following card:
> > >
> > > 01:00.0 Unclassified device [0002]: MEDIATEK Corp. MT7915E 802.11ax PCI Express Wireless Network Adapter [14c3:7915]
> > >
> > > doesn't work any more. Upon mt7915e module insertion the following splat happens:
> > >
>
> 6.9 didn't get commit 2f7cf3b61d85 ("wifi: mt76: mt7915: add missing
> chanctx ops")? Huh?
Yes, you are right, this commit is not present in v6.9, and I can find it in the "next" branch only.
I can also confirm this commit fixes the regression for me.
Thank you.
> johannes
>
--
Oleksandr Natalenko (post-factum)
[-- Attachment #1.2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
[-- Attachment #2: Type: text/plain, Size: 176 bytes --]
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 14+ messages in thread* Re: [REGRESSION] MT7915E doesn't work any more with v6.9
2024-05-15 7:15 ` Oleksandr Natalenko
@ 2024-05-15 7:40 ` Linux regression tracking (Thorsten Leemhuis)
2024-05-15 7:56 ` Greg KH
2024-05-15 7:48 ` Kalle Valo
1 sibling, 1 reply; 14+ messages in thread
From: Linux regression tracking (Thorsten Leemhuis) @ 2024-05-15 7:40 UTC (permalink / raw)
To: Oleksandr Natalenko, linux-kernel, linux-wireless, Johannes Berg
Cc: linux-mediatek, linux-arm-kernel, Felix Fietkau, Lorenzo Bianconi,
Ryder Lee, Shayne Chen, Sean Wang, Kalle Valo, Matthias Brugger,
AngeloGioacchino Del Regno, Peter Chiu, StanleyYP Wang,
Linux regressions mailing list
On 15.05.24 09:15, Oleksandr Natalenko wrote:
> On středa 15. května 2024 8:23:35, SELČ Johannes Berg wrote:
>> On Wed, 2024-05-15 at 00:51 +0200, Oleksandr Natalenko wrote:
>>> Also /cc Johannes because of this commit:
>>>
>>> 6092077ad09ce wifi: mac80211: introduce 'channel request'
>>>
>>> On středa 15. května 2024 0:43:40, SELČ Oleksandr Natalenko wrote:
>>>> Hello Felix, Lorenzo et al.
>>>>
>>>> With v6.9 kernel the following card:
>>>>
>>>> 01:00.0 Unclassified device [0002]: MEDIATEK Corp. MT7915E 802.11ax PCI Express Wireless Network Adapter [14c3:7915]
>>>> doesn't work any more. Upon mt7915e module insertion the following splat happens:
>>
>> 6.9 didn't get commit 2f7cf3b61d85 ("wifi: mt76: mt7915: add missing
>> chanctx ops")? Huh?
FWIW, seems there was and earlier report about this that I missed:
https://lore.kernel.org/all/CAAMvbhGHe4PM5M=JJZRQ2m5_aVZ=4DPG76MT+q5qi3HA+7_wzQ@mail.gmail.com/
> Yes, you are right, this commit is not present in v6.9, and I can find it in the "next" branch only.
>
> I can also confirm this commit fixes the regression for me.
So all we need to resolve this is to ask Greg to pick up the patch for
the next 6.9.y. release? Then I'll take care of that in a few hours,
unless somebody else does it first or I get some kind of "might be a bad
idea for now" signal from anyone.
Ciao, Thorsten
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 14+ messages in thread* Re: [REGRESSION] MT7915E doesn't work any more with v6.9
2024-05-15 7:40 ` Linux regression tracking (Thorsten Leemhuis)
@ 2024-05-15 7:56 ` Greg KH
0 siblings, 0 replies; 14+ messages in thread
From: Greg KH @ 2024-05-15 7:56 UTC (permalink / raw)
To: Linux regressions mailing list
Cc: Oleksandr Natalenko, linux-kernel, linux-wireless, Johannes Berg,
linux-mediatek, linux-arm-kernel, Felix Fietkau, Lorenzo Bianconi,
Ryder Lee, Shayne Chen, Sean Wang, Kalle Valo, Matthias Brugger,
AngeloGioacchino Del Regno, Peter Chiu, StanleyYP Wang
On Wed, May 15, 2024 at 09:40:40AM +0200, Linux regression tracking (Thorsten Leemhuis) wrote:
> On 15.05.24 09:15, Oleksandr Natalenko wrote:
> > On středa 15. května 2024 8:23:35, SELČ Johannes Berg wrote:
> >> On Wed, 2024-05-15 at 00:51 +0200, Oleksandr Natalenko wrote:
> >>> Also /cc Johannes because of this commit:
> >>>
> >>> 6092077ad09ce wifi: mac80211: introduce 'channel request'
> >>>
> >>> On středa 15. května 2024 0:43:40, SELČ Oleksandr Natalenko wrote:
> >>>> Hello Felix, Lorenzo et al.
> >>>>
> >>>> With v6.9 kernel the following card:
> >>>>
> >>>> 01:00.0 Unclassified device [0002]: MEDIATEK Corp. MT7915E 802.11ax PCI Express Wireless Network Adapter [14c3:7915]
> >>>> doesn't work any more. Upon mt7915e module insertion the following splat happens:
> >>
> >> 6.9 didn't get commit 2f7cf3b61d85 ("wifi: mt76: mt7915: add missing
> >> chanctx ops")? Huh?
>
> FWIW, seems there was and earlier report about this that I missed:
> https://lore.kernel.org/all/CAAMvbhGHe4PM5M=JJZRQ2m5_aVZ=4DPG76MT+q5qi3HA+7_wzQ@mail.gmail.com/
>
> > Yes, you are right, this commit is not present in v6.9, and I can find it in the "next" branch only.
> >
> > I can also confirm this commit fixes the regression for me.
>
> So all we need to resolve this is to ask Greg to pick up the patch for
> the next 6.9.y. release? Then I'll take care of that in a few hours,
> unless somebody else does it first or I get some kind of "might be a bad
> idea for now" signal from anyone.
Now picked up for 6.9.y.
greg k-h
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [REGRESSION] MT7915E doesn't work any more with v6.9
2024-05-15 7:15 ` Oleksandr Natalenko
2024-05-15 7:40 ` Linux regression tracking (Thorsten Leemhuis)
@ 2024-05-15 7:48 ` Kalle Valo
1 sibling, 0 replies; 14+ messages in thread
From: Kalle Valo @ 2024-05-15 7:48 UTC (permalink / raw)
To: Oleksandr Natalenko
Cc: linux-kernel, linux-wireless,
Linux regression tracking (Thorsten Leemhuis), Johannes Berg,
linux-mediatek, linux-arm-kernel, Felix Fietkau, Lorenzo Bianconi,
Ryder Lee, Shayne Chen, Sean Wang, Matthias Brugger,
AngeloGioacchino Del Regno, Peter Chiu, StanleyYP Wang,
Linux regressions mailing list
Oleksandr Natalenko <oleksandr@natalenko.name> writes:
> Hello Johannes.
>
> On středa 15. května 2024 8:23:35, SELČ Johannes Berg wrote:
>> On Wed, 2024-05-15 at 00:51 +0200, Oleksandr Natalenko wrote:
>> > Also /cc Johannes because of this commit:
>> >
>> > 6092077ad09ce wifi: mac80211: introduce 'channel request'
>> >
>> > On středa 15. května 2024 0:43:40, SELČ Oleksandr Natalenko wrote:
>> > > Hello Felix, Lorenzo et al.
>> > >
>> > > With v6.9 kernel the following card:
>> > >
>> > > 01:00.0 Unclassified device [0002]: MEDIATEK Corp. MT7915E 802.11ax PCI Express Wireless Network Adapter [14c3:7915]
>> > >
>> > > doesn't work any more. Upon mt7915e module insertion the following splat happens:
>> > >
>>
>> 6.9 didn't get commit 2f7cf3b61d85 ("wifi: mt76: mt7915: add missing
>> chanctx ops")? Huh?
>
> Yes, you are right, this commit is not present in v6.9, and I can find it in the "next" branch only.
>
> I can also confirm this commit fixes the regression for me.
Thanks for testing.
#regzbot fix: 2f7cf3b61d85
--
https://patchwork.kernel.org/project/linux-wireless/list/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [REGRESSION] MT7915E doesn't work any more with v6.9
2024-05-15 6:23 ` Johannes Berg
2024-05-15 7:15 ` Oleksandr Natalenko
@ 2024-05-15 7:44 ` Kalle Valo
2024-05-25 6:26 ` Kalle Valo
2 siblings, 0 replies; 14+ messages in thread
From: Kalle Valo @ 2024-05-15 7:44 UTC (permalink / raw)
To: Johannes Berg
Cc: Oleksandr Natalenko, linux-kernel, linux-wireless,
Linux regression tracking (Thorsten Leemhuis), linux-mediatek,
linux-arm-kernel, Felix Fietkau, Lorenzo Bianconi, Ryder Lee,
Shayne Chen, Sean Wang, Matthias Brugger,
AngeloGioacchino Del Regno, Peter Chiu, StanleyYP Wang,
Linux regressions mailing list
Johannes Berg <johannes@sipsolutions.net> writes:
> On Wed, 2024-05-15 at 00:51 +0200, Oleksandr Natalenko wrote:
>> Also /cc Johannes because of this commit:
>>
>> 6092077ad09ce wifi: mac80211: introduce 'channel request'
>>
>> On středa 15. května 2024 0:43:40, SELČ Oleksandr Natalenko wrote:
>> > Hello Felix, Lorenzo et al.
>> >
>> > With v6.9 kernel the following card:
>> >
>> > 01:00.0 Unclassified device [0002]: MEDIATEK Corp. MT7915E 802.11ax PCI Express Wireless Network Adapter [14c3:7915]
>> >
>> > doesn't work any more. Upon mt7915e module insertion the following splat happens:
>> >
>
> 6.9 didn't get commit 2f7cf3b61d85 ("wifi: mt76: mt7915: add missing
> chanctx ops")? Huh?
Ah, it will be only in v6.10-rc1. Oleksandr, can you try this commit:
https://git.kernel.org/linus/2f7cf3b61d85
--
https://patchwork.kernel.org/project/linux-wireless/list/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 14+ messages in thread* Re: [REGRESSION] MT7915E doesn't work any more with v6.9
2024-05-15 6:23 ` Johannes Berg
2024-05-15 7:15 ` Oleksandr Natalenko
2024-05-15 7:44 ` Kalle Valo
@ 2024-05-25 6:26 ` Kalle Valo
2024-05-25 6:35 ` Kalle Valo
2024-05-27 18:29 ` Greg KH
2 siblings, 2 replies; 14+ messages in thread
From: Kalle Valo @ 2024-05-25 6:26 UTC (permalink / raw)
To: Johannes Berg
Cc: Oleksandr Natalenko, linux-kernel, linux-wireless,
Linux regression tracking (Thorsten Leemhuis), linux-mediatek,
linux-arm-kernel, Felix Fietkau, Lorenzo Bianconi, Ryder Lee,
Shayne Chen, Sean Wang, Matthias Brugger,
AngeloGioacchino Del Regno, Peter Chiu, StanleyYP Wang,
Linux regressions mailing list
Johannes Berg <johannes@sipsolutions.net> writes:
> On Wed, 2024-05-15 at 00:51 +0200, Oleksandr Natalenko wrote:
>> Also /cc Johannes because of this commit:
>>
>> 6092077ad09ce wifi: mac80211: introduce 'channel request'
>>
>> On středa 15. května 2024 0:43:40, SELČ Oleksandr Natalenko wrote:
>> > Hello Felix, Lorenzo et al.
>> >
>> > With v6.9 kernel the following card:
>> >
>> > 01:00.0 Unclassified device [0002]: MEDIATEK Corp. MT7915E
>> > 802.11ax PCI Express Wireless Network Adapter [14c3:7915]
>> >
>> > doesn't work any more. Upon mt7915e module insertion the following splat happens:
>> >
>
> 6.9 didn't get commit 2f7cf3b61d85 ("wifi: mt76: mt7915: add missing
> chanctx ops")? Huh?
Yeah, commit 2f7cf3b61d85 should have been taken to wireless tree but it
fell through the cracks. I didn't realise that it's an important bugfix
and the commit message didn't give any indication of that either.
But commit 2f7cf3b61d85 is now in Linus' tree so it would be good if
someone could submit it to stable releases.
--
https://patchwork.kernel.org/project/linux-wireless/list/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 14+ messages in thread* Re: [REGRESSION] MT7915E doesn't work any more with v6.9
2024-05-25 6:26 ` Kalle Valo
@ 2024-05-25 6:35 ` Kalle Valo
2024-05-27 18:29 ` Greg KH
1 sibling, 0 replies; 14+ messages in thread
From: Kalle Valo @ 2024-05-25 6:35 UTC (permalink / raw)
To: Johannes Berg
Cc: Oleksandr Natalenko, linux-kernel, linux-wireless,
Linux regression tracking (Thorsten Leemhuis), linux-mediatek,
linux-arm-kernel, Felix Fietkau, Lorenzo Bianconi, Ryder Lee,
Shayne Chen, Sean Wang, Matthias Brugger,
AngeloGioacchino Del Regno, Peter Chiu, StanleyYP Wang,
Linux regressions mailing list
Kalle Valo <kvalo@kernel.org> writes:
> Johannes Berg <johannes@sipsolutions.net> writes:
>
>> On Wed, 2024-05-15 at 00:51 +0200, Oleksandr Natalenko wrote:
>>> Also /cc Johannes because of this commit:
>>>
>>> 6092077ad09ce wifi: mac80211: introduce 'channel request'
>>>
>>> On středa 15. května 2024 0:43:40, SELČ Oleksandr Natalenko wrote:
>>> > Hello Felix, Lorenzo et al.
>>> >
>>> > With v6.9 kernel the following card:
>>> >
>>> > 01:00.0 Unclassified device [0002]: MEDIATEK Corp. MT7915E
>>> > 802.11ax PCI Express Wireless Network Adapter [14c3:7915]
>>> >
>>> > doesn't work any more. Upon mt7915e module insertion the following splat happens:
>>> >
>>
>> 6.9 didn't get commit 2f7cf3b61d85 ("wifi: mt76: mt7915: add missing
>> chanctx ops")? Huh?
>
> Yeah, commit 2f7cf3b61d85 should have been taken to wireless tree but it
> fell through the cracks. I didn't realise that it's an important bugfix
> and the commit message didn't give any indication of that either.
>
> But commit 2f7cf3b61d85 is now in Linus' tree so it would be good if
> someone could submit it to stable releases.
Johannes pointed out to me that the commit is already in stable:
https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/commit/?h=linux-6.9.y&id=ddb02739a2be54ed922bce3cb57d5f901590ee70
So all should be good now.
--
https://patchwork.kernel.org/project/linux-wireless/list/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 14+ messages in thread* Re: [REGRESSION] MT7915E doesn't work any more with v6.9
2024-05-25 6:26 ` Kalle Valo
2024-05-25 6:35 ` Kalle Valo
@ 2024-05-27 18:29 ` Greg KH
2024-05-27 18:30 ` Johannes Berg
1 sibling, 1 reply; 14+ messages in thread
From: Greg KH @ 2024-05-27 18:29 UTC (permalink / raw)
To: Kalle Valo
Cc: Johannes Berg, Oleksandr Natalenko, linux-kernel, linux-wireless,
Linux regression tracking (Thorsten Leemhuis), linux-mediatek,
linux-arm-kernel, Felix Fietkau, Lorenzo Bianconi, Ryder Lee,
Shayne Chen, Sean Wang, Matthias Brugger,
AngeloGioacchino Del Regno, Peter Chiu, StanleyYP Wang,
Linux regressions mailing list
On Sat, May 25, 2024 at 09:26:01AM +0300, Kalle Valo wrote:
> Johannes Berg <johannes@sipsolutions.net> writes:
>
> > On Wed, 2024-05-15 at 00:51 +0200, Oleksandr Natalenko wrote:
> >> Also /cc Johannes because of this commit:
> >>
> >> 6092077ad09ce wifi: mac80211: introduce 'channel request'
> >>
> >> On středa 15. května 2024 0:43:40, SELČ Oleksandr Natalenko wrote:
> >> > Hello Felix, Lorenzo et al.
> >> >
> >> > With v6.9 kernel the following card:
> >> >
> >> > 01:00.0 Unclassified device [0002]: MEDIATEK Corp. MT7915E
> >> > 802.11ax PCI Express Wireless Network Adapter [14c3:7915]
> >> >
> >> > doesn't work any more. Upon mt7915e module insertion the following splat happens:
> >> >
> >
> > 6.9 didn't get commit 2f7cf3b61d85 ("wifi: mt76: mt7915: add missing
> > chanctx ops")? Huh?
>
> Yeah, commit 2f7cf3b61d85 should have been taken to wireless tree but it
> fell through the cracks. I didn't realise that it's an important bugfix
> and the commit message didn't give any indication of that either.
>
> But commit 2f7cf3b61d85 is now in Linus' tree so it would be good if
> someone could submit it to stable releases.
It's already in 6.9.1, does it need to go anywhere else?
thanks,
greg k-h
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 14+ messages in thread* Re: [REGRESSION] MT7915E doesn't work any more with v6.9
2024-05-27 18:29 ` Greg KH
@ 2024-05-27 18:30 ` Johannes Berg
0 siblings, 0 replies; 14+ messages in thread
From: Johannes Berg @ 2024-05-27 18:30 UTC (permalink / raw)
To: Greg KH, Kalle Valo
Cc: Oleksandr Natalenko, linux-kernel, linux-wireless,
Linux regression tracking (Thorsten Leemhuis), linux-mediatek,
linux-arm-kernel, Felix Fietkau, Lorenzo Bianconi, Ryder Lee,
Shayne Chen, Sean Wang, Matthias Brugger,
AngeloGioacchino Del Regno, Peter Chiu, StanleyYP Wang,
Linux regressions mailing list
On Mon, 2024-05-27 at 20:29 +0200, Greg KH wrote:
> >
> > Yeah, commit 2f7cf3b61d85 should have been taken to wireless tree but it
> > fell through the cracks. I didn't realise that it's an important bugfix
> > and the commit message didn't give any indication of that either.
> >
> > But commit 2f7cf3b61d85 is now in Linus' tree so it would be good if
> > someone could submit it to stable releases.
>
> It's already in 6.9.1, does it need to go anywhere else?
>
No, but apparently we need a similar commit for mt7915e or something? I
have no idea why I missed those. I'll take a look tomorrow.
johannes
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 14+ messages in thread