From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 13E7BC05027 for ; Thu, 26 Jan 2023 15:32:14 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:Message-ID:Date:References:In-Reply-To: Subject:Cc:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=4qGmsXxeZP5e6q6DXm8gOiXdrN243hb42Pw12EJL4iQ=; b=R+t9cSiUj+PhYotdWXHXmPOayE aHrHeZfnJ9raGxHTkkJ87Bc9n8f2G+ZpGDMr2k6Ga+mNbkjCKfZGIQROwWmiJpk+8IjOyec/lJ8wu fk/GsIiK2tQUHFB0qUK+s0ldmnLAFrtF8HsGUrS9p7dJQKPCMs41nxgWWv4qIvlHA4uoD7f7R/mSP Yc//hcNGXxBSwqtRTI7PitQlWTRoAdYExT0N2hReeo7UCoztdUEfyLGnuyxwvkAdbnuDJ6cM8FxjK zkvZ9GzcEpt596SNbhR043ITyfBILu86V3nYlxMwdyylwlKJE4PeXvyrp6qcmC5reiJkvk7fX6lE3 IBYrtApw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1pL4DX-00BWuD-PC; Thu, 26 Jan 2023 15:31:11 +0000 Received: from madras.collabora.co.uk ([2a00:1098:0:82:1000:25:2eeb:e5ab]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1pL4DU-00BWsq-CX; Thu, 26 Jan 2023 15:31:09 +0000 Received: from ryzen9 (unknown [79.119.122.0]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: aratiu) by madras.collabora.co.uk (Postfix) with ESMTPSA id B411466018E4; Thu, 26 Jan 2023 15:31:04 +0000 (GMT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1674747065; bh=6l03pcXoUO/jHX88INu7oBIANmYByZgCGrrOf8ec8TE=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=j1Fj+iWfuNKhwLJchHJXaeWh5IVuL0FfKzwaMsYbmbYtd2l9Zn0UIqMeLoaU4n/F+ 4jtru2ouZzgUiUTx014f31+8o5cdEC8m8aA7LiazFvig/51vh1Bx1bVCFzukswKpkQ RnRLTTLMkpOjKcbyHy3zo3ycpvcrYdLURClRKDU87PkDeHhKguJ649mrBV2RxDOPzf miPHXgy267Eh0Cn7gEaDG2vcR2I378DEII1DpBPz5egq4sW9jpqpqRL5LjGoby+4pQ xerjzHOWrllJey+1NsxWMLQyI/gDhDIGkePJPiCZlvX7Tai3aG6JE9yhQideV5oiDv u4CrCuG0kvVIg== From: Adrian Ratiu To: AngeloGioacchino Del Regno Cc: u.kleine-koenig@pengutronix.de, matthias.bgg@gmail.com, weiqing.kong@mediatek.com, jitao.shi@mediatek.com, linux-pwm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org, kernel@collabora.com, thierry.reding@gmail.com Subject: Re: [PATCH 0/2] pwm: mtk-disp: Fix backlight configuration at boot In-Reply-To: <20230123160615.375969-1-angelogioacchino.delregno@collabora.com> References: <20230123160615.375969-1-angelogioacchino.delregno@collabora.com> Date: Thu, 26 Jan 2023 17:31:02 +0200 Message-ID: <87h6wdxqh5.fsf@collabora.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230126_073108_577705_F5207CB5 X-CRM114-Status: GOOD ( 14.52 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, 23 Jan 2023, AngeloGioacchino Del Regno wrote: > Since the pwm-mtk-disp driver was fixed to get PWM_EN state from > the right register, an old two-wrongs-make-one-right issue > emerged: as a result, MT8192 Asurada Spherion got no backlight > at boot unless a suspend/resume cycle was performed. Also, the > backlight would sometimes not get updated with the requested > value, requiring the user to change it back and forth until it > worked. > > This series fixes both of the aforementioned issues found on > MT8192. Thanks for the series. This also improves backlight on MT8183. I've been testing using the panfrost driver on a ChromiumOS userspace on a jacuzzi board and I've had issues like the screen going blank then not coming back, which these patches appear to solve. Many thanks! Tested-by: Adrian Ratiu > > AngeloGioacchino Del Regno (2): > pwm: mtk-disp: Disable shadow registers before setting backlight > values > pwm: mtk-disp: Configure double buffering before reading in > .get_state() > > drivers/pwm/pwm-mtk-disp.c | 34 +++++++++++++++++++++++----------- > 1 file changed, 23 insertions(+), 11 deletions(-) > > -- > 2.39.0 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel