From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.0 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, MENTIONS_GIT_HOSTING,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,T_DKIMWL_WL_HIGH, URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0B580C04AB5 for ; Mon, 3 Jun 2019 15:05:10 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id D08B825ABF for ; Mon, 3 Jun 2019 15:05:09 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="nS/MylZ3" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org D08B825ABF Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=bootlin.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-ID:Date:References :In-Reply-To:Subject:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=duzWcECN0rz58fG4fi2ntzAxG0uMHsYRZtnL9ic6FFY=; b=nS/MylZ3wnY4q2 CTPzAzMSv/EkrY6qyM2JGRYGih48qMB0tsakQdVJtYF/5qB5kBmCblMsjCEYtY8yhJ7VR5MJW214U JV9xk2j+fpXyG6MjoFBZhruKe9qBEx05TLKHzvtiXGK9cQHLharwlCd6rXnmq/MORWjjQRGu5tWH6 NPh2yxCt0eTV4+FvwzwijWcY7aY3iguIyDbGrb2wCNVsn/WiC0ARW3n+oXvNy6fafBrI0AsiHwRc4 A9o0XEnYJo0CZoOXIrZNxXZxHmLese7JRueEYXW/ph01dkRE5KLg8pfNFOXzLmDvu8tUIgNbRuhu+ eao3sSQ85LSuxqxwO5qg==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1hXoWG-0004m3-82; Mon, 03 Jun 2019 15:05:04 +0000 Received: from relay2-d.mail.gandi.net ([217.70.183.194]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1hXoWC-0004Uv-RP for linux-arm-kernel@lists.infradead.org; Mon, 03 Jun 2019 15:05:02 +0000 X-Originating-IP: 92.137.69.152 Received: from localhost (alyon-656-1-672-152.w92-137.abo.wanadoo.fr [92.137.69.152]) (Authenticated sender: gregory.clement@bootlin.com) by relay2-d.mail.gandi.net (Postfix) with ESMTPSA id A018B40008; Mon, 3 Jun 2019 15:04:49 +0000 (UTC) From: Gregory CLEMENT To: Tomasz Maciej Nowak , Jason Cooper , Andrew Lunn , Sebastian Hesselbarth , Rob Herring , Mark Rutland Subject: Re: [PATCH] arm64: dts: armada-3720-espressobin: correct spi node In-Reply-To: <20190527111614.3694-1-tmn505@gmail.com> References: <20190527111614.3694-1-tmn505@gmail.com> Date: Mon, 03 Jun 2019 17:04:49 +0200 Message-ID: <87h896k8vi.fsf@FE-laptop> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190603_080501_040291_7D01DD15 X-CRM114-Status: GOOD ( 15.51 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree@vger.kernel.org, Ellie Reeves , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Uwe =?utf-8?Q?Kleine-K=C3=B6nig?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org Tomasz Maciej Nowak writes: > The manufacturer of this board, ships it with various SPI NOR chips and > increments U-Boot bootloader version along the time. There is no way to > tell which is placed on the board since no revision bump takes place. > This creates two issues. > > The first, cosmetic. Since the NOR chip may differ, there's message on > boot stating that kernel expected w25q32dw and found different one. To > correct this, remove optional device-specific compatible string. Being > here lets replace bogus "spi-flash" compatible string with proper one. > > The second is linked to partitions layout, it changed after commit: > 81e7251252 ("arm64: mvebu: config: move env to the end of the 4MB boot > device") in Marvells downstream U-Boot fork [1], shifting environment > location to the end of boot device. Since the new boards will have U-Boot > with this change, it'll lead to improper results writing or reading from > these partitions. We can't tell if users will update bootloader to recent > version provided on manufacturer website, so lets drop partitons layout. > > 1. https://github.com/MarvellEmbeddedProcessors/u-boot-marvell.git > > Signed-off-by: Tomasz Maciej Nowak Applied on mvebu/dt64 Thanks, Gregory > --- > .../dts/marvell/armada-3720-espressobin.dts | 18 +----------------- > 1 file changed, 1 insertion(+), 17 deletions(-) > > diff --git a/arch/arm64/boot/dts/marvell/armada-3720-espressobin.dts b/arch/arm64/boot/dts/marvell/armada-3720-espressobin.dts > index 6be019e1888e..fbcf03f86c96 100644 > --- a/arch/arm64/boot/dts/marvell/armada-3720-espressobin.dts > +++ b/arch/arm64/boot/dts/marvell/armada-3720-espressobin.dts > @@ -95,25 +95,9 @@ > > flash@0 { > reg = <0>; > - compatible = "winbond,w25q32dw", "jedec,spi-flash"; > + compatible = "jedec,spi-nor"; > spi-max-frequency = <104000000>; > m25p,fast-read; > - > - partitions { > - compatible = "fixed-partitions"; > - #address-cells = <1>; > - #size-cells = <1>; > - > - partition@0 { > - label = "uboot"; > - reg = <0 0x180000>; > - }; > - > - partition@180000 { > - label = "ubootenv"; > - reg = <0x180000 0x10000>; > - }; > - }; > }; > }; > > -- > 2.21.0 > -- Gregory Clement, Bootlin Embedded Linux and Kernel engineering http://bootlin.com _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel