From mboxrd@z Thu Jan 1 00:00:00 1970 From: khilman@ti.com (Kevin Hilman) Date: Tue, 07 Jun 2011 09:04:09 -0700 Subject: [PATCH v2 1/2] ARM: omap4: gpio: fix setting IRQWAKEN bits In-Reply-To: (Grant Likely's message of "Mon, 6 Jun 2011 19:06:36 -0600") References: <1307392698-21170-1-git-send-email-ccross@android.com> <87boyav99n.fsf@ti.com> Message-ID: <87hb81r5l2.fsf@ti.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Grant Likely writes: > On Mon, Jun 6, 2011 at 5:18 PM, Kevin Hilman wrote: >> Hi Colin, >> >> Colin Cross writes: >> >>> Setting the IRQWAKEN bit was overwriting previous IRQWAKEN bits, >>> causing only the last bit set to take effect, resulting in lost >>> wakeups when the GPIO controller is in idle. >>> >>> Replace direct writes to IRQWAKEN with MOD_REG_BIT calls to >>> perform a read-modify-write on the register. >>> >>> Signed-off-by: Colin Cross >> >> Thanks, I'll queue these both for Grant for the 3.0-rc fixes along with >> another GPIO fix for a section mismatch I have queued. >> >> Minor: now that this driver has moved to drivers, I changed the subject >> prefixes slightly. ?They now read: >> >> GPIO: OMAP: fix setting IRQWAKEN bits for OMAP4 >> GPIO: OMAP: add locking around calls to _set_gpio_triggering > > If you're collecting fixes for Linus anyway, go ahead and add my a-b > line and include these two to send on to Linus > > Acked-by: Grant Likely > > Or, if they are only gpio fixes, then I'd also be happy to get a git > pull req for the changes. :-) > I have a GPIO-only queue, so I'll have a pull req for you today. Kevin