From: Marc Zyngier <maz@kernel.org>
To: Mark Brown <broonie@kernel.org>
Cc: Oliver Upton <oliver.upton@linux.dev>,
Joey Gouly <joey.gouly@arm.com>,
Suzuki K Poulose <suzuki.poulose@arm.com>,
Paolo Bonzini <pbonzini@redhat.com>,
Shuah Khan <shuah@kernel.org>,
linux-arm-kernel@lists.infradead.org, kvmarm@lists.linux.dev,
kvm@vger.kernel.org, linux-kselftest@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 0/2] KVM: arm64: selftests: Cover ID_AA64ISAR3_EL1 in set_id_regs
Date: Wed, 24 Sep 2025 19:29:49 +0100 [thread overview]
Message-ID: <87ikh7ya8y.wl-maz@kernel.org> (raw)
In-Reply-To: <20250920-kvm-arm64-id-aa64isar3-el1-v1-0-1764c1c1c96d@kernel.org>
On Sat, 20 Sep 2025 20:51:58 +0100,
Mark Brown <broonie@kernel.org> wrote:
>
> The set_id_regs selftest lacks coverag for ID_AA64ISR3_EL1 which has
> several features exposed to KVM guests in it. Add coverage, and while
> we're here adjust the test to improve maintainability a bit.
>
> The test will fail without the recently applied change adding FEAT_LSFE:
>
> https://lore.kernel.org/r/175829303126.1764550.939188785634158487.b4-ty@kernel.org
>
> Signed-off-by: Mark Brown <broonie@kernel.org>
> ---
> Mark Brown (2):
> KVM: arm64: selftests: Remove a duplicate register listing in set_id_regs
> KVM: arm64: selftests: Cover ID_AA64ISAR3_EL1 in set_id_regs
>
> tools/testing/selftests/kvm/arm64/set_id_regs.c | 22 ++++++++++++++--------
> 1 file changed, 14 insertions(+), 8 deletions(-)
> ---
> base-commit: 5db15c998c390efbe5c82f6cda77cb896a3a6a3e
$ git show 5db15c998c390efbe5c82f6cda77cb896a3a6a3e
fatal: bad object 5db15c998c390efbe5c82f6cda77cb896a3a6a3e
What's the point of indicating a base commit if that's not something I
can find? You should never base any work on top of something that
isn't a stable tag.
M.
--
Jazz isn't dead. It just smells funny.
next prev parent reply other threads:[~2025-09-24 18:30 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-20 19:51 [PATCH 0/2] KVM: arm64: selftests: Cover ID_AA64ISAR3_EL1 in set_id_regs Mark Brown
2025-09-20 19:51 ` [PATCH 1/2] KVM: arm64: selftests: Remove a duplicate register listing " Mark Brown
2025-09-20 19:52 ` [PATCH 2/2] KVM: arm64: selftests: Cover ID_AA64ISAR3_EL1 " Mark Brown
2025-10-10 15:29 ` Zenghui Yu
2025-09-22 23:35 ` [PATCH 0/2] " Oliver Upton
2025-09-24 18:29 ` Marc Zyngier [this message]
2025-09-25 11:12 ` Mark Brown
2025-09-24 18:38 ` Marc Zyngier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87ikh7ya8y.wl-maz@kernel.org \
--to=maz@kernel.org \
--cc=broonie@kernel.org \
--cc=joey.gouly@arm.com \
--cc=kvm@vger.kernel.org \
--cc=kvmarm@lists.linux.dev \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=oliver.upton@linux.dev \
--cc=pbonzini@redhat.com \
--cc=shuah@kernel.org \
--cc=suzuki.poulose@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox