From: Thomas Gleixner <tglx@linutronix.de>
To: Florian Fainelli <f.fainelli@gmail.com>,
Florian Fainelli <florian.fainelli@broadcom.com>,
linux-kernel@vger.kernel.org
Cc: opendmb@gmail.com, Tim Ross <tim.ross@broadcom.com>,
Broadcom internal kernel review list
<bcm-kernel-feedback-list@broadcom.com>,
"open list:BROADCOM BMIPS MIPS ARCHITECTURE"
<linux-mips@vger.kernel.org>,
"moderated list:BROADCOM BCM7XXX ARM ARCHITECTURE"
<linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH] irqchip/irq-brcmstb-l2: Avoid saving mask on shutdown
Date: Tue, 23 Apr 2024 01:45:27 +0200 [thread overview]
Message-ID: <87il09ufl4.ffs@tglx> (raw)
In-Reply-To: <958c27b1-26d7-4927-976b-4502f33f31f7@gmail.com>
On Mon, Apr 22 2024 at 15:26, Florian Fainelli wrote:
> On 4/22/24 14:29, Thomas Gleixner wrote:
>>> + if (save)
>>> + b->saved_mask = irq_reg_readl(gc, ct->regs.mask);
>>
>> what's the conditional actually buying you except more complex code?
>
> Not much this is an optimization that is simple to carry out. There can
> be dozens of such L2 interrupt controllers in a given system and the
> MMIO accesses start adding up eventually.
I'm impressed by saving ~12 microseconds per one dozen of interrupt
controllers on system shutdown :)
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2024-04-22 23:45 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-16 19:43 [PATCH] irqchip/irq-brcmstb-l2: Avoid saving mask on shutdown Florian Fainelli
2024-04-22 21:29 ` Thomas Gleixner
2024-04-22 22:26 ` Florian Fainelli
2024-04-22 23:45 ` Thomas Gleixner [this message]
2024-04-24 16:50 ` Florian Fainelli
2024-04-24 17:19 ` Thomas Gleixner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87il09ufl4.ffs@tglx \
--to=tglx@linutronix.de \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=f.fainelli@gmail.com \
--cc=florian.fainelli@broadcom.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@vger.kernel.org \
--cc=opendmb@gmail.com \
--cc=tim.ross@broadcom.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).