From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id F29ECC4345F for ; Mon, 22 Apr 2024 23:45:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-ID:Date:References :In-Reply-To:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=IhnmMzURKKEZyGNDsLYtgV84Hp3YkPuDPU0eCVh9J+Y=; b=Lu50kSwdOWSkNe IDnNwKFvLUxGE8l9RhGH5UtjelfgUy+Weh3CXcZSi5kMhXo2RjrRXbSklu1Q4odlXCTnhQ91LNXo6 NmPfaxVfa9uoP6urYJCSMDA8ITOSNbQ8saXrl4dfA+sZhmqK4R6bnXr5QWyPyMburG/rKuTdn5EQF jEiiRYDA3wFn+Fa+aeFgQtI6Qp5auA+AV1PlXk2se1hOccs1A4wwCoG26CYPBU/9ydrTk+6CHkrsM h74S6boyPBCKwEluRNnfMlpStbZSFGqTxw7Pc4tLYXcYF5f9dy3uGkGowIhC63CRrcqgpL1KYu92+ HQjh3Qoz5XxMdaDyRFDA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rz3Lw-0000000FQ6F-1SQ6; Mon, 22 Apr 2024 23:45:40 +0000 Received: from galois.linutronix.de ([2a0a:51c0:0:12e:550::1]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rz3Ls-0000000FQ5K-2EiX for linux-arm-kernel@lists.infradead.org; Mon, 22 Apr 2024 23:45:39 +0000 From: Thomas Gleixner DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020; t=1713829531; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=Z3iuol9n0ncMFMx3ZU/0KzyHn3TSc5ypZiXe1W2A5oM=; b=SNo8ScRn/1GkRdN2RdGq8C0spZlkhHnRirTAe1ms3kV9ohl07WzEzX6H3DoNspRUYM0Ppt KfaVYeZA7x29ikRk9pTWR1oE56fQEveBnqlngTBAzDYMo5kk9T5jH2DPgwXMzxc5ZeQFTP g7Ld4hXuPNtVSzsC4dg0tnRQ49tgrPE5mCLXjrqQev4D9CJrKrtCXuabH+oYFYV0VVfVOf 58ClO2hQYBGlfsKDDrpXYndvqWshr7bfyfdbr/tda5zoxwySbSY3Rz1x/a+QheZPGGRkUg R7V7UNaOqaQj7+6ZIef0Mme5uGSmAEae7IktutF9gpN7nRcOJra0k7JpgDu85A== DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020e; t=1713829531; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=Z3iuol9n0ncMFMx3ZU/0KzyHn3TSc5ypZiXe1W2A5oM=; b=8WX9ZE1N45eKmwx2FOtbDg26c+wW39hf9Ig69BrWHfZpNpLCaNB3vI0A2+vt5SPjIFekcq G1TB3/M3SVk0OyCA== To: Florian Fainelli , Florian Fainelli , linux-kernel@vger.kernel.org Cc: opendmb@gmail.com, Tim Ross , Broadcom internal kernel review list , "open list:BROADCOM BMIPS MIPS ARCHITECTURE" , "moderated list:BROADCOM BCM7XXX ARM ARCHITECTURE" Subject: Re: [PATCH] irqchip/irq-brcmstb-l2: Avoid saving mask on shutdown In-Reply-To: <958c27b1-26d7-4927-976b-4502f33f31f7@gmail.com> References: <20240416194343.469318-1-florian.fainelli@broadcom.com> <87le55ulw5.ffs@tglx> <958c27b1-26d7-4927-976b-4502f33f31f7@gmail.com> Date: Tue, 23 Apr 2024 01:45:27 +0200 Message-ID: <87il09ufl4.ffs@tglx> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240422_164536_815967_63F6DE1B X-CRM114-Status: UNSURE ( 8.02 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, Apr 22 2024 at 15:26, Florian Fainelli wrote: > On 4/22/24 14:29, Thomas Gleixner wrote: >>> + if (save) >>> + b->saved_mask = irq_reg_readl(gc, ct->regs.mask); >> >> what's the conditional actually buying you except more complex code? > > Not much this is an optimization that is simple to carry out. There can > be dozens of such L2 interrupt controllers in a given system and the > MMIO accesses start adding up eventually. I'm impressed by saving ~12 microseconds per one dozen of interrupt controllers on system shutdown :) _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel