From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 68CEBC4829D for ; Mon, 12 Feb 2024 12:17:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: List-Subscribe:List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id: MIME-Version:Message-ID:Date:References:In-Reply-To:Subject:Cc:To:From: Reply-To:Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date :Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=ErWiSnhND4cO/+sX2npZ1osZ6/++RUpDMeRgQhYWdPI=; b=R7Elh1XrFJtls31Zuy23y0zF3X C2FMhhQN7+7aLO83qdDlihpgPFYxADUU8InnSePb5wuj/9HjRkTiiTk3nfjBbNNdewA73r4BfPnog F67zp5J7PvKYY7zbyPBYAZsgiSyxSPwF6O+SkxG5ccok210i7eaxv5H02p53rPORms+2At3IrcGsO epr2NO86KMAPs6LlnSopljMby9QNy8FZ68yElFkAQiMCNSKflv3uiTbn+CLJeihkKaF8cs06RdmgG eoT1vQHYkZ/X3saQjq5+kFTEZ1rrf4JAkPuNPPdIn+xhgtdzfum846FvF6O3Es6ZsJXZ5W1NuYyYs gEHS9Hug==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rZVFr-00000005FE1-3I34; Mon, 12 Feb 2024 12:17:47 +0000 Received: from galois.linutronix.de ([193.142.43.55]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rZVFn-00000005FAI-0r58 for linux-arm-kernel@lists.infradead.org; Mon, 12 Feb 2024 12:17:46 +0000 From: Kurt Kanzenbach DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020; t=1707740258; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=Ss8+0g2Vw7bFP3dHKPiPH0ijjnT07QmFxhc8x5JkdWk=; b=XEUQiYyTxYObKen4QmrlRE5tC1bNSkyXawJkfGuiti5rRUsakKrPkkl14mjs9KQmujaO4i UW9tl+blTBQ5YMT158wXne/LNu1KH9qSFtIPk42yj1M0ExkuzfRdE9Z8D/m/qtS7hSv1U7 QanaYsrAeoYbpezT7SS0ns+J9cadk9VyEn6wRHnjFAKVDBZJbcTp7m/OJ8Jz3+Tf6X4e/A cyOEuS0qk9SQo+VmM9eqovH89LBcZ1LBa3aaQSxcBOOnS30fo2BdhpXK/jhrIs7y4NNCge rTCIqkEzbNROcEEMEGGUOv0UVGJEmRfGm9y0GUEmXBxAGOWH3kbxiH+O6uSM2A== DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020e; t=1707740258; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=Ss8+0g2Vw7bFP3dHKPiPH0ijjnT07QmFxhc8x5JkdWk=; b=cOe+9uRrx5U1EJs6y9RrsykUs92t+b95NGF4VPv7uAAjHG3AC+h6mI/a9i43cROcXruvqT bSO9Wqi2MqdmnSBQ== To: Alexandre Torgue , Jose Abreu , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Maxime Coquelin Cc: Yannick Vignon , Sebastian Andrzej Siewior , netdev@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH net-next] net: stmmac: Simplify mtl IRQ status checking In-Reply-To: <20240208-stmmac_irq-v1-1-8bab236026d4@linutronix.de> References: <20240208-stmmac_irq-v1-1-8bab236026d4@linutronix.de> Date: Mon, 12 Feb 2024 13:17:37 +0100 Message-ID: <87il2t98ri.fsf@kurt.kurt.home> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240212_041743_434134_24E60C0E X-CRM114-Status: UNSURE ( 9.03 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: multipart/mixed; boundary="===============0940686852684646389==" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org --===============0940686852684646389== Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" --=-=-= Content-Type: text/plain On Thu Feb 08 2024, Kurt Kanzenbach wrote: > Commit 8a7cb245cf28 ("net: stmmac: Do not enable RX FIFO overflow > interrupts") disabled the RX FIFO overflow interrupts. However, it left the > status variable around, but never checks it. > > As stmmac_host_mtl_irq_status() returns only 0 now, the code can be > simplified. > > Signed-off-by: Kurt Kanzenbach Hi Jakub, why did this got marked as Changes Requested. What changes have to be made? Thanks, Kurt --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQJHBAEBCgAxFiEEvLm/ssjDfdPf21mSwZPR8qpGc4IFAmXKDGETHGt1cnRAbGlu dXRyb25peC5kZQAKCRDBk9HyqkZzgnngD/wOtmEmDPbwzPKAYz411R83LsJESiGo ZgnRhNOzTYuOKVOS8aAEuyCjaj4Kc/jIhwrEhXxReei7fgEwMhvCkxBKS5q7VQvN zJk/O5VgXPOcS2lE8/vg0hQaetztOAi/GpNF00YOlsSHT/wxtY2AwSZeXDOXrZDl Ta6Uy78m6nVBTv4FHyKPQIoKHRfdhR/hhVUJh76dN+pRLezsSQvz1qygZLYyHjz9 8WoeGAzjSA9hk6L3/ECEMw+nn70IC7f0R33/hKRMYg0Z6f0UDzJnFrZ29QrWiqHM W7to6wWFDqNfukWOpEVJF2FlPc/+88BQcGnNndSG/3roakLBxzdsl360hJAdxlPe cwOJ2HRd8jByU6xJwnO3RcKhMdi/WyH7gmr9Q0S2fZE6vbq7EDfkCVhSwSyOEWUH 7nY6If+JuF1Ew3/Teixa9EKOHTUqndzTOmk4mqv+VmKum5T2gQRdE/P/kNmDrWZF Us+vMyghfWN24flf3Mkf0/xyg6skucsYy6uMwhtBbZX1RQPvD0qDExALYEEnh7a8 nhNwlHd6/yxaoibxLfk1ftSKujnupPB8yI4B2sIfmJWmJ3sCTBeQbKEeM16mRX7D I/Vq0TSoKl/zHQY7wrq3hvAWFWk0V8rX3uXEbB1byOvj54V4cph4CfyhfmHd3ZaG O5ylu4WY7N0R3Q== =Tj0h -----END PGP SIGNATURE----- --=-=-=-- --===============0940686852684646389== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel --===============0940686852684646389==--