From: Baruch Siach <baruch@tkos.co.il>
To: "Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>
Cc: linux-serial@vger.kernel.org,
Greg KH <gregkh@linuxfoundation.org>,
Jiri Slaby <jirislaby@kernel.org>,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org,
Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Subject: Re: [PATCH 14/44] serial: digicolor: Use uart_xmit_advance()
Date: Wed, 19 Oct 2022 14:30:51 +0300 [thread overview]
Message-ID: <87ilkgdp17.fsf@tarshish> (raw)
In-Reply-To: <20221019091151.6692-15-ilpo.jarvinen@linux.intel.com>
Hi Ilpo,
On Wed, Oct 19 2022, Ilpo Järvinen wrote:
> Take advantage of the new uart_xmit_advance() helper.
>
> Signed-off-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>
Acked-by: Baruch Siach <baruch@tkos.co.il>
Thanks,
baruch
> ---
> drivers/tty/serial/digicolor-usart.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/tty/serial/digicolor-usart.c b/drivers/tty/serial/digicolor-usart.c
> index 0c0a62346f23..ed197705f7ee 100644
> --- a/drivers/tty/serial/digicolor-usart.c
> +++ b/drivers/tty/serial/digicolor-usart.c
> @@ -202,8 +202,7 @@ static void digicolor_uart_tx(struct uart_port *port)
>
> while (!uart_circ_empty(xmit)) {
> writeb(xmit->buf[xmit->tail], port->membase + UA_EMI_REC);
> - xmit->tail = (xmit->tail + 1) & (UART_XMIT_SIZE - 1);
> - port->icount.tx++;
> + uart_xmit_advance(port, 1);
>
> if (digicolor_uart_tx_full(port))
> break;
--
~. .~ Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
- baruch@tkos.co.il - tel: +972.52.368.4656, http://www.tkos.co.il -
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2022-10-19 11:37 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20221019091151.6692-1-ilpo.jarvinen@linux.intel.com>
2022-10-19 9:11 ` [PATCH 11/44] serial: atmel: Use uart_xmit_advance() Ilpo Järvinen
2022-10-20 9:01 ` Claudiu.Beznea
2022-10-20 13:06 ` Richard Genoud
2022-10-19 9:11 ` [PATCH 12/44] serial: clps711x: " Ilpo Järvinen
2022-10-19 9:11 ` [PATCH 14/44] serial: digicolor: " Ilpo Järvinen
2022-10-19 11:30 ` Baruch Siach [this message]
2022-10-19 9:11 ` [PATCH 17/44] serial: imx: " Ilpo Järvinen
2022-10-19 13:14 ` Uwe Kleine-König
2022-10-19 9:11 ` [PATCH 22/44] serial: meson: " Ilpo Järvinen
2022-10-19 9:36 ` Neil Armstrong
2022-10-19 20:42 ` Martin Blumenstingl
2022-10-19 9:11 ` [PATCH 23/44] serial: milbeaut_usio: " Ilpo Järvinen
2022-10-19 9:11 ` [PATCH 27/44] serial: rda: " Ilpo Järvinen
2022-10-19 9:11 ` [PATCH 28/44] serial: samsung_tty: " Ilpo Järvinen
2022-10-21 11:48 ` Sam Protsenko
2022-10-19 9:11 ` [PATCH 34/44] serial: stm32: " Ilpo Järvinen
2022-10-19 9:11 ` [PATCH 43/44] serial: xuartps: " Ilpo Järvinen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87ilkgdp17.fsf@tarshish \
--to=baruch@tkos.co.il \
--cc=andriy.shevchenko@linux.intel.com \
--cc=gregkh@linuxfoundation.org \
--cc=ilpo.jarvinen@linux.intel.com \
--cc=jirislaby@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).