From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id B5988C6FA82 for ; Thu, 22 Sep 2022 09:29:03 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Subject:Cc:To:From:Message-ID:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=Oqy//QOTFu6tWdE3AncJ+PXZXSKtF4pc49b6Y0JF38A=; b=yykoIt6QXyVJVZ a+6Gc5B2zT7qr8UPkwQvMGeykaxQplDSxJOywnKRCYi+iqEDqoj9IDRzIMt+9c79fn95U4rWny966 xfc4gfr54TsgX2HL+DGmWWdwGnKFMnpzjfebMjmw14d3o+CVJ/d5LU/piEONIxsh6Le0sG8Wokm6Z 5Ly/zuIkZkxHed8fssaL23VhphIsRi8vmVzZS5G02b2Se0QZf1lnxtZAGo9mkRvGXuwM6c53OU0mX Y1KiZyBpADg/dn7vI1l27sZvFujcbUXc8UEIoG+5KlVLskFsmCHLWDSZxW+s1wteSn6uj/LX66BWH sOzRlY/6LUaK8mG2X0bA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1obIUS-00ERvb-GW; Thu, 22 Sep 2022 09:27:30 +0000 Received: from ams.source.kernel.org ([145.40.68.75]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1obIKt-00EP4Q-Sx for linux-arm-kernel@lists.infradead.org; Thu, 22 Sep 2022 09:17:37 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 3EA57B83567; Thu, 22 Sep 2022 09:17:34 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id D9523C433D6; Thu, 22 Sep 2022 09:17:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1663838252; bh=d1bj7NoeTwC6Lx1X6ziK4AjlLmrJTJF3DowJifqcCQU=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=RHI5RGFM6qUtx37r6c7rLN6MLed7Ik1JQTz9m3PJofNEzF2DAwU0hcI01f2NUSdSC GvItCD7JOVPSJVDIC3e5kXSNkypHxsukpxraCXkHiBHRXPRTw9MPp3lWYqf7Q5jKqe Ab23otJcEN/ndZh+i+cMF/XeBiAjUda2SXAM1GjDiUjiofNkfkMx9QqKEMq3JUdbQO B3ILg6+kLcd31gfVfLB1P2hnD6z/qXy1UJNpXXZRGbx/KmR3qgzz8Fb+t2t2q4ZNmy YqKYWzT/GAYVgylB4SD/vvFD+qF9kGGKo1G8hfNQ4DyjPdRU+ea3f6Xv0erXy5GRff ENnd409EbgWQA== Received: from 185-176-101-241.host.sccbroadband.ie ([185.176.101.241] helo=wait-a-minute.misterjones.org) by disco-boy.misterjones.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1obIKo-00Br7c-I6; Thu, 22 Sep 2022 10:17:30 +0100 Date: Thu, 22 Sep 2022 10:17:27 +0100 Message-ID: <87illfkbtk.wl-maz@kernel.org> From: Marc Zyngier To: Bartosz Golaszewski Cc: Sasha Levin , linux-kernel@vger.kernel.org, stable@vger.kernel.org, Linus Walleij , linusw@kernel.org, kaloz@openwrt.org, khalasa@piap.pl, linux-arm-kernel@lists.infradead.org, linux-gpio@vger.kernel.org Subject: Re: [PATCH AUTOSEL 5.4 2/5] gpio: ixp4xx: Make irqchip immutable In-Reply-To: References: <20220921155436.235371-1-sashal@kernel.org> <20220921155436.235371-2-sashal@kernel.org> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/27.1 (x86_64-pc-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") X-SA-Exim-Connect-IP: 185.176.101.241 X-SA-Exim-Rcpt-To: brgl@bgdev.pl, sashal@kernel.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org, linus.walleij@linaro.org, linusw@kernel.org, kaloz@openwrt.org, khalasa@piap.pl, linux-arm-kernel@lists.infradead.org, linux-gpio@vger.kernel.org X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220922_021736_315389_9D7C83F4 X-CRM114-Status: GOOD ( 28.29 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Bartosz, On Wed, 21 Sep 2022 21:04:27 +0100, Bartosz Golaszewski wrote: > > On Wed, Sep 21, 2022 at 6:57 PM Marc Zyngier wrote: > > > > On 2022-09-21 16:54, Sasha Levin wrote: > > > From: Linus Walleij > > > > > > [ Upstream commit 94e9bc73d85aa6ecfe249e985ff57abe0ab35f34 ] > > > > > > This turns the IXP4xx GPIO irqchip into an immutable > > > irqchip, a bit different from the standard template due > > > to being hierarchical. > > > > > > Tested on the IXP4xx which uses drivers/ata/pata_ixp4xx_cf.c > > > for a rootfs on compact flash with IRQs from this GPIO > > > block to the CF ATA controller. > > > > > > Cc: Marc Zyngier > > > Signed-off-by: Linus Walleij > > > Acked-by: Marc Zyngier > > > Signed-off-by: Bartosz Golaszewski > > > Signed-off-by: Sasha Levin > > > > Why? The required dependencies are only in 5,19, and are > > definitely NOT a stable candidate... > > > > This isn't a fix by any stretch of the imagination. > > > > Hi Marc, > > While I didn't mark it for stable (and it shouldn't go into any branch > earlier than 5.19.x), I did send the patches making the irqchips > immutable to Linus Torvalds as fixes as they technically do *fix* the > warning emitted by gpiolib and make the implementation correct. > > I think these patches should still be part of the v5.19.x stable branch. 5.19, sure. All the dependencies are there, and tightening the driver implementations is a valuable goal. However, targeting all the other stable releases (5.4, 5.10, 5.15) makes little sense. It won't even compile! Do the dependencies need to be backported? I don't think it is worthwhile, as this is a long series containing multiple related changes spread all over the tree. This would defeat the very purpose of a stable tree. M. -- Without deviation from the norm, progress is not possible. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel