From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id EC1CFC433EF for ; Mon, 17 Jan 2022 10:41:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-ID:In-reply-to: Date:Subject:Cc:To:From:References:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=CCgaliljRjvRPdU5t2/i0OqgzH2Pv8V3koqGxMo0N7Q=; b=fi1If/OP+sKxXx TjWl/cYFx5lrxMzY+avbbzlGmwYu22la47OQ2z1XBv38vRkwjb2RtuLnux88yXRaINWzV4x4K0BLO Io8LL5rmZYLv1yEPlkQF7BshnraTg7/F3qEpl/uzfsVS7sIsoJo8vHLDrv3iDxpBWaRlbBOsx40sN mqJ0LrLA1G1i0VEPDUsZYQw8FUUcIcBRAvaXTW9PX73pmmHt5VfLXKDFMA4a1Dgs0YE/Y7OpjtwUf 7X2IbhIGmINaEw1dE+y7ieOaAdqD23WMbfmHVCAdxpw7GMZJEUOUJnQ0fBTJd2Lyd8Bby7kK0xQNm 1SvvM1zFcRFiD1e4iUtA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1n9PQP-00EX9i-J6; Mon, 17 Jan 2022 10:39:45 +0000 Received: from guitar.tcltek.co.il ([84.110.109.230] helo=mx.tkos.co.il) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1n9PQL-00EX7E-KA for linux-arm-kernel@lists.infradead.org; Mon, 17 Jan 2022 10:39:43 +0000 Received: from tarshish (unknown [10.0.8.4]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx.tkos.co.il (Postfix) with ESMTPS id 95CE3440242; Mon, 17 Jan 2022 12:39:29 +0200 (IST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tkos.co.il; s=default; t=1642415970; bh=9Wg6psWGSMPUmDfhFxRofL+wpsigvBX363eYVFLuJnw=; h=References:From:To:Cc:Subject:Date:In-reply-to:From; b=JO7OKIChuye2W6vXIBuASeSEzoc2VJTsqP4Nrt/8hySPQx4xjozgcWoQcMaBXHdQ/ /8otSTLG8P5JGQA3bS9+8rx2PqdtOUrRUgnHCmcwxFIjtu0hblB9+XWEdDdk72Dbg5 BWsJZ4B5MBphAIQtMn8fr4zHVjiJ5VduzDSBA3UDtB1+CBUj+NlBpg/Llb0L+NSGlg vqWcBoGMW7fCiQ5zekYPrX2STR7GbJydLpApb4fjr7VIjWC9Sz4OmMeSFkRLH9Dpfs mbQDbJfLcU+24n47Ev0tthaSWr4J6n5masxmyIBTumQn58+mtfgU1qOsuDEvFu6EgM ffbR2+3ONnXNw== References: <20220114233904.907918-1-sean.anderson@seco.com> User-agent: mu4e 1.6.10; emacs 27.1 From: Baruch Siach To: Sean Anderson , Thinh Nguyen Cc: Greg Kroah-Hartman , linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, Robert Hancock , Felipe Balbi , Balaji Prakash J , Andy Gross , Bjorn Andersson , Michal Simek , Rob Herring , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-arm-msm@vger.kernel.org Subject: Re: [PATCH 0/6] usb: dwc3: Calculate REFCLKPER et. al. from reference clock Date: Mon, 17 Jan 2022 12:36:25 +0200 In-reply-to: <20220114233904.907918-1-sean.anderson@seco.com> Message-ID: <87iluifxy1.fsf@tarshish> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220117_023941_919044_7F2DCC2B X-CRM114-Status: GOOD ( 12.72 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Sean, Thinh, On Fri, Jan 14 2022, Sean Anderson wrote: > This is a rework of patches 3-5 of [1]. It attempts to correctly program > REFCLKPER and REFCLK_FLADJ based on the reference clock frequency. Since > we no longer need a special property duplicating this configuration, > snps,ref-clock-period-ns is deprecated. > > Please test this! Patches 3/4 in this series have the effect of > programming REFCLKPER and REFCLK_FLADJ on boards which already configure > the "ref" clock. I have build tested, but not much else. > > [1] https://lore.kernel.org/linux-usb/20220114044230.2677283-1-robert.hancock@calian.com/ Thinh, you suggested the dedicated DT property for the reference clock: https://lore.kernel.org/all/d5acb192-80b9-36f7-43f5-81f21c4e6ba0@synopsys.com/ Can you comment on this series? Thanks, baruch > Sean Anderson (6): > dt-bindings: usb: dwc3: Deprecate snps,ref-clock-period-ns > usb: dwc3: Get clocks individually > usb: dwc3: Calculate REFCLKPER based on reference clock > usb: dwc3: Handle fractional reference clocks > arm64: dts: zynqmp: Move USB clocks to dwc3 node > arm64: dts: ipq6018: Use reference clock to set dwc3 period > > .../devicetree/bindings/usb/snps,dwc3.yaml | 7 +- > arch/arm64/boot/dts/qcom/ipq6018.dtsi | 3 +- > .../arm64/boot/dts/xilinx/zynqmp-clk-ccf.dtsi | 4 +- > arch/arm64/boot/dts/xilinx/zynqmp.dtsi | 4 +- > drivers/usb/dwc3/core.c | 98 ++++++++++++++++--- > drivers/usb/dwc3/core.h | 6 +- > 6 files changed, 98 insertions(+), 24 deletions(-) -- ~. .~ Tk Open Systems =}------------------------------------------------ooO--U--Ooo------------{= - baruch@tkos.co.il - tel: +972.52.368.4656, http://www.tkos.co.il - _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel