From: Marc Zyngier <maz@kernel.org>
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc: linux-arm-kernel@lists.infradead.org,
kvmarm@lists.cs.columbia.edu, linux-kernel@vger.kernel.org,
James Morse <james.morse@arm.com>,
Alexandru Elisei <alexandru.elisei@arm.com>,
Suzuki K Poulose <suzuki.poulose@arm.com>
Subject: Re: [PATCH v1 1/1] KVM: arm64: vgic: Replace kernel.h with the necessary inclusions
Date: Tue, 04 Jan 2022 13:44:31 +0000 [thread overview]
Message-ID: <87iluzvcn4.wl-maz@kernel.org> (raw)
In-Reply-To: <YcN5FKnbT9BHLn9f@smile.fi.intel.com>
On Wed, 22 Dec 2021 19:14:28 +0000,
Andy Shevchenko <andriy.shevchenko@linux.intel.com> wrote:
>
> On Wed, Dec 22, 2021 at 08:25:43PM +0200, Andy Shevchenko wrote:
> > On Wed, Dec 22, 2021 at 06:09:22PM +0000, Marc Zyngier wrote:
> > > On Wed, 22 Dec 2021 16:55:52 +0000,
> > > Andy Shevchenko <andriy.shevchenko@linux.intel.com> wrote:
> > > >
> > > > When kernel.h is used in the headers it adds a lot into dependency hell,
> > > > especially when there are circular dependencies are involved.
> > >
> > > Which circular dependencies? What problem are you solving?
> >
> > In particular moving bitmap_*alloc() APIs to the headers.
> >
> > But this may be a side effect of what I realized during the attempts
> > of solving that issue. In any case there is no need to take entire
> > mess of kernel.h in another header.
>
> For the record `make headerdep` doesn't make any difference with
> or without this patch. But I consider it's better not to use kernel.h
> in the headers due to a full mess behind it.
Can you then please write a commit message that matches what this is
actually doing instead of mentioning a problem that doesn't seem to
exist?
Thanks,
M.
--
Without deviation from the norm, progress is not possible.
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2022-01-04 13:46 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-22 16:55 [PATCH v1 1/1] KVM: arm64: vgic: Replace kernel.h with the necessary inclusions Andy Shevchenko
2021-12-22 18:09 ` Marc Zyngier
2021-12-22 18:25 ` Andy Shevchenko
2021-12-22 19:14 ` Andy Shevchenko
2022-01-04 13:44 ` Marc Zyngier [this message]
2022-01-04 13:45 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87iluzvcn4.wl-maz@kernel.org \
--to=maz@kernel.org \
--cc=alexandru.elisei@arm.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=james.morse@arm.com \
--cc=kvmarm@lists.cs.columbia.edu \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=suzuki.poulose@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).