* [PATCH v1 1/1] KVM: arm64: vgic: Replace kernel.h with the necessary inclusions
@ 2021-12-22 16:55 Andy Shevchenko
2021-12-22 18:09 ` Marc Zyngier
0 siblings, 1 reply; 6+ messages in thread
From: Andy Shevchenko @ 2021-12-22 16:55 UTC (permalink / raw)
To: Marc Zyngier, linux-arm-kernel, kvmarm, linux-kernel
Cc: James Morse, Alexandru Elisei, Suzuki K Poulose, Andy Shevchenko
When kernel.h is used in the headers it adds a lot into dependency hell,
especially when there are circular dependencies are involved.
Replace kernel.h inclusion with the list of what is really being used.
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
---
include/kvm/arm_vgic.h | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/include/kvm/arm_vgic.h b/include/kvm/arm_vgic.h
index e602d848fc1a..bb30a6803d9f 100644
--- a/include/kvm/arm_vgic.h
+++ b/include/kvm/arm_vgic.h
@@ -5,9 +5,11 @@
#ifndef __KVM_ARM_VGIC_H
#define __KVM_ARM_VGIC_H
-#include <linux/kernel.h>
+#include <linux/bits.h>
#include <linux/kvm.h>
#include <linux/irqreturn.h>
+#include <linux/kref.h>
+#include <linux/mutex.h>
#include <linux/spinlock.h>
#include <linux/static_key.h>
#include <linux/types.h>
--
2.34.1
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH v1 1/1] KVM: arm64: vgic: Replace kernel.h with the necessary inclusions
2021-12-22 16:55 [PATCH v1 1/1] KVM: arm64: vgic: Replace kernel.h with the necessary inclusions Andy Shevchenko
@ 2021-12-22 18:09 ` Marc Zyngier
2021-12-22 18:25 ` Andy Shevchenko
0 siblings, 1 reply; 6+ messages in thread
From: Marc Zyngier @ 2021-12-22 18:09 UTC (permalink / raw)
To: Andy Shevchenko
Cc: linux-arm-kernel, kvmarm, linux-kernel, James Morse,
Alexandru Elisei, Suzuki K Poulose
On Wed, 22 Dec 2021 16:55:52 +0000,
Andy Shevchenko <andriy.shevchenko@linux.intel.com> wrote:
>
> When kernel.h is used in the headers it adds a lot into dependency hell,
> especially when there are circular dependencies are involved.
Which circular dependencies? What problem are you solving?
M.
--
Without deviation from the norm, progress is not possible.
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH v1 1/1] KVM: arm64: vgic: Replace kernel.h with the necessary inclusions
2021-12-22 18:09 ` Marc Zyngier
@ 2021-12-22 18:25 ` Andy Shevchenko
2021-12-22 19:14 ` Andy Shevchenko
0 siblings, 1 reply; 6+ messages in thread
From: Andy Shevchenko @ 2021-12-22 18:25 UTC (permalink / raw)
To: Marc Zyngier
Cc: linux-arm-kernel, kvmarm, linux-kernel, James Morse,
Alexandru Elisei, Suzuki K Poulose
On Wed, Dec 22, 2021 at 06:09:22PM +0000, Marc Zyngier wrote:
> On Wed, 22 Dec 2021 16:55:52 +0000,
> Andy Shevchenko <andriy.shevchenko@linux.intel.com> wrote:
> >
> > When kernel.h is used in the headers it adds a lot into dependency hell,
> > especially when there are circular dependencies are involved.
>
> Which circular dependencies? What problem are you solving?
In particular moving bitmap_*alloc() APIs to the headers.
But this may be a side effect of what I realized during the attempts
of solving that issue. In any case there is no need to take entire
mess of kernel.h in another header.
--
With Best Regards,
Andy Shevchenko
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH v1 1/1] KVM: arm64: vgic: Replace kernel.h with the necessary inclusions
2021-12-22 18:25 ` Andy Shevchenko
@ 2021-12-22 19:14 ` Andy Shevchenko
2022-01-04 13:44 ` Marc Zyngier
0 siblings, 1 reply; 6+ messages in thread
From: Andy Shevchenko @ 2021-12-22 19:14 UTC (permalink / raw)
To: Marc Zyngier
Cc: linux-arm-kernel, kvmarm, linux-kernel, James Morse,
Alexandru Elisei, Suzuki K Poulose
On Wed, Dec 22, 2021 at 08:25:43PM +0200, Andy Shevchenko wrote:
> On Wed, Dec 22, 2021 at 06:09:22PM +0000, Marc Zyngier wrote:
> > On Wed, 22 Dec 2021 16:55:52 +0000,
> > Andy Shevchenko <andriy.shevchenko@linux.intel.com> wrote:
> > >
> > > When kernel.h is used in the headers it adds a lot into dependency hell,
> > > especially when there are circular dependencies are involved.
> >
> > Which circular dependencies? What problem are you solving?
>
> In particular moving bitmap_*alloc() APIs to the headers.
>
> But this may be a side effect of what I realized during the attempts
> of solving that issue. In any case there is no need to take entire
> mess of kernel.h in another header.
For the record `make headerdep` doesn't make any difference with
or without this patch. But I consider it's better not to use kernel.h
in the headers due to a full mess behind it.
--
With Best Regards,
Andy Shevchenko
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH v1 1/1] KVM: arm64: vgic: Replace kernel.h with the necessary inclusions
2021-12-22 19:14 ` Andy Shevchenko
@ 2022-01-04 13:44 ` Marc Zyngier
2022-01-04 13:45 ` Andy Shevchenko
0 siblings, 1 reply; 6+ messages in thread
From: Marc Zyngier @ 2022-01-04 13:44 UTC (permalink / raw)
To: Andy Shevchenko
Cc: linux-arm-kernel, kvmarm, linux-kernel, James Morse,
Alexandru Elisei, Suzuki K Poulose
On Wed, 22 Dec 2021 19:14:28 +0000,
Andy Shevchenko <andriy.shevchenko@linux.intel.com> wrote:
>
> On Wed, Dec 22, 2021 at 08:25:43PM +0200, Andy Shevchenko wrote:
> > On Wed, Dec 22, 2021 at 06:09:22PM +0000, Marc Zyngier wrote:
> > > On Wed, 22 Dec 2021 16:55:52 +0000,
> > > Andy Shevchenko <andriy.shevchenko@linux.intel.com> wrote:
> > > >
> > > > When kernel.h is used in the headers it adds a lot into dependency hell,
> > > > especially when there are circular dependencies are involved.
> > >
> > > Which circular dependencies? What problem are you solving?
> >
> > In particular moving bitmap_*alloc() APIs to the headers.
> >
> > But this may be a side effect of what I realized during the attempts
> > of solving that issue. In any case there is no need to take entire
> > mess of kernel.h in another header.
>
> For the record `make headerdep` doesn't make any difference with
> or without this patch. But I consider it's better not to use kernel.h
> in the headers due to a full mess behind it.
Can you then please write a commit message that matches what this is
actually doing instead of mentioning a problem that doesn't seem to
exist?
Thanks,
M.
--
Without deviation from the norm, progress is not possible.
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH v1 1/1] KVM: arm64: vgic: Replace kernel.h with the necessary inclusions
2022-01-04 13:44 ` Marc Zyngier
@ 2022-01-04 13:45 ` Andy Shevchenko
0 siblings, 0 replies; 6+ messages in thread
From: Andy Shevchenko @ 2022-01-04 13:45 UTC (permalink / raw)
To: Marc Zyngier
Cc: linux-arm-kernel, kvmarm, linux-kernel, James Morse,
Alexandru Elisei, Suzuki K Poulose
On Tue, Jan 04, 2022 at 01:44:31PM +0000, Marc Zyngier wrote:
> On Wed, 22 Dec 2021 19:14:28 +0000,
> Andy Shevchenko <andriy.shevchenko@linux.intel.com> wrote:
> > On Wed, Dec 22, 2021 at 08:25:43PM +0200, Andy Shevchenko wrote:
> > > On Wed, Dec 22, 2021 at 06:09:22PM +0000, Marc Zyngier wrote:
> > > > On Wed, 22 Dec 2021 16:55:52 +0000,
> > > > Andy Shevchenko <andriy.shevchenko@linux.intel.com> wrote:
> > > > >
> > > > > When kernel.h is used in the headers it adds a lot into dependency hell,
> > > > > especially when there are circular dependencies are involved.
> > > >
> > > > Which circular dependencies? What problem are you solving?
> > >
> > > In particular moving bitmap_*alloc() APIs to the headers.
> > >
> > > But this may be a side effect of what I realized during the attempts
> > > of solving that issue. In any case there is no need to take entire
> > > mess of kernel.h in another header.
> >
> > For the record `make headerdep` doesn't make any difference with
> > or without this patch. But I consider it's better not to use kernel.h
> > in the headers due to a full mess behind it.
>
> Can you then please write a commit message that matches what this is
> actually doing instead of mentioning a problem that doesn't seem to
> exist?
Sure, thanks for review!
--
With Best Regards,
Andy Shevchenko
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2022-01-04 13:49 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2021-12-22 16:55 [PATCH v1 1/1] KVM: arm64: vgic: Replace kernel.h with the necessary inclusions Andy Shevchenko
2021-12-22 18:09 ` Marc Zyngier
2021-12-22 18:25 ` Andy Shevchenko
2021-12-22 19:14 ` Andy Shevchenko
2022-01-04 13:44 ` Marc Zyngier
2022-01-04 13:45 ` Andy Shevchenko
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).