From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id B84E4C433EF for ; Tue, 14 Dec 2021 08:53:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Subject:Cc:To:From:Message-ID:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=AghLk8CTVB1MJCTjtdH9J4Cw8x5/nw/gfRqrk3zn2l8=; b=ljZ1eX3YeRT/s3 BS4/zOsTBV6y10GCdzCTyifV7+qB4xcNo4hBz8KhFNPQ1hqCpqMKybajkeO8QzYJcCVohuBDsyXkQ 6VZglSSNGgmJAJUaLskW6RsOereaEWeooWffyFWIH7bgqn9Q+BbW/aeecsVskZGVLxN0YplUTlC41 ViyJBdFRdUrvUiEAtK60+lWHjrIPWWPcSXIRTk36GOCOvjsoslRz+O0kpvo6p2c11cWRb1hRuvCEc DPx0PA8IeOdWq9DfOPlfHDwM2HOqjf/EqUUEkamd0QBF681E+Bet0SC9MTATo0h34iM+IinrpSLO2 Pl18iZWa9wdRhVG97B4Q==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mx3XX-00D7NS-0g; Tue, 14 Dec 2021 08:52:03 +0000 Received: from ams.source.kernel.org ([2604:1380:4601:e00::1]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mx3XN-00D7LX-8z for linux-arm-kernel@lists.infradead.org; Tue, 14 Dec 2021 08:51:55 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id E62FEB81803; Tue, 14 Dec 2021 08:51:51 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id B52FCC34601; Tue, 14 Dec 2021 08:51:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1639471910; bh=4QFkLIeG6dSbpdQ5ZnfEFBX1M1IgL3C5kDcWO3o8vhk=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=Gvx2YkAQ4toii5I+KUW+NH22TZv2b6sc4fXAanNXAENtZTLlE2TlQNfdxn4Fuuh6C YEEpxZ6x4MCmAD7K5QiPnB5tXRLVKH3N0BwPRwgNMyAJtIxQJSpmCLE6FtMVI1eVbC MyBULFOJppgzQI5OpL8L6a3fbNCHH/T6ApYE3K5v2I/iVU3HD7c77/75JowaQK7DPo uspPFk5AevMeKsl9ZjzY6WoRHPtWENojl9XvnGkMz3W7NiWElOaoutQWc7qGRSl2Rz VtC7i3qpiC03w7BFL0YSIIQmjckRh0Sifa02Nk4bCYiE0id65L6BY4Z+NQyfiEaLV2 9sZnCsvJ64Xyw== Received: from cfbb000407.r.cam.camfibre.uk ([185.219.108.64] helo=why.misterjones.org) by disco-boy.misterjones.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1mx3XI-00C0AS-Eq; Tue, 14 Dec 2021 08:51:48 +0000 Date: Tue, 14 Dec 2021 08:51:47 +0000 Message-ID: <87ilvrk1r0.wl-maz@kernel.org> From: Marc Zyngier To: Vladimir Oltean Cc: devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Rob Herring , Shawn Guo , Li Yang , Biwen Li , Zhiqiang Hou , Kurt Kanzenbach , Rasmus Villemoes Subject: Re: [RFC PATCH devicetree 00/10] Do something about ls-extirq interrupt-map breakage In-Reply-To: <20211214013800.2703568-1-vladimir.oltean@nxp.com> References: <20211214013800.2703568-1-vladimir.oltean@nxp.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/27.1 (x86_64-pc-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") X-SA-Exim-Connect-IP: 185.219.108.64 X-SA-Exim-Rcpt-To: vladimir.oltean@nxp.com, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, robh+dt@kernel.org, shawnguo@kernel.org, leoyang.li@nxp.com, biwen.li@nxp.com, Zhiqiang.Hou@nxp.com, kurt@linutronix.de, linux@rasmusvillemoes.dk X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20211214_005153_639037_853FEF59 X-CRM114-Status: GOOD ( 26.30 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, 14 Dec 2021 01:37:50 +0000, Vladimir Oltean wrote: > > Currently the ls-extirq driver's use of the "interrupt-map" property is > double-broken: > - once by Rob Herring's commit 869f0ec048dc ("arm64: dts: freescale: Fix > 'interrupt-map' parent address cells") > - twice by Marc Zyngier's commit 041284181226 ("of/irq: Allow matching > of an interrupt-map local to an interrupt controller"), later revised, > not very elegantly, through commit de4adddcbcc2 ("of/irq: Add a quirk Elegance is, I'm afraid to say, bloody overrated when dealing with this sort of crap. > for controllers with their own definition of interrupt-map"). So this > part works but we're on an offender list. Define 'part works'. Either it does, or it doesn't. There is no middle ground here. > > Mark suggests that the problem may lie with the ls-extirq driver, and > its interpretation of the "interrupt-map" property, to be exact. s/Mark/Marc/, unless you are talking about someone else (who?). > > This set of changes attempts to make the problem smaller by using a > vendor-specific name for the property, and reverts Rob's patch because > similarity with "interrupt-map" isn't actually a desirable feature after > all, it seems. > > Vladimir Oltean (10): > irqchip/ls-extirq: rename "interrupt-map" OF property to > "fsl,extirq-map" > Revert "arm64: dts: freescale: Fix 'interrupt-map' parent address > cells" > dt-bindings: ls-extirq: replace "interrupt-map" documentation with > "fsl,extirq-map" > arm64: dts: ls1043a: rename the "interrupt-map" of the extirq node to > "fsl,extirq-map" > arm64: dts: ls1046a: rename the "interrupt-map" of the extirq node to > "fsl,extirq-map" > arm64: dts: ls1088a: rename the "interrupt-map" of the extirq node to > "fsl,extirq-map" > arm64: dts: ls208xa: rename the "interrupt-map" of the extirq node to > "fsl,extirq-map" > arm64: dts: lx2160a: rename the "interrupt-map" of the extirq node to > "fsl,extirq-map" > ARM: dts: ls1021a: rename the "interrupt-map" of the extirq node to > "fsl,extirq-map" > dt-bindings: ls-extirq: add a YAML schema for the validator > > .../interrupt-controller/fsl,ls-extirq.txt | 53 --------- > .../interrupt-controller/fsl,ls-extirq.yaml | 110 ++++++++++++++++++ > arch/arm/boot/dts/ls1021a.dtsi | 3 +- > .../arm64/boot/dts/freescale/fsl-ls1043a.dtsi | 3 +- > .../arm64/boot/dts/freescale/fsl-ls1046a.dtsi | 3 +- > .../arm64/boot/dts/freescale/fsl-ls1088a.dtsi | 27 +++-- > .../arm64/boot/dts/freescale/fsl-ls208xa.dtsi | 27 +++-- > .../arm64/boot/dts/freescale/fsl-lx2160a.dtsi | 27 +++-- > drivers/irqchip/irq-ls-extirq.c | 12 +- > 9 files changed, 161 insertions(+), 104 deletions(-) > delete mode 100644 Documentation/devicetree/bindings/interrupt-controller/fsl,ls-extirq.txt > create mode 100644 Documentation/devicetree/bindings/interrupt-controller/fsl,ls-extirq.yaml This is totally pointless. These machines have been in the wild for years, and existing DTs will be there *forever*. The very notion of 'backporting' DT changes is totally ludicrous when it is some firmware (ATF, u-boot, or something else *that isn't under your control*) that provides the DT. It also breaks backward compatibility (old kernel with new DT), which is just as important. Why do you think I went the elegance-deprived route and added a quirk? So no, I'm not taking the irqchip changes, as most of this churn serves no purpose. The revert of 869f0ec048dc is the only thing that makes some sense. M. -- Without deviation from the norm, progress is not possible. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel