From: Kurt Kanzenbach <kurt.kanzenbach@linutronix.de>
To: Ong Boon Leong <boon.leong.ong@intel.com>,
Giuseppe Cavallaro <peppe.cavallaro@st.com>,
Alexandre Torgue <alexandre.torgue@st.com>,
Jose Abreu <joabreu@synopsys.com>,
"David S . Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>,
Maxime Coquelin <mcoquelin.stm32@gmail.com>,
alexandre.torgue@foss.st.com
Cc: netdev@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com,
linux-arm-kernel@lists.infradead.org,
Ong Boon Leong <boon.leong.ong@intel.com>,
Sebastian Andrzej Siewior <bigeasy@linutronix.de>
Subject: Re: [PATCH net-next 2/2] net: stmmac: add tc flower filter for EtherType matching
Date: Fri, 10 Dec 2021 10:35:54 +0100 [thread overview]
Message-ID: <87ilvwzts5.fsf@kurt> (raw)
In-Reply-To: <20211209151631.138326-3-boon.leong.ong@intel.com>
[-- Attachment #1.1: Type: text/plain, Size: 993 bytes --]
Hi BL,
On Thu Dec 09 2021, Ong Boon Leong wrote:
> This patch adds basic support for EtherType RX frame steering for
> LLDP and PTP using the hardware offload capabilities.
Maybe add an example here for users?
|tc filter add dev eno1 parent ffff: protocol 0x88f7 flower hw_tc 4
|tc filter add dev eno1 parent ffff: protocol 0x88cc flower hw_tc 4
>
> Signed-off-by: Ong Boon Leong <boon.leong.ong@intel.com>
Something is not quite correct. The use of the etype variable generates
new warnings. For instance:
|drivers/net/ethernet/stmicro/stmmac/stmmac_tc.c:768:25: warning: restricted __be16 degrades to integer
|drivers/net/ethernet/stmicro/stmmac/stmmac_tc.c:768:25: warning: restricted __be16 degrades to integer
|drivers/net/ethernet/stmicro/stmmac/stmmac_tc.c:817:22: warning: restricted __be16 degrades to integer
|drivers/net/ethernet/stmicro/stmmac/stmmac_tc.c:817:22: warning: restricted __be16 degrades to integer
However, the steering works as expected. Thanks!
Thanks,
Kurt
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 873 bytes --]
[-- Attachment #2: Type: text/plain, Size: 176 bytes --]
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2021-12-10 9:37 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-09 15:16 [PATCH net-next 0/2] net: stmmac: add EthType Rx Frame steering Ong Boon Leong
2021-12-09 15:16 ` [PATCH net-next 1/2] net: stmmac: fix tc flower deletion for VLAN priority Rx steering Ong Boon Leong
2021-12-10 9:25 ` Kurt Kanzenbach
2021-12-11 13:51 ` Ong, Boon Leong
2021-12-10 16:30 ` Yannick Vignon
2021-12-11 13:59 ` Ong, Boon Leong
2021-12-09 15:16 ` [PATCH net-next 2/2] net: stmmac: add tc flower filter for EtherType matching Ong Boon Leong
2021-12-10 9:35 ` Kurt Kanzenbach [this message]
2021-12-10 10:10 ` Kurt Kanzenbach
2021-12-10 11:57 ` Sebastian Andrzej Siewior
2021-12-11 14:03 ` Ong, Boon Leong
2021-12-11 14:02 ` Ong, Boon Leong
2021-12-10 11:57 ` [PATCH net-next 0/2] net: stmmac: add EthType Rx Frame steering Vladimir Oltean
2021-12-10 19:38 ` Jakub Kicinski
2021-12-10 23:57 ` Nambiar, Amritha
[not found] ` <20211210185517.30d27cfd@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>
2021-12-20 5:33 ` Ong, Boon Leong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87ilvwzts5.fsf@kurt \
--to=kurt.kanzenbach@linutronix.de \
--cc=alexandre.torgue@foss.st.com \
--cc=alexandre.torgue@st.com \
--cc=bigeasy@linutronix.de \
--cc=boon.leong.ong@intel.com \
--cc=davem@davemloft.net \
--cc=joabreu@synopsys.com \
--cc=kuba@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-stm32@st-md-mailman.stormreply.com \
--cc=mcoquelin.stm32@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=peppe.cavallaro@st.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).