* [PATCH] ARM: pxa3xx: enable external wakeup pins
@ 2018-05-24 20:40 Daniel Mack
2018-05-25 20:22 ` Robert Jarzmik
0 siblings, 1 reply; 4+ messages in thread
From: Daniel Mack @ 2018-05-24 20:40 UTC (permalink / raw)
To: linux-arm-kernel
The PXA3xx SoCs feature dedicated pins for wakeup functionality. These pins
have no alternate functions, so let's always enable them as wakeup source on
DT enabled boards. The WAKEUP1 pin is only available on PXA320.
Signed-off-by: Daniel Mack <daniel@zonque.org>
---
arch/arm/mach-pxa/pxa3xx.c | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/arch/arm/mach-pxa/pxa3xx.c b/arch/arm/mach-pxa/pxa3xx.c
index 2a5044dd463e..9e05f92cd97a 100644
--- a/arch/arm/mach-pxa/pxa3xx.c
+++ b/arch/arm/mach-pxa/pxa3xx.c
@@ -442,6 +442,10 @@ static int __init pxa3xx_init(void)
pxa3xx_init_pm();
+ enable_irq_wake(IRQ_WAKEUP0);
+ if (cpu_is_pxa320())
+ enable_irq_wake(IRQ_WAKEUP1);
+
register_syscore_ops(&pxa_irq_syscore_ops);
register_syscore_ops(&pxa3xx_mfp_syscore_ops);
--
2.14.3
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [PATCH] ARM: pxa3xx: enable external wakeup pins
2018-05-24 20:40 [PATCH] ARM: pxa3xx: enable external wakeup pins Daniel Mack
@ 2018-05-25 20:22 ` Robert Jarzmik
2018-05-25 20:23 ` Daniel Mack
0 siblings, 1 reply; 4+ messages in thread
From: Robert Jarzmik @ 2018-05-25 20:22 UTC (permalink / raw)
To: linux-arm-kernel
Daniel Mack <daniel@zonque.org> writes:
> The PXA3xx SoCs feature dedicated pins for wakeup functionality. These pins
> have no alternate functions, so let's always enable them as wakeup source on
> DT enabled boards. The WAKEUP1 pin is only available on PXA320.
>
> Signed-off-by: Daniel Mack <daniel@zonque.org>
That looks correct. Is it tested on any board ?
Cheers.
--
Robert
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH] ARM: pxa3xx: enable external wakeup pins
2018-05-25 20:22 ` Robert Jarzmik
@ 2018-05-25 20:23 ` Daniel Mack
2018-05-25 20:41 ` Robert Jarzmik
0 siblings, 1 reply; 4+ messages in thread
From: Daniel Mack @ 2018-05-25 20:23 UTC (permalink / raw)
To: linux-arm-kernel
On Friday, May 25, 2018 10:22 PM, Robert Jarzmik wrote:
> Daniel Mack <daniel@zonque.org> writes:
>
>> The PXA3xx SoCs feature dedicated pins for wakeup functionality. These pins
>> have no alternate functions, so let's always enable them as wakeup source on
>> DT enabled boards. The WAKEUP1 pin is only available on PXA320.
>>
>> Signed-off-by: Daniel Mack <daniel@zonque.org>
> That looks correct. Is it tested on any board ?
Yup, on a PXA303 based one.
Thanks,
Daniel
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH] ARM: pxa3xx: enable external wakeup pins
2018-05-25 20:23 ` Daniel Mack
@ 2018-05-25 20:41 ` Robert Jarzmik
0 siblings, 0 replies; 4+ messages in thread
From: Robert Jarzmik @ 2018-05-25 20:41 UTC (permalink / raw)
To: linux-arm-kernel
Daniel Mack <daniel@zonque.org> writes:
> On Friday, May 25, 2018 10:22 PM, Robert Jarzmik wrote:
>> Daniel Mack <daniel@zonque.org> writes:
>>
>>> The PXA3xx SoCs feature dedicated pins for wakeup functionality. These pins
>>> have no alternate functions, so let's always enable them as wakeup source on
>>> DT enabled boards. The WAKEUP1 pin is only available on PXA320.
>>>
>>> Signed-off-by: Daniel Mack <daniel@zonque.org>
>> That looks correct. Is it tested on any board ?
>
> Yup, on a PXA303 based one.
Great.
Queued into pxa/for-next.
Cheers.
--
Robert
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2018-05-25 20:41 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-05-24 20:40 [PATCH] ARM: pxa3xx: enable external wakeup pins Daniel Mack
2018-05-25 20:22 ` Robert Jarzmik
2018-05-25 20:23 ` Daniel Mack
2018-05-25 20:41 ` Robert Jarzmik
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox