From: gregory.clement@free-electrons.com (Gregory CLEMENT)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 2/5] irqchip: armada-370-xp: prepare additions to armada_xp_mpic_secondary_init()
Date: Tue, 20 Oct 2015 16:00:24 +0200 [thread overview]
Message-ID: <87io61ej2f.fsf@free-electrons.com> (raw)
In-Reply-To: <1445347435-2333-3-git-send-email-thomas.petazzoni@free-electrons.com> (Thomas Petazzoni's message of "Tue, 20 Oct 2015 15:23:52 +0200")
Hi Thomas,
On mar., oct. 20 2015, Thomas Petazzoni <thomas.petazzoni@free-electrons.com> wrote:
> As a preparation to adding more code in
> armada_xp_mpic_secondary_init(), this commit slightly refactors the
> current function to bail out early if we're not handling the actions
> of interest.
>
> Signed-off-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
Acked-by: Gregory CLEMENT <gregory.clement@free-electrons.com>
Thanks,
Gregory
> ---
> drivers/irqchip/irq-armada-370-xp.c | 9 +++++----
> 1 file changed, 5 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/irqchip/irq-armada-370-xp.c b/drivers/irqchip/irq-armada-370-xp.c
> index 655cb96..f5afe81 100644
> --- a/drivers/irqchip/irq-armada-370-xp.c
> +++ b/drivers/irqchip/irq-armada-370-xp.c
> @@ -377,10 +377,11 @@ static void armada_mpic_send_doorbell(const struct cpumask *mask,
> static int armada_xp_mpic_secondary_init(struct notifier_block *nfb,
> unsigned long action, void *hcpu)
> {
> - if (action == CPU_STARTING || action == CPU_STARTING_FROZEN) {
> - armada_xp_mpic_perf_init();
> - armada_xp_mpic_smp_cpu_init();
> - }
> + if (action != CPU_STARTING && action != CPU_STARTING_FROZEN)
> + return NOTIFY_OK;
> +
> + armada_xp_mpic_perf_init();
> + armada_xp_mpic_smp_cpu_init();
>
> return NOTIFY_OK;
> }
> --
> 2.6.2
>
--
Gregory Clement, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com
next prev parent reply other threads:[~2015-10-20 14:00 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-20 13:23 [PATCH 0/5] Fix regression introduced by set_irq_flags() removal Thomas Petazzoni
2015-10-20 13:23 ` [PATCH 1/5] kernel: irq: implement is_enabled_percpu_irq() Thomas Petazzoni
2015-10-20 13:23 ` [PATCH 2/5] irqchip: armada-370-xp: prepare additions to armada_xp_mpic_secondary_init() Thomas Petazzoni
2015-10-20 14:00 ` Gregory CLEMENT [this message]
2015-10-20 13:23 ` [PATCH 3/5] irqchip: armada-370-xp: re-enable per-CPU interrupts at resume time Thomas Petazzoni
2015-10-20 13:46 ` Gregory CLEMENT
2015-10-20 13:50 ` Thomas Petazzoni
2015-10-25 21:22 ` Marcin Wojtas
2015-10-26 0:10 ` Thomas Petazzoni
2015-10-26 4:35 ` Marcin Wojtas
2015-10-26 5:09 ` Thomas Petazzoni
2015-10-26 7:06 ` Marcin Wojtas
2015-10-26 8:27 ` Thomas Petazzoni
2015-10-20 13:23 ` [PATCH 4/5] irqchip: armada-370-xp: re-order register definitions Thomas Petazzoni
2015-10-20 13:55 ` Gregory CLEMENT
2015-10-20 13:23 ` [PATCH 5/5] irqchip: armada-370-xp: document the overall driver logic Thomas Petazzoni
2015-10-20 13:59 ` Gregory CLEMENT
2015-10-20 14:00 ` Thomas Petazzoni
2015-10-20 14:07 ` Jason Cooper
2015-10-20 14:04 ` [PATCH 0/5] Fix regression introduced by set_irq_flags() removal Jason Cooper
2015-10-20 14:08 ` Thomas Petazzoni
2015-10-20 14:17 ` Russell King - ARM Linux
2015-10-20 14:23 ` Thomas Petazzoni
2015-10-20 19:24 ` Thomas Gleixner
2015-10-22 8:01 ` Thomas Gleixner
2015-10-20 19:23 ` Thomas Gleixner
2015-10-21 13:48 ` [PATCH] irqchip: irq-armada-370-xp: fix regression by clearing IRQ_NOAUTOEN Thomas Petazzoni
2015-10-21 14:41 ` Jason Cooper
2015-10-21 13:49 ` [PATCH 0/5] Fix regression introduced by set_irq_flags() removal Thomas Petazzoni
2015-11-11 8:26 ` Thomas Petazzoni
2015-11-13 20:11 ` Thomas Gleixner
2015-12-04 11:03 ` Thomas Petazzoni
2015-12-05 17:24 ` Thomas Gleixner
2015-12-06 9:28 ` Thomas Gleixner
2015-12-08 8:58 ` Thomas Petazzoni
2015-12-08 10:54 ` Thomas Gleixner
2017-02-24 16:56 ` Thomas Petazzoni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87io61ej2f.fsf@free-electrons.com \
--to=gregory.clement@free-electrons.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).