From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 34AE4CA0EE4 for ; Mon, 18 Aug 2025 17:32:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Type:MIME-Version: References:In-Reply-To:Subject:Cc:To:From:Message-ID:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=t13rr93j+EGa6/OAJHgd6dNBXT6msWTv/pfiYHMINIA=; b=lh/knosU4wRFdAV/jqiZUdzeV6 lKs9JtSW3VQfpASwRnPAJ/g1aMmfxUzOrjv/m8q/ibBAOvTsMN3l4Zlk32rxfjcPXald3p0TJWLWX frbYGOx9cWTZAJiQqsEXxRiQBWGPauhBK84s26DWI+BFK6Msu7V+yYst0l548ofUjRxgBnqFe8RIX LBUeDOBRsiUKcRg961O6z1HYKvB7iP/uIcQ9+/QXIvYg/v/Tphp8/x8KWHtXe6Q9jgMAJS7/fCrtN qM7FsxqHOMs7uAlJLtSkSl1ublbrD2Okcg9jbaCSF87eKHey/vJ4w2RovE7kwcDrxM3mwmlns+0IQ nDWXN9cw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98.2 #2 (Red Hat Linux)) id 1uo3if-00000008Aok-2MME; Mon, 18 Aug 2025 17:32:29 +0000 Received: from tor.source.kernel.org ([172.105.4.254]) by bombadil.infradead.org with esmtps (Exim 4.98.2 #2 (Red Hat Linux)) id 1uo24e-00000007x1i-05t3 for linux-arm-kernel@lists.infradead.org; Mon, 18 Aug 2025 15:47:04 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by tor.source.kernel.org (Postfix) with ESMTP id 33257600AE; Mon, 18 Aug 2025 15:47:03 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 85585C4CEEB; Mon, 18 Aug 2025 15:47:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1755532022; bh=W6AmuSmN9qaWu3EIFd4eq8W4sSZ6dygxL+NWbHPYrzc=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=e2aSOb3DJlmkn7hgl5ndvqTbohd07H4hP00GZjm+2z+su04i8FSpfejqd3OOkaYkW ne8R2t8XogWY46TX2nJd1iUl8+tV5eUeLk3QD76R4f0pMnzaED62uuxeNmF5bGr30d ryl4y+GI4y0uFapRJmBjm2AUD1DrfMtLDtlwbaIGH1wsMt8APOULhfOQiXRVqzDWgm Y5mI6UcP5ynpoVoDdzpSD0ajG0QIXhqAYHlhQZXGrmKHjxFV2hK3fBIE7w9Gexuc6I 3Q8beDL32asIGC1xDvUZ3bUzh+YQ1hTPc7zEtK1Yf2OXwuRFV+dhkRwUKjN+C1ojqX rqKIs184FnKFg== Received: from host86-149-246-145.range86-149.btcentralplus.com ([86.149.246.145] helo=lobster-girl.misterjones.org) by disco-boy.misterjones.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1uo24a-008fb5-Co; Mon, 18 Aug 2025 16:47:00 +0100 Date: Mon, 18 Aug 2025 16:46:59 +0100 Message-ID: <87jz30my30.wl-maz@kernel.org> From: Marc Zyngier To: Anshuman Khandual Cc: linux-arm-kernel@lists.infradead.org, Catalin Marinas , Will Deacon , Oliver Upton , Mark Brown , Ryan Roberts , kvmarm@lists.linux.dev, linux-kernel@vger.kernel.org Subject: Re: [PATCH 2/4] arm64/sysreg: Replace TCR_EL1 field macros In-Reply-To: <20250818045759.672408-3-anshuman.khandual@arm.com> References: <20250818045759.672408-1-anshuman.khandual@arm.com> <20250818045759.672408-3-anshuman.khandual@arm.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/30.1 (aarch64-unknown-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII X-SA-Exim-Connect-IP: 86.149.246.145 X-SA-Exim-Rcpt-To: anshuman.khandual@arm.com, linux-arm-kernel@lists.infradead.org, catalin.marinas@arm.com, will@kernel.org, oliver.upton@linux.dev, broonie@kernel.org, ryan.roberts@arm.com, kvmarm@lists.linux.dev, linux-kernel@vger.kernel.org X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, 18 Aug 2025 05:57:57 +0100, Anshuman Khandual wrote: > > This just replaces all used TCR_EL1 field macros with tools sysreg variant > based fields and subsequently drops them from the header (pgtable-hwdef.h). > While here, also drop all the unused TCR_XXX macros from the header. > > Cc: Catalin Marinas > Cc: Will Deacon > Cc: Marc Zyngier > Cc: Mark Brown > Cc: kvmarm@lists.linux.dev > Cc: linux-arm-kernel@lists.infradead.org > Cc: linux-kernel@vger.kernel.org > Signed-off-by: Anshuman Khandual > --- > arch/arm64/include/asm/assembler.h | 6 +- > arch/arm64/include/asm/cputype.h | 2 +- > arch/arm64/include/asm/kvm_arm.h | 28 +++--- > arch/arm64/include/asm/kvm_nested.h | 6 +- > arch/arm64/include/asm/mmu_context.h | 4 +- > arch/arm64/include/asm/pgtable-hwdef.h | 107 +++------------------ > arch/arm64/include/asm/pgtable-prot.h | 2 +- > arch/arm64/kernel/cpufeature.c | 4 +- > arch/arm64/kernel/pi/map_kernel.c | 8 +- > arch/arm64/kernel/vmcore_info.c | 2 +- > arch/arm64/kvm/arm.c | 6 +- > arch/arm64/kvm/at.c | 48 ++++----- > arch/arm64/kvm/hyp/include/hyp/switch.h | 2 +- > arch/arm64/kvm/hyp/include/hyp/sysreg-sr.h | 2 +- > arch/arm64/kvm/hyp/nvhe/switch.c | 2 +- > arch/arm64/kvm/hyp/nvhe/tlb.c | 2 +- > arch/arm64/kvm/hyp/vhe/tlb.c | 2 +- > arch/arm64/kvm/nested.c | 8 +- > arch/arm64/kvm/pauth.c | 12 +-- > arch/arm64/mm/proc.S | 29 +++--- > tools/arch/arm64/include/asm/cputype.h | 2 +- > 21 files changed, 101 insertions(+), 183 deletions(-) [...] > diff --git a/arch/arm64/kvm/arm.c b/arch/arm64/kvm/arm.c > index 888f7c7abf54..b47d6d530e57 100644 > --- a/arch/arm64/kvm/arm.c > +++ b/arch/arm64/kvm/arm.c > @@ -2000,10 +2000,10 @@ static void __init cpu_prepare_hyp_mode(int cpu, u32 hyp_va_bits) > > tcr = read_sysreg(tcr_el1); > if (cpus_have_final_cap(ARM64_KVM_HVHE)) { > - tcr &= ~(TCR_HD | TCR_HA | TCR_A1 | TCR_T0SZ_MASK); > - tcr |= TCR_EPD1_MASK; > + tcr &= ~(TCR_EL1_HD | TCR_EL1_HA | TCR_EL1_A1 | TCR_EL1_T0SZ_MASK); > + tcr |= TCR_EL1_EPD1_MASK; Except that none of that code is about EL1. At all. > } else { > - unsigned long ips = FIELD_GET(TCR_IPS_MASK, tcr); > + unsigned long ips = FIELD_GET(TCR_EL1_IPS_MASK, tcr); > > tcr &= TCR_EL2_MASK; > tcr |= TCR_EL2_RES1 | FIELD_PREP(TCR_EL2_PS_MASK, ips); > diff --git a/arch/arm64/kvm/at.c b/arch/arm64/kvm/at.c > index 0e5610533949..5f0f10ef38f0 100644 > --- a/arch/arm64/kvm/at.c > +++ b/arch/arm64/kvm/at.c > @@ -134,8 +134,8 @@ static int setup_s1_walk(struct kvm_vcpu *vcpu, struct s1_walk_info *wi, > tbi = (wi->regime == TR_EL2 ? > FIELD_GET(TCR_EL2_TBI, tcr) : > (va55 ? > - FIELD_GET(TCR_TBI1, tcr) : > - FIELD_GET(TCR_TBI0, tcr))); > + FIELD_GET(TCR_EL1_TBI1, tcr) : > + FIELD_GET(TCR_EL1_TBI0, tcr))); This is the reason number one why I dislike this patch. Here, we deal with both the EL1&0 *and* the EL2&0 translation regimes. And I left the original definition *on purpose* so that nobody would read this code as being EL1-only. Now, you will glance over it with warm fuzzy feeling that you know what this is about -- purely EL1. And that's what bugs are made of. Of course, nothing changed functionally. But is it better? No. M. -- Jazz isn't dead. It just smells funny.