From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 05215C47422 for ; Thu, 18 Jan 2024 13:43:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-ID:Date:References :In-Reply-To:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=fBX+dRlTQZtXZmgn3bIxugKXo03c1vkHe8KrSJbUlh4=; b=XVRGSpG8EeVu/J uy/tKH6n+tMcA/a6UedLVTqfe7r7BZMsTsU5T7OD6U+pfsgEfzGsQ5YPECFwQYdEZJ+QSAjpvMcXE cg3LvDSr7ACxN3av5a/86BITo/NTeV2QSHQdzuEMsohWf22Zv4NYW8KbEyAdtWxLD0A5LmnMVzUuU sAcY7MdauLsVQtlrgbxVhJ7GqcqBFFblXo4wFSII1SjOssf2TFpdR8xNENRN0d/71ITnmtpMbqCg4 Lk1/YoP3kTOg5tD09F43EUCQm3Arg5jSvqoWmAwnAELXYtlpAlgR2yclkNbHiEXAiiOid04g6X3lV iU32pGDrFkosdsaLqgiA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1rQSg0-002sNU-39; Thu, 18 Jan 2024 13:43:24 +0000 Received: from eggs.gnu.org ([2001:470:142:3::10]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1rQSfy-002sMg-07 for linux-arm-kernel@lists.infradead.org; Thu, 18 Jan 2024 13:43:23 +0000 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rQSfn-0004uE-Cn; Thu, 18 Jan 2024 08:43:11 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:Date:References:In-Reply-To:Subject:To: From; bh=efuuIR75Ne4gKzieuxB6GvMLRG+XlSIaY1YCAUIZ41I=; b=Cp+PxdUJgklim1u1yQzh lAjlcVHem0BTU2KRX7KFjrght1MTX21VTE3dmGgvxnfzdkJLElplkm9kPTbpY66pVtoHeyIhkVnkw 94O3lDor6XvajCmWc0/MjWDvhXUCoGx65vqOEJipZkM3k5Eyvh+lV53ssImg1I9ldXLsPbLJ/oc01 taG0QsaKxKkzk4/WYmVbEiyiO5V4pR/5ZYuLSb0C5BhU50iizWlpDKqJEVZGkdoJQEQ2SIdSVUpsU 4AA8RiRj+mdgBo3FG/Txlv+ugq12eBqJdMV/CyAN/kHUqu2+yUk389/9BJ+zFJSGcLO8Ot3bX403Q vfrnyndX3/nCyQ==; From: Mathieu Othacehe To: Conor Dooley Cc: Primoz Fiser , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , NXP Linux Team , Li Yang , Stefan Wahren , Christoph Stoidner , Wadim Egorov , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, upstream@lists.phytec.de Subject: Re: [PATCH v2 2/2] arm64: dts: imx93-phycore-segin: Add Phytec i.MX93 Segin In-Reply-To: <20240118-regretful-viewer-8d7dfc7a0802@spud> (Conor Dooley's message of "Thu, 18 Jan 2024 10:19:23 +0000") References: <20240117074911.7425-1-othacehe@gnu.org> <20240117074911.7425-3-othacehe@gnu.org> <20240118-regretful-viewer-8d7dfc7a0802@spud> Date: Thu, 18 Jan 2024 14:43:07 +0100 Message-ID: <87jzo6vjtg.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240118_054322_200976_953712F6 X-CRM114-Status: GOOD ( 11.37 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hey, > Please do not order properties alphabetically. Instead, please read > the new documentation on property ordering that makes explicit what > has just been convention until now: > https://git.kernel.org/pub/scm/linux/kernel/git/robh/linux.git/tree/Documentation/devicetree/bindings/dts-coding-style.rst?h=for-next&id=83a368a3fc8ae8538bccb713dc0cae9eacc04790#n112 Thanks for the link. I have a question though. Regarding that section: --8<---------------cut here---------------start------------->8--- /* SD-Card */ &usdhc2 { pinctrl-names = "default", "state_100mhz", "state_200mhz"; pinctrl-0 = <&pinctrl_usdhc2_default>, <&pinctrl_usdhc2_cd>; pinctrl-1 = <&pinctrl_usdhc2_100mhz>, <&pinctrl_usdhc2_cd>; pinctrl-2 = <&pinctrl_usdhc2_200mhz>, <&pinctrl_usdhc2_cd>; bus-width = <4>; cd-gpios = <&gpio3 00 GPIO_ACTIVE_LOW>; no-sdio; no-mmc; vmmc-supply = <®_usdhc2_vmmc>; status = "okay"; }; --8<---------------cut here---------------end--------------->8--- The documentation states: --8<---------------cut here---------------start------------->8--- Order of Properties in Device Node ---------------------------------- The following order of properties in device nodes is preferred: 1. "compatible" 2. "reg" 3. "ranges" 4. Standard/common properties (defined by common bindings, e.g. without vendor-prefixes) 5. Vendor-specific properties 6. "status" (if applicable) 7. Child nodes, where each node is preceded with a blank line --8<---------------cut here---------------end--------------->8--- All of the properties in my example are falling into the "4" category I guess, except for "status" that should come last. Now, how am I supposed to order those properties? I had a look to other IMX device trees and it is hard to establish a pattern. Pinctrl first, then alphabetical order? Anything else? Thanks for the guidance, Mathieu _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel