From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 8268FC46CD2 for ; Tue, 9 Jan 2024 09:18:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-ID:In-Reply-To: Date:References:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=2TDRO+iwXOuPURZIaMQi02vSbbONHxDXLIHyCMBiB30=; b=R7j7YH1M0grcu2 HZH892yy7hM1j4OrBb3cpZ9HqJSIBbz4kqDR9GxIeA0pA//zPg+Aaf0ru4tOibxLUrFQSGEpREKHY JroKnVNIhSkD6ZKDDbZ8a1VCcM+0IL8ZixcijR7W2+/6sOGrW/YrvKbOb06KyId6nH9+eyyjALYYZ 2SIz73cG6rdb/ciec2mHrUo93m4XNmPwNA/RmIWSaQYyp40C3a6vsUECm/SFJEvs7kO9gxJ5D6EdP byxYma5E34sgJjObwFH7IpF4YFrEQGVOiFMfGUzUtCMYvm3miQQ5DYy6l7GG9IveZs37PNFeNPMLX grL2kzCyyWMjr2dDfpKA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1rN8FW-007TbH-0L; Tue, 09 Jan 2024 09:18:18 +0000 Received: from dfw.source.kernel.org ([2604:1380:4641:c500::1]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1rN8FS-007TYa-27 for linux-arm-kernel@lists.infradead.org; Tue, 09 Jan 2024 09:18:17 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id EDCC761359; Tue, 9 Jan 2024 09:18:13 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 83CBBC433F1; Tue, 9 Jan 2024 09:18:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1704791893; bh=HPNvwBlDoURqcR228aqjUvaE1RRrnKS4myuXXAyaAog=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=QgUePAhVgYTKdCDir8lW5xgFglt6GgowMR6umaf1kI3jYuBEyAmb3yDBh9xym6xHX LYtGNIHNc69u/mOhR53YaK9NOoKsPWFj+jU3O2j3Np73y601KPh5DUUOqnWcRj4Lhj XpMCreey5P1dYUlyEXvoFoTiUDnlH7/pyH//6WxJS9X9AhfbmWaWjhZhCXMSxaHivi 1BTV9Sbg1gUGII3VJS46zGejC9vFQtb3DF3whKvRqSF7hHkWlR8y9B8X7CXGLMMaKx Ev1vbmAKdBil9IiXRIqBic3d7NkU5RMgjwhZnuy35LAFMQ2jJUBDhkqGH49yuoq/Ph F1d1/82OwuaTA== From: Kalle Valo To: Jeff Johnson Cc: Bartosz Golaszewski , "David S . Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Bjorn Andersson , Konrad Dybcio , Catalin Marinas , Will Deacon , Bjorn Helgaas , Heiko Stuebner , Jernej Skrabec , Chris Morgan , Linus Walleij , Geert Uytterhoeven , Arnd Bergmann , Neil Armstrong , =?utf-8?Q?N=C3=ADcolas?= F . R . A . Prado , Marek Szyprowski , Peng Fan , Robert Richter , Dan Williams , Jonathan Cameron , Terry Bowman , Kuppuswamy Sathyanarayanan , Ilpo =?utf-8?Q?J=C3=A4rvinen?= , Huacai Chen , Alex Elder , Srini Kandagatla , Greg Kroah-Hartman , , , , , , , , Bartosz Golaszewski Subject: Re: [RFC 8/9] PCI/pwrseq: add a pwrseq driver for QCA6390 References: <20240104130123.37115-1-brgl@bgdev.pl> <20240104130123.37115-9-brgl@bgdev.pl> <15443d5d-6544-45d0-afeb-b23e6a041ecf@quicinc.com> Date: Tue, 09 Jan 2024 11:18:04 +0200 In-Reply-To: <15443d5d-6544-45d0-afeb-b23e6a041ecf@quicinc.com> (Jeff Johnson's message of "Fri, 5 Jan 2024 17:31:47 -0800") Message-ID: <87jzoizwz7.fsf@kernel.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240109_011814_793632_4515AEAB X-CRM114-Status: GOOD ( 20.69 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Jeff Johnson writes: > On 1/4/2024 5:01 AM, Bartosz Golaszewski wrote: >> diff --git a/drivers/pci/pcie/pwrseq/Kconfig b/drivers/pci/pcie/pwrseq/Kconfig >> index 010e31f432c9..f9fe555b8506 100644 >> --- a/drivers/pci/pcie/pwrseq/Kconfig >> +++ b/drivers/pci/pcie/pwrseq/Kconfig >> @@ -6,3 +6,14 @@ menuconfig PCIE_PWRSEQ >> help >> Say yes here to enable support for PCIe power sequencing >> drivers. >> + >> +if PCIE_PWRSEQ >> + >> +config PCIE_PWRSEQ_QCA6390 >> + tristate "PCIe Power Sequencing driver for QCA6390" >> + depends on ARCH_QCOM || COMPILE_TEST >> + help >> + Enable support for the PCIe power sequencing driver for the >> + ath11k module of the QCA6390 WLAN/BT chip. >> + >> +endif > > As I mentioned in the 5/9 patch I'm concerned that the current > definition of PCIE_PWRSEQ and PCIE_PWRSEQ_QCA6390 will effectively hide > the fact that QCA6390 may need additional configuration since the menu > item will only show up if you have already enabled PCIE_PWRSEQ. > Yes I see that these are set in the defconfig in 9/9 but I'm concerned > about the more generic case. > > I'm wondering if there should be a separate config QCA6390 within ath11k > which would then select PCIE_PWRSEQ and PCIE_PWRSEQ_QCA6390 Or is it possible to provide an optional dependency in Kconfig (I guess not)? Or what about mentioning about PCIE_PWRSEQ_QCA6390 in ATH11K_PCI help text? -- https://patchwork.kernel.org/project/linux-wireless/list/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel