From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.7 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 261B2C07E9A for ; Wed, 14 Jul 2021 10:25:34 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id DEAFF61362 for ; Wed, 14 Jul 2021 10:25:33 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org DEAFF61362 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Subject:Cc:To:From:Message-ID:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=1GZKVyXwtPyTnIItqpF9kiDD9TpWNuUzX6UkA/ZH9nc=; b=qc2slEfNjPU00y 93qRFwmHWARsB49Xh8JlXG4T16mlKO65+1SInzzANQKCBiz1kbrn5CKZ9ntaQjAflcKICCEP/BEEB McszCm2BNnLiuh3QYfkstjCuSN45Nzze0r8BSKyBgRMQaYeKc0HJvhlrXzRX1qnQtqT8xSJUcxfHW ryNdYQ5eI8zbhEyOMRItdnmKqeF5CZRUceL4zLyFYHRWTeC2xwlWvESpYbofnouNYwpiSRBUEbwFl MIRHWajUHNVF9s0Zmn7vf8s5RyuEYmFKXOj3O7WS3yb3+Hx3ZgQBo5yJeZByBUwM08t0Pek8UnhpY GxT1KqrtjUur4Yec5cKw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1m3c3b-00D7Lq-WE; Wed, 14 Jul 2021 10:24:00 +0000 Received: from mail.kernel.org ([198.145.29.99]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1m3c3W-00D7L1-V6 for linux-arm-kernel@lists.infradead.org; Wed, 14 Jul 2021 10:23:57 +0000 Received: from disco-boy.misterjones.org (disco-boy.misterjones.org [51.254.78.96]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 6BE3361362; Wed, 14 Jul 2021 10:23:54 +0000 (UTC) Received: from sofa.misterjones.org ([185.219.108.64] helo=why.misterjones.org) by disco-boy.misterjones.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1m3c3U-00DGUt-J0; Wed, 14 Jul 2021 11:23:52 +0100 Date: Wed, 14 Jul 2021 11:23:52 +0100 Message-ID: <87k0lt6vnr.wl-maz@kernel.org> From: Marc Zyngier To: Alexandru Elisei Cc: linux-arm-kernel@lists.infradead.org, kvmarm@lists.cs.columbia.edu, james.morse@arm.com, suzuki.poulose@arm.com Subject: Re: [PATCH 3/5] KVM: arm64: Rename __vcpu_sys_reg -> vcpu_sys_reg In-Reply-To: <20210714095601.184854-4-alexandru.elisei@arm.com> References: <20210714095601.184854-1-alexandru.elisei@arm.com> <20210714095601.184854-4-alexandru.elisei@arm.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/27.1 (x86_64-pc-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") X-SA-Exim-Connect-IP: 185.219.108.64 X-SA-Exim-Rcpt-To: alexandru.elisei@arm.com, linux-arm-kernel@lists.infradead.org, kvmarm@lists.cs.columbia.edu, james.morse@arm.com, suzuki.poulose@arm.com X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210714_032355_060402_B01CE0B3 X-CRM114-Status: GOOD ( 20.49 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Alex, On Wed, 14 Jul 2021 10:55:59 +0100, Alexandru Elisei wrote: > > There are two macros to access a specific system register from a known > kvm_cpu_context: __ctxt_sys_reg(), which returns a pointer to the register, > and ctxt_sys_reg(), which deferences the pointer returned by > __ctxt_sys_reg(). > > __vcpu_sys_reg() serves a similar purpose, with the difference being that > it takes a struct kvm_vcpu as a parameter. __vcpu_sys_reg(), although it > looks like __ctxt_sys_reg(), it dereferences the pointer to the register, > like ctxt_sys_reg() does, and indeed it is defined as an abstraction over > ctxt_sys_reg(). > > Let's remove this naming inconsistency by renaming __vcpu_sys_reg() to > vcpu_sys_reg(), to make it clear it behaves like ctxt_sys_reg(), and not > like __ctxt_sys_reg(). I can't say I'm keen on this change. The leading underscores really are there to outline that *this is dangerous*, as you really need to know which context you are in. Dropping the leading '__' may give the false impression that this is safe, and not actually a primitive that requires careful thinking before use. ctxt_sys_reg() is, on the other hand, clearly something that acts solely on memory because it takes a context structure, and not a vcpu. At least that's what the 'ctxt' prefix is supposed to convey (not very successfully, apparently). Thanks, M. -- Without deviation from the norm, progress is not possible. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel