From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.2 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 40C98C433ED for ; Wed, 28 Apr 2021 14:38:31 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id D717561222 for ; Wed, 28 Apr 2021 14:38:30 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org D717561222 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Transfer-Encoding :Content-Type:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:Subject:Cc:To: From:Message-ID:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=3ZJ2jk8cuKTotTbbzx2Gcb9yKO4UnEd+1kujbm8tvCg=; b=TnBZFjrOfnGj+QiApE93i8EWo cgngQCE4vBZdzJ4QKeeUGpWw9E03TNH7x1ervpfYo0Tas3vKyEHLd3cs7eBsqHW9WutjrIKw6RUtG RzTzYfBFJvitXZ74IIBPfFA1tCN4YeAg4JXrIeHSjK6qfeHAOcY4IM+zd5l2ZlZZGpSAiTCq8p9Nf 6vgJbaeUmYfZDX2DpyOI/9EK1X3V/r3cx0u1Vxr24dub4YK5uX2hkDmic8W+9Oo7DYxXQmNdHvto3 IVJlc5i7dwIjtueabfFtDWZ+DsHLODpiJPQXXxbErh7T/rBCo2ZnTjjggABxqxed9SWpm4H4/GG+p X9BRHtRVw==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1lblIX-003dJZ-Ll; Wed, 28 Apr 2021 14:36:17 +0000 Received: from bombadil.infradead.org ([2607:7c80:54:e::133]) by desiato.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lblIV-003dJQ-AC for linux-arm-kernel@desiato.infradead.org; Wed, 28 Apr 2021 14:36:15 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=Content-Type:MIME-Version:References: In-Reply-To:Subject:Cc:To:From:Message-ID:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=g+BWeAo6QRp23vWpdckO28vJ28fGRGXnCgOUHFGpTsg=; b=iQREbRmaFvMMnChDkZvZ7VRr20 0xuilOSwjrotKu3zx3EStocyasl6n1rppzWFL5up6g6ZdztMgBehASEnWOpXWndUhk5ijAqzAbJ5d O56+ilxJz2+GnaRisxpm0nAcMC+rE4L00p10/7Jltw9R6wLuvwod/W5RIz0+K+8fxT6GmLIjdxPQv f17VMYcZPsuIKJqc/c/xuy48Uc+kojhJnJ9XodIbtWIkOhAJmEv35H2C4CiJ1o+ZXmVH1X4+S/QB+ Vpnt8xpLdwKrzLSqBFrpEikfDoZzWK8238lFH43EdKfByeykIOrMBpARKoORLPGCrp8EuCoqFaLJ6 q5emBftw==; Received: from mail.kernel.org ([198.145.29.99]) by bombadil.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lblIS-00HUqH-OL for linux-arm-kernel@lists.infradead.org; Wed, 28 Apr 2021 14:36:13 +0000 Received: from disco-boy.misterjones.org (disco-boy.misterjones.org [51.254.78.96]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id A00E86143B; Wed, 28 Apr 2021 14:36:11 +0000 (UTC) Received: from 78.163-31-62.static.virginmediabusiness.co.uk ([62.31.163.78] helo=why.misterjones.org) by disco-boy.misterjones.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94) (envelope-from ) id 1lblIP-009s5K-EV; Wed, 28 Apr 2021 15:36:09 +0100 Date: Wed, 28 Apr 2021 15:36:08 +0100 Message-ID: <87k0omo4rr.wl-maz@kernel.org> From: Marc Zyngier To: Alexandru Elisei Cc: Alex =?UTF-8?B?QmVubsOpZQ==?= , kvm@vger.kernel.org, shashi.mallela@linaro.org, eric.auger@redhat.com, qemu-arm@nongnu.org, linux-arm-kernel@lists.infradead.org, kvmarm@lists.cs.columbia.edu, christoffer.dall@arm.com Subject: Re: [kvm-unit-tests PATCH v1 1/4] arm64: split its-trigger test into KVM and TCG variants In-Reply-To: <996210ae-9c63-54ff-1a65-6dbd63da74d2@arm.com> References: <20210428101844.22656-1-alex.bennee@linaro.org> <20210428101844.22656-2-alex.bennee@linaro.org> <87fszasjdg.fsf@linaro.org> <996210ae-9c63-54ff-1a65-6dbd63da74d2@arm.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/27.1 (x86_64-pc-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") X-SA-Exim-Connect-IP: 62.31.163.78 X-SA-Exim-Rcpt-To: alexandru.elisei@arm.com, alex.bennee@linaro.org, kvm@vger.kernel.org, shashi.mallela@linaro.org, eric.auger@redhat.com, qemu-arm@nongnu.org, linux-arm-kernel@lists.infradead.org, kvmarm@lists.cs.columbia.edu, christoffer.dall@arm.com X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210428_073612_847605_5C01F158 X-CRM114-Status: GOOD ( 18.95 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, 28 Apr 2021 15:00:15 +0100, Alexandru Elisei wrote: > > I interpret that as that an INVALL guarantees that a change is > visible, but it the change can become visible even without the > INVALL. Yes. Expecting the LPI to be delivered or not in the absence of an invalidate when its configuration has been altered is wrong. The architecture doesn't guarantee anything of the sort. > The test relies on the fact that changes to the LPI tables are not > visible *under KVM* until the INVALL command, but that's not > necessarily the case on real hardware. To match the spec, I think > the test "dev2/eventid=20 still does not trigger any LPI" should be > removed and the stats reset should take place before the > configuration for LPI 8195 is set to the default. If that's what the test expects (I haven't tried to investigate), it should be dropped completely, rather than trying to sidestep it for TCG. Thanks, M. -- Without deviation from the norm, progress is not possible. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel