From: Gregory CLEMENT <gregory.clement@bootlin.com>
To: Baruch Siach <baruch@tkos.co.il>,
Jason Cooper <jason@lakedaemon.net>, Andrew Lunn <andrew@lunn.ch>,
Sebastian Hesselbarth <sebastian.hesselbarth@gmail.com>
Cc: Baruch Siach <baruch@tkos.co.il>, linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 1/2] ARM: dts: marvell: drop i2c timeout-ms property
Date: Sun, 17 May 2020 18:02:46 +0200 [thread overview]
Message-ID: <87k11ah7mh.fsf@FE-laptop> (raw)
In-Reply-To: <21ba4c9abd5e411ba936ead8f043c5a7e490d530.1588134636.git.baruch@tkos.co.il>
Hello Baruch,
> The timeout-ms property for i2c master nodes is undocumented, and as
> never been supported. Drop it.
>
> Signed-off-by: Baruch Siach <baruch@tkos.co.il>
Applied on mvebu/dt
Thanks,
Gregory
> ---
> arch/arm/boot/dts/armada-370-xp.dtsi | 2 --
> arch/arm/boot/dts/armada-375.dtsi | 2 --
> arch/arm/boot/dts/armada-38x.dtsi | 2 --
> arch/arm/boot/dts/armada-39x.dtsi | 4 ----
> arch/arm/boot/dts/dove.dtsi | 1 -
> 5 files changed, 11 deletions(-)
>
> diff --git a/arch/arm/boot/dts/armada-370-xp.dtsi b/arch/arm/boot/dts/armada-370-xp.dtsi
> index c15f5e92f97f..0b8c2a64b36f 100644
> --- a/arch/arm/boot/dts/armada-370-xp.dtsi
> +++ b/arch/arm/boot/dts/armada-370-xp.dtsi
> @@ -114,7 +114,6 @@ i2c0: i2c@11000 {
> #address-cells = <1>;
> #size-cells = <0>;
> interrupts = <31>;
> - timeout-ms = <1000>;
> clocks = <&coreclk 0>;
> status = "disabled";
> };
> @@ -124,7 +123,6 @@ i2c1: i2c@11100 {
> #address-cells = <1>;
> #size-cells = <0>;
> interrupts = <32>;
> - timeout-ms = <1000>;
> clocks = <&coreclk 0>;
> status = "disabled";
> };
> diff --git a/arch/arm/boot/dts/armada-375.dtsi b/arch/arm/boot/dts/armada-375.dtsi
> index 2932a29ae272..9805e507c695 100644
> --- a/arch/arm/boot/dts/armada-375.dtsi
> +++ b/arch/arm/boot/dts/armada-375.dtsi
> @@ -236,7 +236,6 @@ i2c0: i2c@11000 {
> #address-cells = <1>;
> #size-cells = <0>;
> interrupts = <GIC_SPI 2 IRQ_TYPE_LEVEL_HIGH>;
> - timeout-ms = <1000>;
> clocks = <&coreclk 0>;
> status = "disabled";
> };
> @@ -247,7 +246,6 @@ i2c1: i2c@11100 {
> #address-cells = <1>;
> #size-cells = <0>;
> interrupts = <GIC_SPI 3 IRQ_TYPE_LEVEL_HIGH>;
> - timeout-ms = <1000>;
> clocks = <&coreclk 0>;
> status = "disabled";
> };
> diff --git a/arch/arm/boot/dts/armada-38x.dtsi b/arch/arm/boot/dts/armada-38x.dtsi
> index e038abc0c6b4..348116501aa2 100644
> --- a/arch/arm/boot/dts/armada-38x.dtsi
> +++ b/arch/arm/boot/dts/armada-38x.dtsi
> @@ -153,7 +153,6 @@ i2c0: i2c@11000 {
> #address-cells = <1>;
> #size-cells = <0>;
> interrupts = <GIC_SPI 2 IRQ_TYPE_LEVEL_HIGH>;
> - timeout-ms = <1000>;
> clocks = <&coreclk 0>;
> status = "disabled";
> };
> @@ -164,7 +163,6 @@ i2c1: i2c@11100 {
> #address-cells = <1>;
> #size-cells = <0>;
> interrupts = <GIC_SPI 3 IRQ_TYPE_LEVEL_HIGH>;
> - timeout-ms = <1000>;
> clocks = <&coreclk 0>;
> status = "disabled";
> };
> diff --git a/arch/arm/boot/dts/armada-39x.dtsi b/arch/arm/boot/dts/armada-39x.dtsi
> index b1b86934c688..e0b7c2099831 100644
> --- a/arch/arm/boot/dts/armada-39x.dtsi
> +++ b/arch/arm/boot/dts/armada-39x.dtsi
> @@ -108,7 +108,6 @@ i2c0: i2c@11000 {
> #address-cells = <1>;
> #size-cells = <0>;
> interrupts = <GIC_SPI 2 IRQ_TYPE_LEVEL_HIGH>;
> - timeout-ms = <1000>;
> clocks = <&coreclk 0>;
> status = "disabled";
> };
> @@ -119,7 +118,6 @@ i2c1: i2c@11100 {
> #address-cells = <1>;
> #size-cells = <0>;
> interrupts = <GIC_SPI 3 IRQ_TYPE_LEVEL_HIGH>;
> - timeout-ms = <1000>;
> clocks = <&coreclk 0>;
> status = "disabled";
> };
> @@ -130,7 +128,6 @@ i2c2: i2c@11200 {
> #address-cells = <1>;
> #size-cells = <0>;
> interrupts = <GIC_SPI 4 IRQ_TYPE_LEVEL_HIGH>;
> - timeout-ms = <1000>;
> clocks = <&coreclk 0>;
> status = "disabled";
> };
> @@ -141,7 +138,6 @@ i2c3: i2c@11300 {
> #address-cells = <1>;
> #size-cells = <0>;
> interrupts = <GIC_SPI 5 IRQ_TYPE_LEVEL_HIGH>;
> - timeout-ms = <1000>;
> clocks = <&coreclk 0>;
> status = "disabled";
> };
> diff --git a/arch/arm/boot/dts/dove.dtsi b/arch/arm/boot/dts/dove.dtsi
> index 3081b04e8c08..a551fabae851 100644
> --- a/arch/arm/boot/dts/dove.dtsi
> +++ b/arch/arm/boot/dts/dove.dtsi
> @@ -175,7 +175,6 @@ i2c: i2c@11000 {
> #size-cells = <0>;
> interrupts = <11>;
> clock-frequency = <400000>;
> - timeout-ms = <1000>;
> clocks = <&core_clk 0>;
> status = "okay";
> };
> --
> 2.26.2
>
--
Gregory Clement, Bootlin
Embedded Linux and Kernel engineering
http://bootlin.com
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
prev parent reply other threads:[~2020-05-17 16:03 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-29 4:30 [PATCH 1/2] ARM: dts: marvell: drop i2c timeout-ms property Baruch Siach
2020-04-29 4:30 ` [PATCH 2/2] arm64: " Baruch Siach
2020-04-29 18:22 ` Andrew Lunn
2020-05-17 16:01 ` Gregory CLEMENT
2020-04-29 18:22 ` [PATCH 1/2] ARM: " Andrew Lunn
2020-05-17 16:02 ` Gregory CLEMENT [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87k11ah7mh.fsf@FE-laptop \
--to=gregory.clement@bootlin.com \
--cc=andrew@lunn.ch \
--cc=baruch@tkos.co.il \
--cc=jason@lakedaemon.net \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=sebastian.hesselbarth@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).