From mboxrd@z Thu Jan 1 00:00:00 1970 From: khilman@deeprootsystems.com (Kevin Hilman) Date: Tue, 23 Oct 2012 09:09:31 -0700 Subject: [RFC] ARM: OMAP: hwmod: wait for sysreset complete after enabling hwmod In-Reply-To: (Shubhrajyoti Datta's message of "Tue, 23 Oct 2012 21:13:56 +0530") References: <1350922532-26338-1-git-send-email-t-kristo@ti.com> <87zk3edvti.fsf@deeprootsystems.com> Message-ID: <87k3uhb26c.fsf@deeprootsystems.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Shubhrajyoti Datta writes: > On Tue, Oct 23, 2012 at 3:16 AM, Kevin Hilman > wrote: >> Tero Kristo writes: >> >>> When waking up from off-mode, some IP blocks are reset automatically by >>> hardware. For this reason, software must wait until the reset has >>> completed before attempting to access the IP block. >>> >>> This patch fixes for example the bug introduced by commit >>> 6c31b2150ff96755d24e0ab6d6fea08a7bf5c44c ("mmc: omap_hsmmc: remove access >>> to SYSCONFIG register"), in which the MMC IP block is reset during >>> off-mode entry, but the code expects the module to be already available >>> during the execution of context restore. >>> >>> Signed-off-by: Tero Kristo >>> Cc: Paul Walmsley >>> Cc: Benoit Cousson >>> Cc: Venkatraman S >> >> I can confirm that this patch the regression in my OMAP3 PM tests where >> suspend test (to retention or off) failed if ran after the off-idle >> test. >> >> Tested-by: Kevin Hilman >> >> on 3530/Overo, 3730/OveroSTORM, 3730/Beagle-xM > > on 3630/Beagle works. > However on 3430 on idle path didnot work. > let me know if i am missing some thing. Could you please explain what worked and didn't work on each platforms? Also, which 3430 did you test on? If it's SDP, then it has a UART1 console, correct? Kevin