Re: [PATCH v2 2/2] soc: ti: ti_sci_inta_msi: Enable module compilation support

Re: [PATCH v2 2/2] soc: ti: ti_sci_inta_msi: Enable module compilation support

[Nishanth Menon]

On 22:36-20250812, Guillaume La Roque wrote:
> Add module support to the TI SCI INTA MSI driver:
> - Change Kconfig from bool to tristate to allow module compilation
> - Add linux/module.h include for module functionality
> - Add MODULE_LICENSE, MODULE_DESCRIPTION, and MODULE_AUTHOR macros
> 
> This allows the driver to be compiled as a loadable kernel module
> named ti_sci_inta_msi.
> 
> Signed-off-by: Guillaume La Roque <glaroque@baylibre.com>
> ---
>  drivers/soc/ti/Kconfig           | 5 ++++-
>  drivers/soc/ti/ti_sci_inta_msi.c | 5 +++++
>  2 files changed, 9 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/soc/ti/Kconfig b/drivers/soc/ti/Kconfig
> index 1a93001c9e36..0a9eb5ac264b 100644
> --- a/drivers/soc/ti/Kconfig
> +++ b/drivers/soc/ti/Kconfig
> @@ -85,7 +85,10 @@ config TI_PRUSS
>  endif # SOC_TI
>  
>  config TI_SCI_INTA_MSI_DOMAIN
> -	bool
> +	tristate "TI SCI INTA MSI Domain driver"
>  	select GENERIC_MSI_IRQ
>  	help
>  	  Driver to enable Interrupt Aggregator specific MSI Domain.
> +
> +	  Say Y here to compile it into the kernel or M to compile it as a
> +	  module. The module will be called ti_sci_inta_msi.
> diff --git a/drivers/soc/ti/ti_sci_inta_msi.c b/drivers/soc/ti/ti_sci_inta_msi.c
> index 193266f5e3f9..d92cab319d57 100644
> --- a/drivers/soc/ti/ti_sci_inta_msi.c
> +++ b/drivers/soc/ti/ti_sci_inta_msi.c
> @@ -8,6 +8,7 @@
>  
>  #include <linux/irq.h>
>  #include <linux/irqdomain.h>
> +#include <linux/module.h>
>  #include <linux/msi.h>
>  #include <linux/of.h>
>  #include <linux/of_address.h>
> @@ -115,3 +116,7 @@ int ti_sci_inta_msi_domain_alloc_irqs(struct device *dev,
>  	return ret;
>  }
>  EXPORT_SYMBOL_GPL(ti_sci_inta_msi_domain_alloc_irqs);
> +
> +MODULE_LICENSE("GPL");
> +MODULE_DESCRIPTION("Texas Instruments K3 Interrupt Aggregator MSI bus");
> +MODULE_AUTHOR("Lokesh Vutla <lokeshvutla@ti.com>");
> 
> -- 
> 2.34.1
> 

If Thomas doesn't mind picking the full series,

Acked-by: Nishanth Menon <nm@ti.com>

This is probably one of the last hold outs for us to move SoC support
into kernel modules.

-- 
Regards,
Nishanth Menon
Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3  1A34 DDB5 849D 1736 249D
https://ti.com/opensource

Re: [PATCH v2 2/2] soc: ti: ti_sci_inta_msi: Enable module compilation support

[Guillaume La Roque]

Hi,

I will resend weries because something look not ok i don't find serie in 
lore or patchwork.

Guillaume

Le 13/08/2025 à 17:26, Nishanth Menon a écrit :
> On 22:36-20250812, Guillaume La Roque wrote:
>> Add module support to the TI SCI INTA MSI driver:
>> - Change Kconfig from bool to tristate to allow module compilation
>> - Add linux/module.h include for module functionality
>> - Add MODULE_LICENSE, MODULE_DESCRIPTION, and MODULE_AUTHOR macros
>>
>> This allows the driver to be compiled as a loadable kernel module
>> named ti_sci_inta_msi.
>>
>> Signed-off-by: Guillaume La Roque <glaroque@baylibre.com>
>> ---
>>   drivers/soc/ti/Kconfig           | 5 ++++-
>>   drivers/soc/ti/ti_sci_inta_msi.c | 5 +++++
>>   2 files changed, 9 insertions(+), 1 deletion(-)
>>
>> diff --git a/drivers/soc/ti/Kconfig b/drivers/soc/ti/Kconfig
>> index 1a93001c9e36..0a9eb5ac264b 100644
>> --- a/drivers/soc/ti/Kconfig
>> +++ b/drivers/soc/ti/Kconfig
>> @@ -85,7 +85,10 @@ config TI_PRUSS
>>   endif # SOC_TI
>>   
>>   config TI_SCI_INTA_MSI_DOMAIN
>> -	bool
>> +	tristate "TI SCI INTA MSI Domain driver"
>>   	select GENERIC_MSI_IRQ
>>   	help
>>   	  Driver to enable Interrupt Aggregator specific MSI Domain.
>> +
>> +	  Say Y here to compile it into the kernel or M to compile it as a
>> +	  module. The module will be called ti_sci_inta_msi.
>> diff --git a/drivers/soc/ti/ti_sci_inta_msi.c b/drivers/soc/ti/ti_sci_inta_msi.c
>> index 193266f5e3f9..d92cab319d57 100644
>> --- a/drivers/soc/ti/ti_sci_inta_msi.c
>> +++ b/drivers/soc/ti/ti_sci_inta_msi.c
>> @@ -8,6 +8,7 @@
>>   
>>   #include <linux/irq.h>
>>   #include <linux/irqdomain.h>
>> +#include <linux/module.h>
>>   #include <linux/msi.h>
>>   #include <linux/of.h>
>>   #include <linux/of_address.h>
>> @@ -115,3 +116,7 @@ int ti_sci_inta_msi_domain_alloc_irqs(struct device *dev,
>>   	return ret;
>>   }
>>   EXPORT_SYMBOL_GPL(ti_sci_inta_msi_domain_alloc_irqs);
>> +
>> +MODULE_LICENSE("GPL");
>> +MODULE_DESCRIPTION("Texas Instruments K3 Interrupt Aggregator MSI bus");
>> +MODULE_AUTHOR("Lokesh Vutla <lokeshvutla@ti.com>");
>>
>> -- 
>> 2.34.1
>>
> If Thomas doesn't mind picking the full series,
>
> Acked-by: Nishanth Menon <nm@ti.com>
>
> This is probably one of the last hold outs for us to move SoC support
> into kernel modules.
>

Re: [PATCH v2 2/2] soc: ti: ti_sci_inta_msi: Enable module compilation support

[Thomas Gleixner]

On Tue, Sep 02 2025 at 16:40, Guillaume La Roque wrote:

Can you please trim your replies?

> I will resend weries because something look not ok i don't find serie in 
> lore or patchwork.

>> If Thomas doesn't mind picking the full series,

Is this actually addressing my previous feedback on this?

   https://lore.kernel.org/all/87cy87zx87.ffs@tglx

>>>   config TI_SCI_INTA_MSI_DOMAIN
>>> -	bool
>>> +	tristate "TI SCI INTA MSI Domain driver"
>>>   	select GENERIC_MSI_IRQ
>>>   	help
>>>   	  Driver to enable Interrupt Aggregator specific MSI Domain.
>>> +
>>> +	  Say Y here to compile it into the kernel or M to compile it as a
>>> +	  module. The module will be called ti_sci_inta_msi.

I doubt it, otherwise this would not exist anymore.

If you disagree with me, then have the courtesy to tell me why. Just
ignoring me is not an option.

Thanks

        tglx