Re: [PATCH] arm: orion5x: use string choices helper

Kuninori Morimoto
2025-06-17T01:38:42Z

Hi Andrew

Thank you for your review

> > - return sprintf(buf, "%s\n", (ts78xx_fpga.state) ? "online" : "offline");
> > + return sprintf(buf, "%sline\n", str_on_off(ts78xx_fpga.state));
>
> static inline const char *str_on_off(bool v)
> {
> return v ? "on" : "off";
> }
>
> That is an ABI change. Sorry, but NACK.

It updates format too, I guess it keeps "online/offline" ?

- return sprintf(buf, "%s\n", ...
+ return sprintf(buf, "%sline\n", ...
^^^^

Thank you for your help !!

Best regards
---
Kuninori Morimoto