From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id D4FB2C27C4F for ; Fri, 21 Jun 2024 14:04:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Type:MIME-Version: Message-ID:Date:References:In-Reply-To:Subject:Cc:To:From:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=9vxYLRaM0g0hLDEgQ8vsw75W1q+Hkmc7pGfCU1ZZdT4=; b=n+3OW3n8QgB6tkWTeAmp92dcpH Pq7ZcwFGfHq77aQ65JnsbxxXqnPHq0p3XYrfG2Krt2kOF0o2z61DmGbw28o4LXo/Bg/UktDAquHFD tmulFldVv1v4iNyxG9ViNN8bbbBG87/ra+/ZQXLFtTD5PojdQoeUC3pHonh2gzTNc0hOknRIyEd9+ igwU4leEtEcoMgClAX3XGhF1FQqGvJBm/KG2aGUg/SztrSneT4q09KB5kykohS3wXA81AY2P5vzEs Pxl8MIAVmhnQmKsu2wXZcERjDjDPYJSkik94VYZzU14MF9x9BSVpqkqRONeMwA2Qg95ESZSgkkE5m WOJ94Fcg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sKesV-00000009ROH-33Xd; Fri, 21 Jun 2024 14:04:35 +0000 Received: from galois.linutronix.de ([2a0a:51c0:0:12e:550::1]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1sKesR-00000009RMu-0XqL for linux-arm-kernel@lists.infradead.org; Fri, 21 Jun 2024 14:04:33 +0000 From: Thomas Gleixner DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020; t=1718978668; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=9vxYLRaM0g0hLDEgQ8vsw75W1q+Hkmc7pGfCU1ZZdT4=; b=3O31GzIqzYpWk9Lzp2k8vutGkUFZ+IxeVJ0KvoKS/pm+u44o/prmAwQ2sTmGQeO+unqmgL jZfPg5Ta9SWbRSGvBs7h/G/EsN+ETE4U8Da3bkfqCaDwhMR2S4CNp5LKv++rZN7BlSRzAX lz3NiGPgaWT+q3MXl5cBAL3NJPznEFTeRkz65RaoOERoMgMb5Nj0msrXAeTAKJhvUzLN73 kJpf/cd6HYgaOBEDUZQfuhCzE1P908mBFk3y7aI59H/rfOkU4rZcMZYOvEI6wF1osIplFK 0S9rZOMzGaHmVKN8TSFpmRsHZlj6Tu9eju097O6sbWcRxerq+MzpqEeUMEqeSQ== DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020e; t=1718978668; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=9vxYLRaM0g0hLDEgQ8vsw75W1q+Hkmc7pGfCU1ZZdT4=; b=c44WSDYK/TeAI2oxSjPi9TXvGYnylf68EKuN95zvRde+oDPWqd/SrCa2CA3K+a+fpgWs+Y KfIjKhdEJMR5cqBA== To: Marc Zyngier Cc: Shivamurthy Shastri , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-pci@vger.kernel.org, anna-maria@linutronix.de, shawnguo@kernel.org, s.hauer@pengutronix.de, festevam@gmail.com, bhelgaas@google.com, rdunlap@infradead.org, vidyas@nvidia.com, ilpo.jarvinen@linux.intel.com, apatel@ventanamicro.com, kevin.tian@intel.com, nipun.gupta@amd.com, den@valinux.co.jp, andrew@lunn.ch, gregory.clement@bootlin.com, sebastian.hesselbarth@gmail.com, gregkh@linuxfoundation.org, rafael@kernel.org, alex.williamson@redhat.com, will@kernel.org, lorenzo.pieralisi@arm.com, jgg@mellanox.com, ammarfaizi2@gnuweeb.org, robin.murphy@arm.com, lpieralisi@kernel.org, nm@ti.com, kristo@kernel.org, vkoul@kernel.org, okaya@kernel.org, agross@kernel.org, andersson@kernel.org, mark.rutland@arm.com, shameerali.kolothum.thodi@huawei.com, yuzenghui@huawei.com Subject: Re: [PATCH v3 14/24] genirq/gic-v3-mbi: Remove unused wired MSI mechanics In-Reply-To: <87ed8vu033.ffs@tglx> References: <20240614102403.13610-1-shivamurthy.shastri@linutronix.de> <20240614102403.13610-15-shivamurthy.shastri@linutronix.de> <86le36jf0q.wl-maz@kernel.org> <87plsfu3sz.ffs@tglx> <86h6drk9h1.wl-maz@kernel.org> <87h6dru0pb.ffs@tglx> <87ed8vu033.ffs@tglx> Date: Fri, 21 Jun 2024 16:04:28 +0200 Message-ID: <87le2yo0ib.ffs@tglx> MIME-Version: 1.0 Content-Type: text/plain X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240621_070431_332167_E8681BBA X-CRM114-Status: GOOD ( 12.02 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Gentle ping! On Mon, Jun 17 2024 at 16:15, Thomas Gleixner wrote: > On Mon, Jun 17 2024 at 16:02, Thomas Gleixner wrote: >> On Mon, Jun 17 2024 at 14:03, Marc Zyngier wrote: >>> Patch 9/24 rewrites the mbigen driver. Which has nothing to do with >>> what the gic-v3-mbi code does. They are different blocks, and the sole >>> machine that has the mbigen IP doesn't have any gic-v3-mbi support. >>> All they have in common are 3 random letters. >>> >>> What you are doing here is to kill any support for *devices* that need >>> to signal level-triggered MSIs in that driver, and nothing to do with >>> wire-MSI translation. >>> >>> So what replaces it? >> >> Hrm. I must have misread this mess. Let me stare some more. > > Ok. Found my old notes. > > AFAICT _all_ users of platform_device_msi_init_and_alloc_irqs(): > > ufs_qcom_config_esi() > smmu_pmu_setup_msi() > flexrm_mbox_probe() > arm_smmu_setup_msis() > hidma_request_msi() > mv_xor_v2_probe() > > just install their special MSI write callback. I don't see any of those > setting up LEVEL triggered MSIs. > > But then I'm might be missing something. If so can you point me please > to the usage instance which actually uses level signaled MSI? > > Thanks, > > tglx