From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 68102C4345F for ; Mon, 22 Apr 2024 21:29:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-ID:Date:References :In-Reply-To:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=dnoJ2tPFM0KzKClSqRqs6hTEX9CmYol6SuHolsoiJhg=; b=OJL3K/SEqB69lF g+vEiZTC0d/BtBPetWGomxrV4wQUAkdOVYmK/+rs2+Eawm5ClJiA/FOMExhvkzlLcGi3aSqHh/G3o cQP5NP7aLiORB+XjkeyVSi1ZgJehH9Bfl7EAolJ93RKqy+gXWaMqCr9aXp3b1gWPSNI4e+Ucor7qb o6klzLJI+Za9QHcQ4PmLK2ip/522QF2xrprNOqfSIj8UkPD/N+3EsbfP1ZOQGa8XCCtih2y6XNCk5 eYGmtktjfg8YSOpc6eLMGPEUnAgaR2sRFHds27Dbxv/jLd/qzJGDsqJfSIjITv6wSqbjrE2xBMsBM tMFt/oZZ4U5ESiAbizGg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rz1E4-0000000F6W4-1frT; Mon, 22 Apr 2024 21:29:24 +0000 Received: from galois.linutronix.de ([193.142.43.55]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rz1E0-0000000F6VC-1GdF for linux-arm-kernel@lists.infradead.org; Mon, 22 Apr 2024 21:29:23 +0000 From: Thomas Gleixner DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020; t=1713821357; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=eeyuEbrEx1MPoiOjVnW6ImI9gPSzPtQTfgem9Ff9pSI=; b=Kp1ExzYmRQaKsiOSMmITaxogq9JhEcwIV44iCbU3V3uLKMCZdFmzlU/cp5WOiq9W/5Ke2q f/oSqov0Oi7SrAFfSMB4PIcdRpNUuC8kcO/VtCwHXVFRP2ZrVpgUxoirToSyH3vNJynEDq 4kVknKPcFks1ZyH/UgLHuqzblH0UHkD/v1SNCt0SeJQIORup+f2ijCa05zMpRcH5RbOi4T RzKxtqUuKbuGReooLq5SAmPQ3QilUGGOeNXG15K+e1AGEjEAVWXz2VtboxK4IZCjZgFNVz JDJeNcIKuj7DtJ/IJmmL2vxbL3CoyU07mK2YhQM4dPBFw8XadUmEjKTQh+Wyyg== DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020e; t=1713821357; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=eeyuEbrEx1MPoiOjVnW6ImI9gPSzPtQTfgem9Ff9pSI=; b=8yBclRjKCw8Nf5LARioW+Naqyx6TNa7SarnX433TQUWLxfqWJf4L9ckMKEY6o/Lhiozidf M/WO8dzdvVdbAEAg== To: Florian Fainelli , linux-kernel@vger.kernel.org Cc: opendmb@gmail.com, Florian Fainelli , Tim Ross , Broadcom internal kernel review list , "open list:BROADCOM BMIPS MIPS ARCHITECTURE" , "moderated list:BROADCOM BCM7XXX ARM ARCHITECTURE" Subject: Re: [PATCH] irqchip/irq-brcmstb-l2: Avoid saving mask on shutdown In-Reply-To: <20240416194343.469318-1-florian.fainelli@broadcom.com> References: <20240416194343.469318-1-florian.fainelli@broadcom.com> Date: Mon, 22 Apr 2024 23:29:14 +0200 Message-ID: <87le55ulw5.ffs@tglx> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240422_142920_515840_58DFC0F5 X-CRM114-Status: GOOD ( 16.08 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, Apr 16 2024 at 12:43, Florian Fainelli wrote: > The interrupt controller shutdown path does not need to save the mask of > enabled interrupts because the next state the system is going to be in > is akin to a cold boot, or a kexec'd kernel. Sure, but > Reported-by: Tim Ross > Signed-off-by: Florian Fainelli > --- > drivers/irqchip/irq-brcmstb-l2.c | 17 ++++++++++++++--- > 1 file changed, 14 insertions(+), 3 deletions(-) > > diff --git a/drivers/irqchip/irq-brcmstb-l2.c b/drivers/irqchip/irq-brcmstb-l2.c > index 2b0b3175cea0..c988886917f7 100644 > --- a/drivers/irqchip/irq-brcmstb-l2.c > +++ b/drivers/irqchip/irq-brcmstb-l2.c > @@ -118,7 +118,7 @@ static void brcmstb_l2_intc_irq_handle(struct irq_desc *desc) > chained_irq_exit(chip, desc); > } > > -static void brcmstb_l2_intc_suspend(struct irq_data *d) > +static void __brcmstb_l2_intc_suspend(struct irq_data *d, bool save) > { > struct irq_chip_generic *gc = irq_data_get_irq_chip_data(d); > struct irq_chip_type *ct = irq_data_get_chip_type(d); > @@ -127,7 +127,8 @@ static void brcmstb_l2_intc_suspend(struct irq_data *d) > > irq_gc_lock_irqsave(gc, flags); > /* Save the current mask */ > - b->saved_mask = irq_reg_readl(gc, ct->regs.mask); > + if (save) > + b->saved_mask = irq_reg_readl(gc, ct->regs.mask); what's the conditional actually buying you except more complex code? Thanks, tglx _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel