From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id D6DF4CD1284 for ; Sun, 31 Mar 2024 10:59:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Subject:Cc:To:From:Message-ID:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=Rl1uHYoxmlxC1CS4+cu23n1sl+4tAw2G8nJk+Vi3etw=; b=qvxwa9ECYfGfmx X2urpNNDAk63txX/gBFJfqPihlehlsIGYxMxoaaVRCZgPcrpp08lnRe9NHae2Vh13rPrMXxstyrW5 qiGKD7745BBE2MIfgfPanQQzEaByM+Q+Rf2e3x5yOBe8JedVZsEITGbpSEcu27pp6Rgr7uFxivg2L 5c2SNEEsW/OuU2QFXCFDI6rYTVDPdIMoGfHAORIlmR/GH/R1Te2qYydn+yS0KlowuUAAP4bBcQytk oblQxmsbceNtYd+x02QLEJgXpWZkH8vlWzaPOwZjoOo9pDZtj5bwK564deddBec2TR9q2Dhal4nvn wiIP0lrw/SeS7G3ozJ+A==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rqsuC-00000005HiF-3R52; Sun, 31 Mar 2024 10:59:16 +0000 Received: from dfw.source.kernel.org ([2604:1380:4641:c500::1]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rqsu8-00000005HgP-1qnb for linux-arm-kernel@lists.infradead.org; Sun, 31 Mar 2024 10:59:15 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id 17CF660A47; Sun, 31 Mar 2024 10:59:10 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id B61FCC433F1; Sun, 31 Mar 2024 10:59:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1711882749; bh=E/mXO2r8N+mvHUjPMnvWB+Izzfu4L00THFiMK03lb68=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=ERqxj6v8X0bw8+Nn+UE7aUiWGYJc9LvPo4mBhsECJoHarVZLp3LXI7/62lAKBZap3 GNdoJwAn6Q2oj9ABUEihq76OhmeRXXlifkDzaOieupHDMIgPrf6Nh0A1yBmWwQhBUn l2TjZW042YsgfyPN3wsh67WXvdLDSaIbF4tbVvMmFyPYjA2J4Rjv1Z9u8MqZPvJ1Lx iXuxOEjcbKO7F0h9mPEkG0ZtiMjbDBHzWcgFSzszSNJjsVo/HB9broW2NE45amyl4q Bh86kTlGq1jzIVKVFrodRfdnMv/V+mojH0BBsljrTxB1MEXkQYlFPXTj/wTPVyAUEl 9+eBc973iZJyQ== Received: from 82-132-233-13.dab.02.net ([82.132.233.13] helo=wait-a-minute.misterjones.org) by disco-boy.misterjones.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1rqsu3-0001gL-Ea; Sun, 31 Mar 2024 11:59:07 +0100 Date: Sun, 31 Mar 2024 11:59:06 +0100 Message-ID: <87le5ysm4l.wl-maz@kernel.org> From: Marc Zyngier To: Mark Brown Cc: Catalin Marinas , Will Deacon , Oliver Upton , James Morse , Suzuki K Poulose , Jonathan Corbet , Shuah Khan , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Dave Martin , kvmarm@lists.linux.dev, linux-doc@vger.kernel.org, linux-kselftest@vger.kernel.org Subject: Re: [PATCH v6 2/5] KVM: arm64: Add newly allocated ID registers to register descriptions In-Reply-To: <20240329-arm64-2023-dpisa-v6-2-ba42db6c27f3@kernel.org> References: <20240329-arm64-2023-dpisa-v6-0-ba42db6c27f3@kernel.org> <20240329-arm64-2023-dpisa-v6-2-ba42db6c27f3@kernel.org> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/28.2 (x86_64-pc-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") X-SA-Exim-Connect-IP: 82.132.233.13 X-SA-Exim-Rcpt-To: broonie@kernel.org, catalin.marinas@arm.com, will@kernel.org, oliver.upton@linux.dev, james.morse@arm.com, suzuki.poulose@arm.com, corbet@lwn.net, shuah@kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Dave.Martin@arm.com, kvmarm@lists.linux.dev, linux-doc@vger.kernel.org, linux-kselftest@vger.kernel.org X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240331_035912_887820_1B7DE13E X-CRM114-Status: GOOD ( 21.04 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, 29 Mar 2024 00:13:43 +0000, Mark Brown wrote: > > The 2023 architecture extensions have allocated some new ID registers, add > them to the KVM system register descriptions so that they are visible to > guests. > > We make the newly introduced dpISA features writeable, as well as > allowing writes to ID_AA64ISAR3_EL1.CPA for FEAT_CPA which only > introduces straigforward new instructions with no additional > architectural state or traps. FPMR actively gets trapped by HCRX_EL2. > > Signed-off-by: Mark Brown > --- > arch/arm64/kvm/sys_regs.c | 11 ++++++++--- > 1 file changed, 8 insertions(+), 3 deletions(-) > > diff --git a/arch/arm64/kvm/sys_regs.c b/arch/arm64/kvm/sys_regs.c > index c9f4f387155f..a3c20d1a36aa 100644 > --- a/arch/arm64/kvm/sys_regs.c > +++ b/arch/arm64/kvm/sys_regs.c > @@ -2293,12 +2293,15 @@ static const struct sys_reg_desc sys_reg_descs[] = { > ID_AA64PFR0_EL1_AdvSIMD | > ID_AA64PFR0_EL1_FP), }, > ID_SANITISED(ID_AA64PFR1_EL1), > - ID_UNALLOCATED(4,2), > + ID_WRITABLE(ID_AA64PFR2_EL1, ~(ID_AA64PFR2_EL1_RES0 | > + ID_AA64PFR2_EL1_MTEFAR | > + ID_AA64PFR2_EL1_MTESTOREONLY | > + ID_AA64PFR2_EL1_MTEPERM)), > ID_UNALLOCATED(4,3), > ID_WRITABLE(ID_AA64ZFR0_EL1, ~ID_AA64ZFR0_EL1_RES0), > ID_HIDDEN(ID_AA64SMFR0_EL1), > ID_UNALLOCATED(4,6), > - ID_UNALLOCATED(4,7), > + ID_WRITABLE(ID_AA64FPFR0_EL1, ~ID_AA64FPFR0_EL1_RES0), > > /* CRm=5 */ > { SYS_DESC(SYS_ID_AA64DFR0_EL1), > @@ -2325,7 +2328,9 @@ static const struct sys_reg_desc sys_reg_descs[] = { > ID_WRITABLE(ID_AA64ISAR2_EL1, ~(ID_AA64ISAR2_EL1_RES0 | > ID_AA64ISAR2_EL1_APA3 | > ID_AA64ISAR2_EL1_GPA3)), > - ID_UNALLOCATED(6,3), > + ID_WRITABLE(ID_AA64ISAR3_EL1, ~(ID_AA64ISAR2_EL1_RES0 | > + ID_AA64ISAR3_EL1_PACM | > + ID_AA64ISAR3_EL1_TLBIW)), > ID_UNALLOCATED(6,4), > ID_UNALLOCATED(6,5), > ID_UNALLOCATED(6,6), > Where is the code that enforces the lack of support for MTEFAR, MTESTOREONLY, and MTEPERM for SCTLR_ELx, EnPACM and EnFPM in HCRX_EL2? And I haven't checked whether TLBI VMALLWS2 can be trapped. M. -- Without deviation from the norm, progress is not possible. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel