From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 7E7A3C64EC7 for ; Wed, 22 Feb 2023 15:55:44 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-ID:In-reply-to: Date:Subject:Cc:To:From:References:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=Kb6LVtb5Jl5w+0vDzXsGUU/oCoUiqi3lr0AMMzJZK5A=; b=GX8o6hFua26Dof YsYPoxKezaGlJ4nhFNJ3bztqCZ10trHeXpy62Ow2fYSeklw9NM68zcwyoMzOmc7UuwEkFF3u2xziU WEhuwTJO/qASoSwJPu7Dvf1li5VYRDbkz6wnN7lFPtAeKtt8BzYsA9zCbjdemh5doFmp1k2KC4vsH wZ1oH1qTybaLPs4lx4bJ/V9mz9Ao+IutMsyVkJIe4ClM7DoD1Dqxa0Uw0qL6pYTC9+bf/gNCXeKM+ lPu1S1IFpGOQiEdZnoUw3lSax8av3gxVmyhUAK9bTLNFg/DNXdhLRTpVoBoU7FAMevo0o6I+1Wilx 8Li2ybu3RxbezFkupVyQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1pUrRy-00Cvs1-Fh; Wed, 22 Feb 2023 15:54:34 +0000 Received: from mout.kundenserver.de ([212.227.126.131]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1pUrRu-00Cvr0-Qn for linux-arm-kernel@lists.infradead.org; Wed, 22 Feb 2023 15:54:32 +0000 Received: from maxwell ([109.42.114.8]) by mrelayeu.kundenserver.de (mreue012 [213.165.67.97]) with ESMTPSA (Nemesis) id 1MxYT3-1ocJz31HJ3-00xpU3; Wed, 22 Feb 2023 16:52:28 +0100 References: <87y1oq5es0.fsf@henneberg-systemdesign.com> User-agent: mu4e 1.8.14; emacs 28.2 From: Henneberg - Systemdesign To: Simon Horman Cc: Giuseppe Cavallaro , Alexandre Torgue , Jose Abreu , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Maxime Coquelin , Ong Boon Leong , netdev@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH net V3] net: stmmac: Premature loop termination check was ignored Date: Wed, 22 Feb 2023 16:49:55 +0100 In-reply-to: Message-ID: <87lekp66ko.fsf@henneberg-systemdesign.com> MIME-Version: 1.0 X-Provags-ID: V03:K1:EUGFsK4XpAaH7yDm8YNyP0ASKdEARzN+x2SV1AiBuR+LhHCnNaO uQLIPRzr4vwnDQWs/T02m1FrIcZs6wX8ji5EkKXoTyqemxilayzw8e4dPQxNNvDH5F6hhRJ WLPY46dmsHwxpUYcn1KzoXBWo/XbQEQf6TYQNP/H783B9J0FaH7CllbNW6zDbpqlqtNxrIA EovVJLBeRYmf1/+FE/Sgw== UI-OutboundReport: notjunk:1;M01:P0:SPFQol5nWp4=;6conbKbuDxwgu7b+mEolyujyQQh 7nEdfqVUyRLezt7Q/BnlStJ1iWpj2h7vbYL4l+gA/g0pchlMhk76uu1iDS/MD/8CYhHUtmGlM un+71UbKucAjzz248yfz+nqetwn5gtmmZ541QT5Cxy3ROGP21+TYIY9VvekKdiOJYDhxSbp1I LCUOhiFW+sI2XlWlO73WgnCwNgse9fuvkCBs0PxDrRLV2gCeFhkKJMPOEPtN02EQwihgIoWb/ Odx0rQw5XwNT7x7PNHuLxgujs2t9GfBGtfnArWLhZV3keMKBaupn8PXODPsthtDMboZBfLjLI GdqUaKP4+mucSbnN7jce/2gkwlPKcrm/hxMqxsnoW4I0o7+RSXv6qW7ySofu1PxCb0uuMkFjd 2M+T9K4/+0n00il0+gvQQwcsmgQpcDjjGGlrIqglZg/OULvw1quChWL74+ogItGZok6+5IAJv gpaLVgkOGeHfD0OuUhAsInjJ6+yJ8c4ie3FeB7TdoaVtj8IoZURMxkqB2shQit7IUv57W6iok pFzd0u/uFcN/wCGAXx6+qqdukfrscRjOf5dG9Sy03Tr0L75/hRkS3XBbtzSf1f3fLZt6Xy1+f FM/OoW0uPrVXP4+GH9aBDv35hQrY/SIgEBbpZeVCZDgEkTVohsXJgIzNB/2DVIe0Dg9PuTv9Z 18XhBGxVQ7P2Ycfpi1rfhrDBEEzMRGuyNZsX2IQ35g== X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230222_075431_190540_90F52DCD X-CRM114-Status: GOOD ( 21.45 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Simon Horman writes: > On Wed, Feb 22, 2023 at 08:38:28AM +0100, Jochen Henneberg wrote: >> >> The premature loop termination check makes sense only in case of the >> jump to read_again where the count may have been updated. But >> read_again did not include the check. >> >> Fixes: bba2556efad6 ("net: stmmac: Enable RX via AF_XDP zero-copy") > > This commit was included in v5.13 > >> Fixes: ec222003bd94 ("net: stmmac: Prepare to add Split Header support") > > While this one was included in v5.4 > > It seems to me that each of the above commits correspond to one > of the two hunks below. I don't know if that means this > patch should be split in two to assist backporting. > I was thinking about this already but the change was so trivial that I hesitated to split it into two commits. I wanted I will surely change this. >> Signed-off-by: Jochen Henneberg > > That aside, this looks good to me. > > Reviewed-by: Simon Horman > >> --- >> V2: Added fixes tags >> V3: Fixed fixes tag format >> >> drivers/net/ethernet/stmicro/stmmac/stmmac_main.c | 4 ++-- >> 1 file changed, 2 insertions(+), 2 deletions(-) >> >> diff --git a/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c b/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c >> index 1a5b8dab5e9b..de98c009866a 100644 >> --- a/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c >> +++ b/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c >> @@ -5031,10 +5031,10 @@ static int stmmac_rx_zc(struct stmmac_priv *priv, int limit, u32 queue) >> len = 0; >> } >> >> +read_again: >> if (count >= limit) >> break; >> >> -read_again: >> buf1_len = 0; >> entry = next_entry; >> buf = &rx_q->buf_pool[entry]; >> @@ -5221,10 +5221,10 @@ static int stmmac_rx(struct stmmac_priv *priv, int limit, u32 queue) >> len = 0; >> } >> >> +read_again: >> if (count >= limit) >> break; >> >> -read_again: >> buf1_len = 0; >> buf2_len = 0; >> entry = next_entry; >> -- >> 2.39.2 >> -- Henneberg - Systemdesign Jochen Henneberg Loehnfeld 26 21423 Winsen (Luhe) -- Fon: +49 172 160 14 69 Url: https://www.henneberg-systemdesign.com _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel