From: Gregory CLEMENT <gregory.clement@bootlin.com>
To: "Marek Behún" <kabel@kernel.org>, "Pali Rohár" <pali@kernel.org>,
"Stephen Boyd" <sboyd@kernel.org>,
"Michael Turquette" <mturquette@baylibre.com>,
"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>
Cc: linux-clk@vger.kernel.org, linux-serial@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, "Marek Behún" <kabel@kernel.org>
Subject: Re: [PATCH v8 5/6] arm64: dts: marvell: armada-37xx: add device node for UART clock and use it
Date: Mon, 14 Feb 2022 16:46:25 +0100 [thread overview]
Message-ID: <87leydjvse.fsf@BL-laptop> (raw)
In-Reply-To: <20220211191238.2142-6-kabel@kernel.org>
Hello Marek and Pali,
> From: Pali Rohár <pali@kernel.org>
>
> Define DT node for UART clock "marvell,armada-3700-uart-clock" and use
> this UART clock as a base clock for all UART devices.
>
> Signed-off-by: Pali Rohár <pali@kernel.org>
> Reviewed-by: Marek Behún <kabel@kernel.org>
> Signed-off-by: Marek Behún <kabel@kernel.org>
Acked-by: Gregory CLEMENT <gregory.clement@bootlin.com>
However for keeping bisectability we have to ensure that this patch will
be applied after the drivers changes.
Thanks,
Gregory
> ---
> Changes since v7:
> - changed commit message ("This change defines" -> "Define")
> - added Marek's Reviewed-by tag
> ---
> arch/arm64/boot/dts/marvell/armada-37xx.dtsi | 14 ++++++++++++--
> 1 file changed, 12 insertions(+), 2 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/marvell/armada-37xx.dtsi b/arch/arm64/boot/dts/marvell/armada-37xx.dtsi
> index 673f4906eef9..4cf6c8aa0ac2 100644
> --- a/arch/arm64/boot/dts/marvell/armada-37xx.dtsi
> +++ b/arch/arm64/boot/dts/marvell/armada-37xx.dtsi
> @@ -132,10 +132,20 @@ avs: avs@11500 {
> reg = <0x11500 0x40>;
> };
>
> + uartclk: clock-controller@12010 {
> + compatible = "marvell,armada-3700-uart-clock";
> + reg = <0x12010 0x4>, <0x12210 0x4>;
> + clocks = <&tbg 0>, <&tbg 1>, <&tbg 2>,
> + <&tbg 3>, <&xtalclk>;
> + clock-names = "TBG-A-P", "TBG-B-P", "TBG-A-S",
> + "TBG-B-S", "xtal";
> + #clock-cells = <1>;
> + };
> +
> uart0: serial@12000 {
> compatible = "marvell,armada-3700-uart";
> reg = <0x12000 0x18>;
> - clocks = <&xtalclk>;
> + clocks = <&uartclk 0>;
> interrupts =
> <GIC_SPI 11 IRQ_TYPE_LEVEL_HIGH>,
> <GIC_SPI 12 IRQ_TYPE_LEVEL_HIGH>,
> @@ -147,7 +157,7 @@ uart0: serial@12000 {
> uart1: serial@12200 {
> compatible = "marvell,armada-3700-uart-ext";
> reg = <0x12200 0x30>;
> - clocks = <&xtalclk>;
> + clocks = <&uartclk 1>;
> interrupts =
> <GIC_SPI 30 IRQ_TYPE_EDGE_RISING>,
> <GIC_SPI 31 IRQ_TYPE_EDGE_RISING>;
> --
> 2.34.1
>
--
Gregory Clement, Bootlin
Embedded Linux and Kernel engineering
http://bootlin.com
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2022-02-14 15:48 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-11 19:12 [PATCH v8 0/6] serial: mvebu-uart: Support for higher baudrates Marek Behún
2022-02-11 19:12 ` [PATCH v8 1/6] math64: New DIV_U64_ROUND_CLOSEST helper Marek Behún
2022-02-11 19:12 ` [PATCH v8 2/6] dt-bindings: mvebu-uart: document DT bindings for marvell, armada-3700-uart-clock Marek Behún
2022-02-11 19:12 ` [PATCH v8 3/6] serial: mvebu-uart: implement UART clock driver for configuring UART base clock Marek Behún
2022-02-13 21:36 ` Marek Behún
2022-02-11 19:12 ` [PATCH v8 4/6] dt-bindings: mvebu-uart: update information about UART clock Marek Behún
2022-02-11 19:12 ` [PATCH v8 5/6] arm64: dts: marvell: armada-37xx: add device node for UART clock and use it Marek Behún
2022-02-14 15:46 ` Gregory CLEMENT [this message]
2022-02-11 19:12 ` [PATCH v8 6/6] serial: mvebu-uart: implement support for baudrates higher than 230400 Bd Marek Behún
2022-02-19 15:26 ` [PATCH v8 0/6] serial: mvebu-uart: Support for higher baudrates Pali Rohár
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87leydjvse.fsf@BL-laptop \
--to=gregory.clement@bootlin.com \
--cc=gregkh@linuxfoundation.org \
--cc=kabel@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=mturquette@baylibre.com \
--cc=pali@kernel.org \
--cc=sboyd@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).