From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 2BE1AC433EF for ; Mon, 29 Nov 2021 12:54:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-ID:Date:References :In-Reply-To:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=S4oPp5BnwCtGd4DOBEvzkc846ZFN5BFeW5L8+SKKFq0=; b=T882/S1ElD5g2W DT1eZTCEIGxpCRyzVf4B0vKE+VBk+1j6PsJR5k05hX4SZsWDxJ7PRpRjrnljElIh3l+Kn8kfKIERz 4je95uFdnwThD7mXghmujROYgpIktejs3uZfFa/nFhS4ygOviNEyzHr2EsmVwmp7iIWBMB4Yj1mSH lGGlRINKuAyeI2O5sE2vsTMcBS/HlQQ4+xiRubZd73D8zwS+5FqDjEQ6iQ3NEZGaBsQ6TwkbszFZV gB9K8f7pYfX6oQPaphqGRqUTeJQRRpz9Wl3Hgh6bm1r2+oUm4GOl/7dlUNmCjV2+UgEMG3NKgNCTD jISHSSKUQJZGyAIulCPg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mrg9Q-000kep-0t; Mon, 29 Nov 2021 12:52:56 +0000 Received: from galois.linutronix.de ([2a0a:51c0:0:12e:550::1]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mrg9L-000kdY-H8 for linux-arm-kernel@lists.infradead.org; Mon, 29 Nov 2021 12:52:52 +0000 From: Thomas Gleixner DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020; t=1638190367; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=4YfGqtKfqcg/VBb4scc+UNPvXNHJqUnbrO9jfKPdvNc=; b=HplVWLUyXX2hGBuDuAzepO9k9vKo4+aigansIMG5A6PgvComp9g/A8szrWNGO+DISdY1cO HzmwbYFzpO7Q/2IoKG933FYvlI+iakLvkkI3MW676OVlnc7A8MPybqGncMhSM56B+JB5UN PWbU+6wCNcKBNO1A+j34akq/xZ3+3aX1ItXbhwlzVpIdbOCrNj9jP2pah7Z/DMh8iXi0vY WQ4WxZl0EvS+kKrLf6K04nLtKxRo+NFQ3CXHYtdg12/OZVLnw9TMiwzne+FekVyS17Msmp St+PtqpCeGz+AJ4jXwZIiSDeE/g+SbXuSG9NDgfDEF4UJQ+4uLGw3cZ+2GnJcA== DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020e; t=1638190367; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=4YfGqtKfqcg/VBb4scc+UNPvXNHJqUnbrO9jfKPdvNc=; b=/vtVlvS+jCeXqOvFdJKQpUuqX073/P52p4KqQKu8Yr9vhveVqL5kazEV6dmh03ToVmk41R neyuByPAuatkkHDQ== To: Will Deacon Cc: LKML , Bjorn Helgaas , Marc Zygnier , Alex Williamson , Kevin Tian , Jason Gunthorpe , Megha Dey , Ashok Raj , linux-pci@vger.kernel.org, Greg Kroah-Hartman , Santosh Shilimkar , iommu@lists.linux-foundation.org, dmaengine@vger.kernel.org, Stuart Yoder , Laurentiu Tudor , Nishanth Menon , Tero Kristo , linux-arm-kernel@lists.infradead.org, x86@kernel.org, Vinod Koul , Mark Rutland , Sinan Kaya Subject: Re: [patch 33/37] iommu/arm-smmu-v3: Use msi_get_virq() In-Reply-To: <20211129105506.GA22761@willie-the-truck> References: <20211126224100.303046749@linutronix.de> <20211126230525.885757679@linutronix.de> <20211129105506.GA22761@willie-the-truck> Date: Mon, 29 Nov 2021 13:52:46 +0100 Message-ID: <87lf17dsyp.ffs@tglx> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20211129_045251_733660_FCA24A80 X-CRM114-Status: GOOD ( 10.32 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Will, On Mon, Nov 29 2021 at 10:55, Will Deacon wrote: > On Sat, Nov 27, 2021 at 02:20:59AM +0100, Thomas Gleixner wrote: >> + smmu->evtq.q.irq = msi_get_virq(dev, EVTQ_MSI_INDEX); >> + smmu->gerr_irq = msi_get_virq(dev, GERROR_MSI_INDEX); >> + smmu->priq.q.irq = msi_get_virq(dev, PRIQ_MSI_INDEX); > > Prviously, if retrieval of the MSI failed then we'd fall back to wired > interrupts. Now, I think we'll clobber the interrupt with 0 instead. Can > we make the assignments to smmu->*irq here conditional on the MSI being > valid, please? So the wired irq number is in ->irq already and MSI does an override if available. Not really obvious... Thanks, tglx _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel