From: Marc Zyngier <maz@kernel.org>
To: Pingfan Liu <kernelfans@gmail.com>
Cc: linux-arm-kernel@lists.infradead.org,
Catalin Marinas <catalin.marinas@arm.com>,
Will Deacon <will@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
Joey Gouly <joey.gouly@arm.com>,
Sami Tolvanen <samitolvanen@google.com>,
Julien Thierry <julien.thierry@arm.com>,
Thomas Gleixner <tglx@linutronix.de>,
Yuichi Ito <ito-yuichi@fujitsu.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCHv2 5/5] irqchip/GICv3: make reschedule-ipi light weight
Date: Wed, 29 Sep 2021 08:24:34 +0100 [thread overview]
Message-ID: <87lf3fu9n1.wl-maz@kernel.org> (raw)
In-Reply-To: <20210924132837.45994-6-kernelfans@gmail.com>
On Fri, 24 Sep 2021 14:28:37 +0100,
Pingfan Liu <kernelfans@gmail.com> wrote:
>
> To achieve the light weight as
> DEFINE_IDTENTRY_SYSVEC_SIMPLE(sysvec_reschedule_ipi) on x86, it had
> better treat irqnr differently at the frontend. And let IPI_RESCHEDULE
> call __irq_enter_raw() instead of irq_enter_rcu().
>
> Signed-off-by: Pingfan Liu <kernelfans@gmail.com>
> Cc: Catalin Marinas <catalin.marinas@arm.com>
> Cc: Will Deacon <will@kernel.org>
> Cc: Mark Rutland <mark.rutland@arm.com>
> Cc: Marc Zyngier <maz@kernel.org>
> Cc: Joey Gouly <joey.gouly@arm.com>
> Cc: Sami Tolvanen <samitolvanen@google.com>
> Cc: Julien Thierry <julien.thierry@arm.com>
> Cc: Thomas Gleixner <tglx@linutronix.de>
> Cc: Yuichi Ito <ito-yuichi@fujitsu.com>
> Cc: linux-kernel@vger.kernel.org
> To: linux-arm-kernel@lists.infradead.org
> ---
> drivers/irqchip/irq-gic-v3.c | 15 +++++++++++++--
> 1 file changed, 13 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/irqchip/irq-gic-v3.c b/drivers/irqchip/irq-gic-v3.c
> index 906538fa8771..593d4539a209 100644
> --- a/drivers/irqchip/irq-gic-v3.c
> +++ b/drivers/irqchip/irq-gic-v3.c
> @@ -709,6 +709,9 @@ static void gic_handle_nmi(struct pt_regs *regs)
> gic_deactivate_unhandled(irqnr);
> }
>
> +/* RESCHEDULE IPI hwirq nr is 0, and the only raw one */
> +static unsigned long raw_interrupt_mask = 1;
I'm afraid you have the wrong end of the stick. This isn't a GIC
property. This is an architecture decision, and only the architecture
can expose what they want.
M.
--
Without deviation from the norm, progress is not possible.
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2021-09-29 7:26 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-24 13:28 [PATCHv2 0/5] arm64/irqentry: remove duplicate housekeeping of Pingfan Liu
2021-09-24 13:28 ` [PATCHv2 1/5] arm64/entry-common: push the judgement of nmi ahead Pingfan Liu
2021-09-24 17:53 ` Mark Rutland
2021-09-25 15:39 ` Pingfan Liu
2021-09-30 13:32 ` Mark Rutland
2021-10-08 4:01 ` Pingfan Liu
2021-10-08 14:55 ` Pingfan Liu
2021-10-08 17:25 ` Mark Rutland
2021-10-09 3:49 ` Pingfan Liu
2021-10-08 15:45 ` Paul E. McKenney
2021-10-09 4:14 ` Pingfan Liu
2021-09-24 13:28 ` [PATCHv2 2/5] irqchip/GICv3: expose handle_nmi() directly Pingfan Liu
2021-09-24 13:28 ` [PATCHv2 3/5] kernel/irq: make irq_{enter, exit}() in handle_domain_irq() arch optional Pingfan Liu
2021-09-28 8:55 ` [PATCHv2 3/5] kernel/irq: make irq_{enter,exit}() " Mark Rutland
2021-09-29 3:15 ` Pingfan Liu
2021-09-24 13:28 ` [PATCHv2 4/5] irqchip/GICv3: let gic_handle_irq() utilize irqentry on arm64 Pingfan Liu
2021-09-28 9:10 ` Mark Rutland
2021-09-29 3:10 ` Pingfan Liu
2021-09-29 7:20 ` Marc Zyngier
2021-09-29 8:27 ` Pingfan Liu
2021-09-29 9:23 ` Mark Rutland
2021-09-29 11:40 ` Pingfan Liu
2021-09-29 14:29 ` Pingfan Liu
2021-09-29 17:41 ` Mark Rutland
2021-09-24 13:28 ` [PATCHv2 5/5] irqchip/GICv3: make reschedule-ipi light weight Pingfan Liu
2021-09-29 7:24 ` Marc Zyngier [this message]
2021-09-29 8:32 ` Pingfan Liu
2021-09-24 17:36 ` [PATCHv2 0/5] arm64/irqentry: remove duplicate housekeeping of Mark Rutland
2021-09-24 22:59 ` Paul E. McKenney
2021-09-27 9:23 ` Mark Rutland
2021-09-28 0:09 ` Paul E. McKenney
2021-09-28 8:32 ` Mark Rutland
2021-09-28 8:35 ` Mark Rutland
2021-09-28 9:52 ` Sven Schnelle
2021-09-28 10:26 ` Mark Rutland
2021-09-28 13:55 ` Paul E. McKenney
2021-09-25 15:12 ` Pingfan Liu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87lf3fu9n1.wl-maz@kernel.org \
--to=maz@kernel.org \
--cc=catalin.marinas@arm.com \
--cc=ito-yuichi@fujitsu.com \
--cc=joey.gouly@arm.com \
--cc=julien.thierry@arm.com \
--cc=kernelfans@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=samitolvanen@google.com \
--cc=tglx@linutronix.de \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).