From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.2 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1F490C433C1 for ; Tue, 23 Mar 2021 17:39:48 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 4AB6561554 for ; Tue, 23 Mar 2021 17:39:47 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 4AB6561554 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Transfer-Encoding :Content-Type:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:Subject:Cc:To: From:Message-ID:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=+jVwiqMjjf0nlYMxF3beeT3r/EBMzcSVbz8Npy1na+Y=; b=Bf4V20ics6bpUQPMQEHo4mMfb ljUs9+DWCpXovp1j7k0qJCvSg+1kWgBy8QUpsnBvnjnv6s6Vdgf3ioUeuvpPBTOvBB9fs2qCYB7a5 wnO0evf3bq8CB6lZC9HcjB0H9kWEPoIN4e+5yYc+a2s5+a9LAxuMiUgX6qcWRly/MI5Bgd0bjvAWl 5LixeVRajXok+hL3E14hd0P7NQWpFK5qBwMUFtnQvSnFBEA5qykTSLZ+8LMcYWk9wD2ywmk9uhJ/h TM+xX7eF2Utj6UENCM1QyEr99QtCEPEWOunedbBlIqI8h08hKn+2w4ktzTL1KV6VPBKYaKJegs6gG Z6MQChcyg==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1lOkyf-00FQdX-Kt; Tue, 23 Mar 2021 17:38:01 +0000 Received: from mail.kernel.org ([198.145.29.99]) by desiato.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lOkyP-00FQaA-5g for linux-arm-kernel@lists.infradead.org; Tue, 23 Mar 2021 17:37:47 +0000 Received: from disco-boy.misterjones.org (disco-boy.misterjones.org [51.254.78.96]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 7B8F2600EF; Tue, 23 Mar 2021 17:37:43 +0000 (UTC) Received: from 78.163-31-62.static.virginmediabusiness.co.uk ([62.31.163.78] helo=why.misterjones.org) by disco-boy.misterjones.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94) (envelope-from ) id 1lOkyL-003MEC-Dt; Tue, 23 Mar 2021 17:37:41 +0000 Date: Tue, 23 Mar 2021 17:37:40 +0000 Message-ID: <87lfadkbyz.wl-maz@kernel.org> From: Marc Zyngier To: Yoan Picchi Cc: james.morse@arm.com, julien.thierry.kdev@gmail.com, suzuki.poulose@arm.com, linux-arm-kernel@lists.infradead.org, kvmarm@lists.cs.columbia.edu, catalin.marinas@arm.com, will@kernel.org Subject: Re: [PATCH 7/7] KVM: arm64: Add irq_inject counter for kvm_stat In-Reply-To: <20210319161711.24972-8-yoan.picchi@arm.com> References: <20210319161711.24972-1-yoan.picchi@arm.com> <20210319161711.24972-8-yoan.picchi@arm.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/27.1 (x86_64-pc-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") X-SA-Exim-Connect-IP: 62.31.163.78 X-SA-Exim-Rcpt-To: yoan.picchi@arm.com, james.morse@arm.com, julien.thierry.kdev@gmail.com, suzuki.poulose@arm.com, linux-arm-kernel@lists.infradead.org, kvmarm@lists.cs.columbia.edu, catalin.marinas@arm.com, will@kernel.org X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210323_173745_584421_ADB858B0 X-CRM114-Status: GOOD ( 20.95 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, 19 Mar 2021 16:17:11 +0000, Yoan Picchi wrote: > > Add a counter for interrupt injections. That is when kvm relay an > interrupt to the guest (for instance a timer, or a device interrupt > like from a network card) > > Signed-off-by: Yoan Picchi > --- > arch/arm64/include/asm/kvm_host.h | 2 ++ > arch/arm64/kvm/arm.c | 2 ++ > arch/arm64/kvm/guest.c | 2 ++ > arch/arm64/kvm/vgic/vgic.c | 2 ++ > 4 files changed, 8 insertions(+) > > diff --git a/arch/arm64/include/asm/kvm_host.h b/arch/arm64/include/asm/kvm_host.h > index fa59b669c..253acb8c2 100644 > --- a/arch/arm64/include/asm/kvm_host.h > +++ b/arch/arm64/include/asm/kvm_host.h > @@ -551,6 +551,7 @@ struct kvm_vm_stat { > ulong memory_slot_unmaped; > ulong stage2_unmap_vm; > ulong cached_page_invalidated; > + ulong irq_inject; > }; > > struct kvm_vcpu_stat { > @@ -567,6 +568,7 @@ struct kvm_vcpu_stat { > u64 mmio_exit_kernel; > u64 regular_page_mapped; > u64 huge_page_mapped; > + u64 irq_inject; > u64 exits; > }; > > diff --git a/arch/arm64/kvm/arm.c b/arch/arm64/kvm/arm.c > index fc4c95dd2..841551f14 100644 > --- a/arch/arm64/kvm/arm.c > +++ b/arch/arm64/kvm/arm.c > @@ -895,6 +895,8 @@ static int vcpu_interrupt_line(struct kvm_vcpu *vcpu, int number, bool level) > bool set; > unsigned long *hcr; > > + vcpu->stat.irq_inject++; > + > if (number == KVM_ARM_IRQ_CPU_IRQ) > bit_index = __ffs(HCR_VI); > else /* KVM_ARM_IRQ_CPU_FIQ */ > diff --git a/arch/arm64/kvm/guest.c b/arch/arm64/kvm/guest.c > index 129c0d53d..f663b03ae 100644 > --- a/arch/arm64/kvm/guest.c > +++ b/arch/arm64/kvm/guest.c > @@ -45,6 +45,8 @@ struct kvm_stats_debugfs_item debugfs_entries[] = { > VM_STAT("memory_slot_unmaped", memory_slot_unmaped), > VM_STAT("stage2_unmap_vm", stage2_unmap_vm), > VM_STAT("cached_page_invalidated", cached_page_invalidated), > + VM_STAT("irq_inject", irq_inject), > + VCPU_STAT("irq_inject", irq_inject), > VCPU_STAT("exits", exits), > VCPU_STAT("halt_poll_success_ns", halt_poll_success_ns), > VCPU_STAT("halt_poll_fail_ns", halt_poll_fail_ns), > diff --git a/arch/arm64/kvm/vgic/vgic.c b/arch/arm64/kvm/vgic/vgic.c > index 1c597c988..9e504243b 100644 > --- a/arch/arm64/kvm/vgic/vgic.c > +++ b/arch/arm64/kvm/vgic/vgic.c > @@ -458,6 +458,8 @@ int kvm_vgic_inject_irq(struct kvm *kvm, int cpuid, unsigned int intid, > > raw_spin_lock_irqsave(&irq->irq_lock, flags); > > + kvm->stat.irq_inject++; > + > if (!vgic_validate_injection(irq, level, owner)) { So even if the injection failed, you report an injection? And what about injection that occur via the MMIO interface? What about direct injection? What about a level interrupt that is forever high? M. -- Without deviation from the norm, progress is not possible. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel